Re: [Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate

2018-09-17 Thread Paolo Bonzini
On 17/09/2018 10:31, Fam Zheng wrote: > This option is added together with scsi-disk but is never honoured, > becuase we don't emulate the VPD page for scsi-block. We could intercept > and inject the user specified value like for max xfer len, but it's > probably not helpful since the intent of 070

Re: [Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate

2018-09-17 Thread Fam Zheng
On Mon, 09/17 10:55, Thomas Huth wrote: > On 2018-09-17 10:31, Fam Zheng wrote: > > This option is added together with scsi-disk but is never honoured, > > becuase we don't emulate the VPD page for scsi-block. We could intercept > > and inject the user specified value like for max xfer len, but it'

Re: [Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate

2018-09-17 Thread Thomas Huth
On 2018-09-17 10:31, Fam Zheng wrote: > This option is added together with scsi-disk but is never honoured, > becuase we don't emulate the VPD page for scsi-block. We could intercept > and inject the user specified value like for max xfer len, but it's > probably not helpful since the intent of 070

[Qemu-devel] [RFC PATCH] scsi-block: Deprecate rotation_rate

2018-09-17 Thread Fam Zheng
This option is added together with scsi-disk but is never honoured, becuase we don't emulate the VPD page for scsi-block. We could intercept and inject the user specified value like for max xfer len, but it's probably not helpful since the intent of 070f80095ad was for random entropy aspects, not f