Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Yonit Halperin
Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add arbitrary amounts of downtime to the

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 05:10 PM, Yonit Halperin wrote: Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 06:54 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Spice client migration has nothing to do with guest migration. Trying to I don't understand this POV. If it were a VNC connection instead of

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 07:05:44PM +0800, Anthony Liguori wrote: On 06/06/2012 06:54 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Spice client migration has nothing to do with guest migration. Trying to

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 07:27 PM, Alon Levy wrote: If there is an active VNC client then it is there as a result of a user choosing to use it, so it should be treated as part of the user experience and not as something external. The experience from ignoring this and choosing to treat the remote console as

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Yonit Halperin
On 06/06/2012 12:22 PM, Anthony Liguori wrote: On 06/06/2012 05:10 PM, Yonit Halperin wrote: Hi, I would like to add some more points to Gerd's explanation: On 06/05/2012 04:15 PM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not*

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event and call it a day. Using a QMP event is making spice seamless migration dependent on libvirt version. That is not an acceptable justification. Delaying the status change to

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event and call it a day. Using a QMP event is making spice seamless migration dependent on libvirt version. That

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:15 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event and call it a day. Using a QMP event is making spice seamless migration

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 08:17:29PM +0800, Anthony Liguori wrote: On 06/06/2012 08:15 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony Liguori wrote: So send a QMP event and

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Anthony Liguori
On 06/06/2012 08:30 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:17:29PM +0800, Anthony Liguori wrote: On 06/06/2012 08:15 PM, Alon Levy wrote: On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: On 06/06/2012 08:01 PM, Yonit Halperin wrote: On 06/06/2012 12:22 PM, Anthony

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Gerd Hoffmann
Hi, I literally have danpb's event introspection patches from Luiz's PULL request testing on my system right now to be pushed. Good. this?: [PATCH 29/29] Add 'query-events' command to QMP to query async events This is about libvirt getting qemu's event list. I am talking about qemu

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Alon Levy
On Wed, Jun 06, 2012 at 03:03:37PM +0200, Gerd Hoffmann wrote: Hi, I literally have danpb's event introspection patches from Luiz's PULL request testing on my system right now to be pushed. Good. this?: [PATCH 29/29] Add 'query-events' command to QMP to query async events This

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-06 Thread Gerd Hoffmann
Hi, If libvirt doesn't support this event we want to fall back to semi-seamless migration, Ah, ok. Yes, a new -spice option will work here. cheers, Gerd

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-05 Thread Anthony Liguori
On 06/05/2012 01:49 PM, Yonit Halperin wrote: Hi, I'm sending this patch series again. This time with an additional patch for setting a migrate_end notifier completion callback for spice migration interface. I've also added more detailed commit messages. This patch series introduces async

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-05 Thread Gerd Hoffmann
Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add arbitrary amounts of downtime to the migration traffic. That's a terrible idea. I'd like to be more constructive in my response, but you aren't

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-05 Thread Eric Blake
On 06/05/2012 07:15 AM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add arbitrary amounts of downtime to the migration traffic. That's a terrible idea. So, the big question

Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-05 Thread Anthony Liguori
On 06/05/2012 09:38 PM, Eric Blake wrote: On 06/05/2012 07:15 AM, Gerd Hoffmann wrote: Hi, Absolutely not. This is hideously ugly and affects a bunch of code. Spice is *not* getting a hook in migration where it gets to add arbitrary amounts of downtime to the migration traffic. That's a

[Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers

2012-06-04 Thread Yonit Halperin
Hi, I'm sending this patch series again. This time with an additional patch for setting a migrate_end notifier completion callback for spice migration interface. I've also added more detailed commit messages. This patch series introduces async handlers for notifiers, and integrates them with