Re: [Qemu-devel] [RFC PATCH 02/11] qapi-types.py: Implement 'base' for unions

2013-07-11 Thread Eric Blake
On 07/09/2013 03:53 AM, Kevin Wolf wrote: The new 'base' key in a union definition refers to a struct type, which is inlined into the union definition and can represent fields common to all kinds. Is it worth listing an example of intended use in the commit message? If I understand correctly,

Re: [Qemu-devel] [RFC PATCH 02/11] qapi-types.py: Implement 'base' for unions

2013-07-11 Thread Eric Blake
On 07/11/2013 05:57 AM, Eric Blake wrote: On 07/09/2013 03:53 AM, Kevin Wolf wrote: The new 'base' key in a union definition refers to a struct type, which is inlined into the union definition and can represent fields common to all kinds. Is it worth listing an example of intended use in

[Qemu-devel] [RFC PATCH 02/11] qapi-types.py: Implement 'base' for unions

2013-07-09 Thread Kevin Wolf
The new 'base' key in a union definition refers to a struct type, which is inlined into the union definition and can represent fields common to all kinds. Signed-off-by: Kevin Wolf kw...@redhat.com --- scripts/qapi-types.py | 20 ++-- 1 file changed, 18 insertions(+), 2