Re: [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later

2015-02-26 Thread Paolo Bonzini
On 25/02/2015 15:22, Max Reitz wrote: 3. nbd_co_discard() quorum doens't call bdrv_co_discard(), so it is OK to return -EIO here. That can change, so I think you should return -EIO either everywhere or nowhere. Which probably means nowhere. Hm, okay. How about adding an option to

Re: [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later

2015-02-25 Thread Max Reitz
On 2015-02-24 at 21:23, Wen Congyang wrote: On 02/24/2015 05:31 AM, Max Reitz wrote: On 2015-02-11 at 22:07, Wen Congyang wrote: The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com

Re: [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later

2015-02-24 Thread Wen Congyang
On 02/24/2015 05:31 AM, Max Reitz wrote: On 2015-02-11 at 22:07, Wen Congyang wrote: The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang

Re: [Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later

2015-02-23 Thread Max Reitz
On 2015-02-11 at 22:07, Wen Congyang wrote: The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei

[Qemu-devel] [RFC PATCH 06/14] NBD client: connect to nbd server later

2015-02-11 Thread Wen Congyang
The secondary qemu starts later than the primary qemu, so we cannot connect to nbd server in bdrv_open(). Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- block/nbd.c | 100