Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Amit Shah
On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: From: Masami Hiramatsu masami.hiramatsu...@hitachi.com Add a failback memcpy path for unstealable pipe buffer. If buf-ops-steal() fails, virtio-serial tries to copy the page contents to an allocated page, instead of just failing

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Borislav Petkov
On Thu, Aug 09, 2012 at 02:33:12PM +0530, Amit Shah wrote: @@ -807,9 +807,31 @@ static int pipe_to_sg(struct pipe_inode_info *pipe, struct pipe_buffer *buf, len = min(buf-len, sd-len); sg_set_page((sgl-sg[sgl-n]), buf-page, len, buf-offset); -

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Masami Hiramatsu
(2012/08/09 18:03), Amit Shah wrote: On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: From: Masami Hiramatsu masami.hiramatsu...@hitachi.com Add a failback memcpy path for unstealable pipe buffer. If buf-ops-steal() fails, virtio-serial tries to copy the page contents to an

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Amit Shah
On (Thu) 09 Aug 2012 [18:24:58], Masami Hiramatsu wrote: (2012/08/09 18:03), Amit Shah wrote: On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: From: Masami Hiramatsu masami.hiramatsu...@hitachi.com Add a failback memcpy path for unstealable pipe buffer. If buf-ops-steal()

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Avi Kivity
On 08/09/2012 12:55 PM, Amit Shah wrote: On (Thu) 09 Aug 2012 [18:24:58], Masami Hiramatsu wrote: (2012/08/09 18:03), Amit Shah wrote: On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: From: Masami Hiramatsu masami.hiramatsu...@hitachi.com Add a failback memcpy path for

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Amit Shah
On (Thu) 09 Aug 2012 [12:58:13], Avi Kivity wrote: On 08/09/2012 12:55 PM, Amit Shah wrote: On (Thu) 09 Aug 2012 [18:24:58], Masami Hiramatsu wrote: (2012/08/09 18:03), Amit Shah wrote: On (Tue) 24 Jul 2012 [11:37:18], Yoshihiro YUNOMAE wrote: From: Masami Hiramatsu

Re: [Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-08-09 Thread Steven Rostedt
On Thu, 2012-08-09 at 18:24 +0900, Masami Hiramatsu wrote: Yeah, it is really easy to fix that. But out of curiosity, would that be really a problem? I guess that host can access any guest page if need. If that is right, is that really insecure to leak randomly allocated unused page to the

[Qemu-devel] [RFC PATCH 2/6] virtio/console: Add a failback for unstealable pipe buffer

2012-07-23 Thread Yoshihiro YUNOMAE
From: Masami Hiramatsu masami.hiramatsu...@hitachi.com Add a failback memcpy path for unstealable pipe buffer. If buf-ops-steal() fails, virtio-serial tries to copy the page contents to an allocated page, instead of just failing splice(). Signed-off-by: Masami Hiramatsu