Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-08 Thread Gerd Hoffmann
On Fr, 2015-06-05 at 15:54 +0200, Kővágó Zoltán wrote: Hi, 2015-06-05 12:57 keltezéssel, Gerd Hoffmann írta: Yeah, I've already hit a problem. The opts_visitor doesn't really handle nested structs (it just flattens it into a single, non hierarchic namespace), which is a problem because

Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-05 Thread Gerd Hoffmann
Hi, Plus currently only alsa an oss seem to care about this option, so even if we keep it, we should probably move it into alsa's and oss's backend options. Makes sense. Looks good to me as draft to start working with. I expect we'll find some details which need tweeking when

Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-05 Thread Kővágó Zoltán
Hi, 2015-06-05 12:57 keltezéssel, Gerd Hoffmann írta: Yeah, I've already hit a problem. The opts_visitor doesn't really handle nested structs (it just flattens it into a single, non hierarchic namespace), which is a problem because of the input and output options. First I need to make them

Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-04 Thread Kővágó Zoltán
Hi, 2015-06-04 17:30 keltezéssel, Gerd Hoffmann írta: Not sure about this one, so it's not yet in this patch: * remove poll_mode: another obscure setting, and it's only matter of time until the code bitrots enough to break it. I'd tend to drop this too, but it's probably good to check what

Re: [Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-04 Thread Gerd Hoffmann
Hi, Not sure about this one, so it's not yet in this patch: * remove poll_mode: another obscure setting, and it's only matter of time until the code bitrots enough to break it. I'd tend to drop this too, but it's probably good to check what exactly it is doing and to test whenever it

[Qemu-devel] [RFC PATCH v2] qapi for audio backends

2015-06-04 Thread Kővágó, Zoltán
Changes from v1: * fixed style issues * moved definitions into a separate file * documented undocumented options (hopefully) * removed plive option. It was useless even years ago so it can probably safely go away: https://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg02427.html * removed