Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-12-01 Thread Halil Pasic
On 11/30/2017 02:32 PM, Cornelia Huck wrote: > On Thu, 30 Nov 2017 13:32:12 +0100 > Halil Pasic wrote: > > (...) > > Before I spend way too much time on this: > > Is the proposed machine-property interface usable from a libvirt POV? > IOW, can we go with this now

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-30 Thread Cornelia Huck
On Thu, 30 Nov 2017 13:32:12 +0100 Halil Pasic wrote: (...) Before I spend way too much time on this: Is the proposed machine-property interface usable from a libvirt POV? IOW, can we go with this now and fix the ugliness later (probably via a generic overhaul of the

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-30 Thread Halil Pasic
On 11/29/2017 06:29 PM, Cornelia Huck wrote: [..] With this change, however, our schema for generating a css bus ids, if none is specified does not make much sense. Currently we start at cssid 0x0 for non-virtual devices and use the default css (without s390-squash-mcss

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Dong Jia Shi
* Cornelia Huck [2017-11-29 12:47:47 +0100]: [...] > > With this patch > > === > > > > +---+- > > | squashing off | squashing on > > +---+- > > auto id |F | F

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Dong Jia Shi
* Halil Pasic [2017-11-29 17:30:15 +0100]: > > > On 11/29/2017 12:47 PM, Cornelia Huck wrote: > > On Wed, 29 Nov 2017 16:17:35 +0800 > > Dong Jia Shi wrote: > > > >> * Halil Pasic [2017-11-28 14:07:58 +0100]: >

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Cornelia Huck
On Wed, 29 Nov 2017 17:25:59 +0100 Halil Pasic wrote: > On 11/29/2017 01:37 PM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 14:07:58 +0100 > > Halil Pasic wrote: > > > >> The default css 0xfe is currently restricted to virtual subchannel >

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Halil Pasic
On 11/29/2017 12:47 PM, Cornelia Huck wrote: > On Wed, 29 Nov 2017 16:17:35 +0800 > Dong Jia Shi wrote: > >> * Halil Pasic [2017-11-28 14:07:58 +0100]: >> >> [...] >>> The auto-generated bus ids are affected by both changes. We hope to

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Halil Pasic
On 11/29/2017 01:37 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 14:07:58 +0100 > Halil Pasic wrote: > >> The default css 0xfe is currently restricted to virtual subchannel >> devices. The hope when the decision was made was, that non-virtual >> subchannel devices

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Cornelia Huck
On Tue, 28 Nov 2017 14:07:58 +0100 Halil Pasic wrote: > The default css 0xfe is currently restricted to virtual subchannel > devices. The hope when the decision was made was, that non-virtual > subchannel devices will come around when guest can exploit multiple

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Cornelia Huck
On Wed, 29 Nov 2017 16:17:35 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-11-28 14:07:58 +0100]: > > [...] > > > > The auto-generated bus ids are affected by both changes. We hope to not > > encounter any auto-generated bus ids in

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Dong Jia Shi
* Dong Jia Shi [2017-11-29 16:17:35 +0800]: [...] > T6. squashing off + explicit given id > qemu-system-s390x: vmstate: get_nullptr expected VMS_NULLPTR_MARKER > qemu-system-s390x: Failed to load s390_css:css > qemu-system-s390x: error while loading state for

Re: [Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-29 Thread Dong Jia Shi
* Halil Pasic [2017-11-28 14:07:58 +0100]: [...] > > The auto-generated bus ids are affected by both changes. We hope to not > encounter any auto-generated bus ids in production as Libvirt is always > explicit about the bus id. Since 8ed179c937 ("s390x/css: catch

[Qemu-devel] [RFC PATCH v2 1/1] s390x/css: unrestrict cssids

2017-11-28 Thread Halil Pasic
The default css 0xfe is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guest can exploit multiple channel subsystems. Since the guests generally don't do, the pain of the partitioned (cssid)