Il 25/08/2014 13:40, Pavel Dovgaluk ha scritto:
> Do you mean, that I should separate the migration patches from
> the replay ones and submit them in another series?
Yes, that will help getting the less controversial pieces in first.
Paolo
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Il 31/07/2014 17:21, Pavel Dovgalyuk ha scritto:
> > Pre load is necessary, because we switched off resetting VM while
> > loading in the replay mode.
>
> Then you should not add it now, but rather when you add replay. Treat
> this part of the
Il 31/07/2014 17:21, Pavel Dovgalyuk ha scritto:
> Pre load is necessary, because we switched off resetting VM while
> loading in the replay mode.
Then you should not add it now, but rather when you add replay. Treat
this part of the series as merely fixing migration bugs. In fact, I
suggest tha
Pre load is necessary, because we switched off resetting VM while loading in
the replay mode. Calling reset handlers generates irqs, that make loading
process non-deterministic.
Sent from mobile device
Исходное сообщение
От: Paolo Bonzini
Дата:31.07.2014 17:01 (GMT+04:0
Il 31/07/2014 14:54, Pavel Dovgalyuk ha scritto:
> +static int apic_pre_load(void *opaque)
> +{
> +APICCommonState *s = APIC_COMMON(opaque);
> +s->sipi_vector = 0;
> +s->wait_for_sipi = 0;
> +s->vapic_paddr = 0;
> +return 0;
Is this necessary? Or does reset already do that?
>
vapic state should not be synchronized with APIC while loading,
because APIC state could be not loaded yet at that moment.
We just save vapic_paddr in APIC VMState instead of synchronization.
Signed-off-by: Pavel Dovgalyuk
---
hw/i386/kvmvapic.c | 22 +++
hw/intc/apic_
