Re: [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid

On 8/15/19 11:01 AM, Aleksandar Markovic wrote: > > 15.08.2019. 04.23, "Jan Bobek" > је написао/ла: >> >> Introduce a helper function to take care of instruction CPUID checks. >> >> Signed-off-by: Jan Bobek mailto:jan.bo...@gmail.com>> >> --- > > Jan, what is the

Re: [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid

On August 15, 2019 4:01:33 PM GMT+01:00, Aleksandar Markovic > >The function should be called check_cpuid(), imho. I know, Richard >would >like c_ci(), or simpler cc(), better. Now you're just playing the fool. Cut it out. r~

Re: [Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid

15.08.2019. 04.23, "Jan Bobek" је написао/ла: > > Introduce a helper function to take care of instruction CPUID checks. > > Signed-off-by: Jan Bobek > --- Jan, what is the origin of "CK"? If it is a QEMU internal thing, perhaps use "CHECK". The function should be called check_cpuid(), imho. I

[Qemu-devel] [RFC PATCH v3 15/46] target/i386: introduce function ck_cpuid

Introduce a helper function to take care of instruction CPUID checks. Signed-off-by: Jan Bobek --- target/i386/translate.c | 48 + 1 file changed, 48 insertions(+) diff --git a/target/i386/translate.c b/target/i386/translate.c index