Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-06-24 Thread Paolo Bonzini
On 31/05/2015 08:11, Peter Crosthwaite wrote: +/* If not executing code then assume we are ok. */ +if (cpu-current_tb == NULL) { +return true; +} +return cpu-can_do_io != 0; For what it's worth, I think the if here is dead. Pavel? Paolo

Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-06-24 Thread Paolo Bonzini
On 24/06/2015 13:40, Pavel Dovgaluk wrote: +/* If not executing code then assume we are ok. */ +if (cpu-current_tb == NULL) { +return true; +} +return cpu-can_do_io != 0; For what it's worth, I think the if here is dead. Pavel? cpu_can_do_io can be

Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-06-24 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 31/05/2015 08:11, Peter Crosthwaite wrote: +/* If not executing code then assume we are ok. */ +if (cpu-current_tb == NULL) { +return true; +} +return cpu-can_do_io != 0;

Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-06-24 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 24/06/2015 13:40, Pavel Dovgaluk wrote: +/* If not executing code then assume we are ok. */ +if (cpu-current_tb == NULL) { +return true; +} +return cpu-can_do_io != 0; For what it's worth, I

Re: [Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-06-01 Thread Richard Henderson
On 05/30/2015 11:11 PM, Peter Crosthwaite wrote: This function has no architecture specific dependencies and should be callable from core code. Move it to qom/cpu.h. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- Reviewed-by: Richard Henderson r...@twiddle.net r~

[Qemu-devel] [RFC v2 07/34] exec-all: Move cpu_can_do_io to qom/cpu.h

2015-05-31 Thread Peter Crosthwaite
This function has no architecture specific dependencies and should be callable from core code. Move it to qom/cpu.h. Signed-off-by: Peter Crosthwaite crosthwaite.pe...@gmail.com --- include/exec/exec-all.h | 21 - include/qom/cpu.h | 21 + 2 files