Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Peter Xu (pet...@redhat.com) wrote: > On Fri, Aug 25, 2017 at 10:30:42AM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > > c) As mentioned on irc there's fun to be had with cur_mon and error > > > > handling - in my local world I have cur_mon declared as __thread > > > > but

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Peter Xu (pet...@redhat.com) wrote: > On Mon, Aug 28, 2017 at 12:11:38PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, Aug 28, 2017 at 5:05 AM, Peter Xu wrote: > > > On Fri, Aug 25, 2017 at 04:07:34PM +, Marc-André Lureau wrote: > > >> On Fri, Aug 25, 2017 at

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Marc-André Lureau writes: > Hi > > On Mon, Aug 28, 2017 at 6:24 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Mon, Aug 28, 2017 at 1:08 PM Markus Armbruster >>

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Mon, Aug 28, 2017 at 6:24 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Mon, Aug 28, 2017 at 1:08 PM Markus Armbruster > wrote: > > > >> Marc-André Lureau writes:

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Marc-André Lureau writes: > Hi > > On Mon, Aug 28, 2017 at 1:08 PM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert < >> dgilb...@redhat.com> >> >

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

On Mon, Aug 28, 2017 at 12:11:38PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Aug 28, 2017 at 5:05 AM, Peter Xu wrote: > > On Fri, Aug 25, 2017 at 04:07:34PM +, Marc-André Lureau wrote: > >> On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert > >>

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Mon, Aug 28, 2017 at 1:08 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > >> * Marc-André Lureau (marcandre.lur...@gmail.com)

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Marc-André Lureau writes: > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert > wrote: > >> * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: >> > Hi >> > >> > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: >> > >>

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Mon, Aug 28, 2017 at 5:05 AM, Peter Xu wrote: > On Fri, Aug 25, 2017 at 04:07:34PM +, Marc-André Lureau wrote: >> On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert >> wrote: >> >> > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: >>

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

On Fri, Aug 25, 2017 at 10:30:42AM +0100, Dr. David Alan Gilbert wrote: [...] > > > c) As mentioned on irc there's fun to be had with cur_mon and error > > > handling - in my local world I have cur_mon declared as __thread > > > but never got around to thinking aobut what should set

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

On Fri, Aug 25, 2017 at 04:07:34PM +, Marc-André Lureau wrote: > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert > wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Fri, Aug 25, 2017 at 6:29 PM Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > In (2), info cpus > > > > shouldn't keep the BQL (my qapi-async series would probably help > here) > > > > > > How does that work? > > > > > > >

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Fri, Aug 25, 2017 at 6:12 PM Dr. David Alan Gilbert > wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert < > >

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Fri, Aug 25, 2017 at 6:12 PM Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > > > * Marc-André Lureau

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert > wrote: > > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > > Hi > > > > > > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: >

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: > > > > > Firstly, introduce Monitor.use_thread, and set it for monitors

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: > > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > using non-mux typed backend chardev. We only do this for monitors, so > >

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Hi On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: > Firstly, introduce Monitor.use_thread, and set it for monitors that are > using non-mux typed backend chardev. We only do this for monitors, so > mux-typed chardevs are not suitable (when it connects to, e.g., serials >

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Peter Xu (pet...@redhat.com) wrote: > On Wed, Aug 23, 2017 at 06:35:35PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > > using non-mux typed backend chardev. We only do this for

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

On Wed, Aug 23, 2017 at 06:35:35PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Firstly, introduce Monitor.use_thread, and set it for monitors that are > > using non-mux typed backend chardev. We only do this for monitors, so > > mux-typed chardevs are not

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

* Peter Xu (pet...@redhat.com) wrote: > Firstly, introduce Monitor.use_thread, and set it for monitors that are > using non-mux typed backend chardev. We only do this for monitors, so > mux-typed chardevs are not suitable (when it connects to, e.g., serials > and the monitor together). > > When

[Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

Firstly, introduce Monitor.use_thread, and set it for monitors that are using non-mux typed backend chardev. We only do this for monitors, so mux-typed chardevs are not suitable (when it connects to, e.g., serials and the monitor together). When use_thread is set, we create standalone thread to