Re: [Qemu-devel] [RFC v4 08/13] hw/vfio/common: Add EXEC_FLAG to VFIO DMA mappings

2014-07-07 Thread Eric Auger
On 07/07/2014 03:25 PM, Alvise Rigo wrote: > Il 07/07/2014 14:49, Will Deacon ha scritto: >> On Mon, Jul 07, 2014 at 01:27:18PM +0100, Eric Auger wrote: >>> From: Alvise Rigo >>> >>> The flag is mandatory for the ARM SMMU so we always add it if the MMIO >>> handles it. >> >> I though the logic of

Re: [Qemu-devel] [RFC v4 08/13] hw/vfio/common: Add EXEC_FLAG to VFIO DMA mappings

2014-07-07 Thread Alvise Rigo
Il 07/07/2014 14:49, Will Deacon ha scritto: > On Mon, Jul 07, 2014 at 01:27:18PM +0100, Eric Auger wrote: >> From: Alvise Rigo >> >> The flag is mandatory for the ARM SMMU so we always add it if the MMIO >> handles it. > > I though the logic of this flag was changing (so that you request an NX >

[Qemu-devel] [RFC v4 08/13] hw/vfio/common: Add EXEC_FLAG to VFIO DMA mappings

2014-07-07 Thread Eric Auger
From: Alvise Rigo The flag is mandatory for the ARM SMMU so we always add it if the MMIO handles it. Signed-off-by: Alvise Rigo --- hw/vfio/common.c | 9 + include/hw/vfio/vfio-common.h | 1 + linux-headers/linux/vfio.h| 2 ++ 3 files changed, 12 insertions(+) diff --

Re: [Qemu-devel] [RFC v4 08/13] hw/vfio/common: Add EXEC_FLAG to VFIO DMA mappings

2014-07-07 Thread Will Deacon
On Mon, Jul 07, 2014 at 01:27:18PM +0100, Eric Auger wrote: > From: Alvise Rigo > > The flag is mandatory for the ARM SMMU so we always add it if the MMIO > handles it. I though the logic of this flag was changing (so that you request an NX mapping instead), so I'd hold off on this change until

Re: [Qemu-devel] [RFC v4 08/13] hw/vfio/common: Add EXEC_FLAG to VFIO DMA mappings

2014-07-07 Thread Peter Maydell
On 7 July 2014 13:27, Eric Auger wrote: > From: Alvise Rigo > > The flag is mandatory for the ARM SMMU so we always add it if the MMIO > handles it. > > Signed-off-by: Alvise Rigo > --- > hw/vfio/common.c | 9 + > include/hw/vfio/vfio-common.h | 1 + > linux-headers/linux/v