Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Paul Durrant
> -Original Message- [snip] > > > > > > The old implementation has the sector size hardcoded: > > > > > > #define BLOCK_SIZE 512 > > > > > > Whereas the qdevified version uses DEFINE_BLOCK_PROPERTIES(), which > > > includes user-visible options for logical/physical_block_size. > > > >

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Kevin Wolf
Am 01.04.2019 um 11:01 hat Paul Durrant geschrieben: > > -Original Message- > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Sent: 28 March 2019 11:56 > > To: Andrew Cooper > > Cc: Anthony Perard ; Paul Durrant > > ; xen- > > de...@lists.xenproject.org; qemu-bl...@nongnu.org;

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 28 March 2019 11:56 > To: Andrew Cooper > Cc: Anthony Perard ; Paul Durrant > ; xen- > de...@lists.xenproject.org; qemu-bl...@nongnu.org; qemu-devel@nongnu.org; > Stefano Stabellini > ; Max Reitz ; Stefan Hajnoczi

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-04-01 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 28 March 2019 11:46 > To: Anthony Perard ; Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-bl...@nongnu.org; > qemu-devel@nongnu.org; Kevin Wolf > ; Stefano Stabellini ; Max Reitz > ; Stefan > Hajnoczi > Subject: Re:

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-28 Thread Kevin Wolf
Am 28.03.2019 um 12:46 hat Andrew Cooper geschrieben: > On 28/03/2019 11:40, Anthony PERARD wrote: > > On Wed, Mar 27, 2019 at 08:32:28PM +, Paul Durrant wrote: > >>> -Original Message- > >>> From: Andrew Cooper > >>> Sent: 27 March 2019 18:20 > >>> To: Paul Durrant ; > >>>

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-28 Thread Andrew Cooper
On 28/03/2019 11:40, Anthony PERARD wrote: > On Wed, Mar 27, 2019 at 08:32:28PM +, Paul Durrant wrote: >>> -Original Message- >>> From: Andrew Cooper >>> Sent: 27 March 2019 18:20 >>> To: Paul Durrant ; xen-de...@lists.xenproject.org; >>> qemu-bl...@nongnu.org; >>>

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-28 Thread Anthony PERARD
On Wed, Mar 27, 2019 at 08:32:28PM +, Paul Durrant wrote: > > -Original Message- > > From: Andrew Cooper > > Sent: 27 March 2019 18:20 > > To: Paul Durrant ; xen-de...@lists.xenproject.org; > > qemu-bl...@nongnu.org; > > qemu-devel@nongnu.org > > Cc: Kevin Wolf ; Stefano Stabellini >

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper > Sent: 27 March 2019 18:20 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > qemu-bl...@nongnu.org; > qemu-devel@nongnu.org > Cc: Kevin Wolf ; Stefano Stabellini > ; Max Reitz > ; Stefan Hajnoczi ; Anthony Perard > > Subject: Re:

Re: [Qemu-devel] [Xen-devel] [PATCH v2 0/2] xen-block: fix sector size confusion

2019-03-27 Thread Andrew Cooper
On 27/03/2019 17:32, Paul Durrant wrote: > The Xen blkif protocol is confusing but discussion with the maintainer > has clarified that sector based quantities in requests and the 'sectors' > value advertized in xenstore should always be in terms of 512-byte > units and not the advertised logical