Re: [Qemu-devel] [libvirt] Configuring pflash devices for OVMF firmware

2019-01-30 Thread Gerd Hoffmann
Hi, > > (Migration compat is left as an exercise for the reader :-)) > > It's not just migration compatibility, it's also guest ABI: "the guest > can tell the difference". Is that actually the case on x86? I don't think so. Note: arm is different, because the flash is listed in the device

Re: [Qemu-devel] [libvirt] Configuring pflash devices for OVMF firmware

2019-01-29 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 28 Jan 2019 at 12:40, Gerd Hoffmann wrote: >> The tricky part is the access control here. On physical hardware you >> typically have one flash rom, say 16M below 4G (on x86). >> >> Our pflash device doesn't allow to define multiple regions, so we use >> multiple

Re: [Qemu-devel] [libvirt] Configuring pflash devices for OVMF firmware

2019-01-28 Thread Laszlo Ersek
On 01/28/19 14:06, Peter Maydell wrote: > On Mon, 28 Jan 2019 at 12:40, Gerd Hoffmann wrote: >> The tricky part is the access control here. On physical hardware you >> typically have one flash rom, say 16M below 4G (on x86). >> >> Our pflash device doesn't allow to define multiple regions, so we

Re: [Qemu-devel] [libvirt] Configuring pflash devices for OVMF firmware

2019-01-28 Thread Peter Maydell
On Mon, 28 Jan 2019 at 14:56, Laszlo Ersek wrote: > Regarding OVMF, I kept the flash driver intentionally in the dark about > split vs. unified pflash, so OVMF will not care, as long as the same > GPAs behave the same as before. > > Regarding ArmVirtQemu, I'm not so sure. It think it already

Re: [Qemu-devel] [libvirt] Configuring pflash devices for OVMF firmware

2019-01-28 Thread Laszlo Ersek
On 01/28/19 15:58, Peter Maydell wrote: > On Mon, 28 Jan 2019 at 14:56, Laszlo Ersek wrote: >> Regarding OVMF, I kept the flash driver intentionally in the dark about >> split vs. unified pflash, so OVMF will not care, as long as the same >> GPAs behave the same as before. >> >> Regarding

Re: [Qemu-devel] [libvirt] Configuring pflash devices for OVMF firmware

2019-01-28 Thread Peter Maydell
On Mon, 28 Jan 2019 at 12:40, Gerd Hoffmann wrote: > The tricky part is the access control here. On physical hardware you > typically have one flash rom, say 16M below 4G (on x86). > > Our pflash device doesn't allow to define multiple regions, so we use > multiple pflash devices instead, each

Re: [Qemu-devel] [libvirt] Configuring pflash devices for OVMF firmware

2019-01-28 Thread Gerd Hoffmann
Hi, > > Issue (1) isn't too hard: we add the device to the dynamic sysbus device > > white-list, move a sysbus_mmio_map() from pflash_cfi01_realize() into > > pflash_cfi01_realize(). The latter requires a new device property to > > configure the base address. I got a working prototype. Since