Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-13 Thread Cornelia Huck
On Wed, 13 Mar 2019 12:10:50 -0400 "Jason J. Herne" wrote: > On 3/13/19 10:04 AM, Eric Farman wrote: > >> +static void run_readipl(SubChannelId schid) > >> +{ > >> +if (do_cio(schid, 0x00, CCW_FMT0)) { > >> +panic("dasd-ipl: Failed to run Read IPL channel program"); > > > > Maybe 

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-13 Thread Jason J. Herne
On 3/13/19 12:21 PM, Cornelia Huck wrote: On Wed, 13 Mar 2019 12:10:50 -0400 "Jason J. Herne" wrote: On 3/13/19 10:04 AM, Eric Farman wrote: +static void run_readipl(SubChannelId schid) +{ +if (do_cio(schid, 0x00, CCW_FMT0)) { +panic("dasd-ipl: Failed to run Read IPL channel 

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-13 Thread Eric Farman
On 03/13/2019 12:27 PM, Jason J. Herne wrote: On 3/13/19 12:21 PM, Cornelia Huck wrote: On Wed, 13 Mar 2019 12:10:50 -0400 "Jason J. Herne" wrote: On 3/13/19 10:04 AM, Eric Farman wrote: +static void run_readipl(SubChannelId schid) +{ +if (do_cio(schid, 0x00, CCW_FMT0)) { +

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-13 Thread Jason J. Herne
On 3/13/19 10:04 AM, Eric Farman wrote: +static void run_readipl(SubChannelId schid) +{ +if (do_cio(schid, 0x00, CCW_FMT0)) { +panic("dasd-ipl: Failed to run Read IPL channel program"); Maybe add a newline here... +} There are three places you are suggesting a newline. All

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 15/16] s390-bios: Support booting from real dasd device

2019-03-13 Thread Eric Farman
On 03/01/2019 01:59 PM, Jason J. Herne wrote: Allows guest to boot from a vfio configured real dasd device. Signed-off-by: Jason J. Herne --- MAINTAINERS | 1 + docs/devel/s390-dasd-ipl.txt | 133 +++ pc-bios/s390-ccw/Makefile| 2 +-