Re: [Qemu-devel] [qemu-s390x] [PATCH v6 01/12] s390-ccw: refactor boot map table code

2018-02-16 Thread Thomas Huth
On 16.02.2018 15:57, Collin L. Walling wrote: > On 02/16/2018 07:19 AM, Viktor Mihajlovski wrote: >> On 16.02.2018 11:42, Thomas Huth wrote: >>> On 15.02.2018 23:54, Collin L. Walling wrote: Some ECKD bootmap code was using structs designed for SCSI. Even though this works, it confuses

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 01/12] s390-ccw: refactor boot map table code

2018-02-16 Thread Collin L. Walling
On 02/16/2018 07:19 AM, Viktor Mihajlovski wrote: On 16.02.2018 11:42, Thomas Huth wrote: On 15.02.2018 23:54, Collin L. Walling wrote: Some ECKD bootmap code was using structs designed for SCSI. Even though this works, it confuses readability. Add a new BootMapTable struct to assist with

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 01/12] s390-ccw: refactor boot map table code

2018-02-16 Thread Viktor Mihajlovski
On 16.02.2018 11:42, Thomas Huth wrote: > On 15.02.2018 23:54, Collin L. Walling wrote: >> Some ECKD bootmap code was using structs designed for SCSI. >> Even though this works, it confuses readability. Add a new >> BootMapTable struct to assist with readability in bootmap >> entry code. Also: >>

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 01/12] s390-ccw: refactor boot map table code

2018-02-16 Thread Thomas Huth
On 15.02.2018 23:54, Collin L. Walling wrote: > Some ECKD bootmap code was using structs designed for SCSI. > Even though this works, it confuses readability. Add a new > BootMapTable struct to assist with readability in bootmap > entry code. Also: > > - replace ScsiMbr in ECKD code with