Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-19 Thread Wei Wang
On 06/19/2017 03:46 AM, Michael S. Tsirkin wrote: What do you have in mind about the protocol flag? Merely this: older clients might be confused if they get a s/g with 1024 entries. I don't disagree to add that. But the client (i.e. vhost-user slave) is a host userspace program, and it seems

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-18 Thread Michael S. Tsirkin
On Sat, Jun 17, 2017 at 04:37:02PM +0800, Wei Wang wrote: > On 06/16/2017 11:15 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 16, 2017 at 06:10:27PM +0800, Wei Wang wrote: > > > On 06/16/2017 04:57 PM, Jason Wang wrote: > > > > > > > > On 2017年06月16日 11:22, Michael S. Tsirkin wrote: > > > > > > I

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-17 Thread Wei Wang
On 06/16/2017 11:15 PM, Michael S. Tsirkin wrote: On Fri, Jun 16, 2017 at 06:10:27PM +0800, Wei Wang wrote: On 06/16/2017 04:57 PM, Jason Wang wrote: On 2017年06月16日 11:22, Michael S. Tsirkin wrote: I think the issues can be solved by VIRTIO_F_MAX_CHAIN_SIZE. For now, how about splitting it

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-16 Thread Michael S. Tsirkin
On Fri, Jun 16, 2017 at 07:04:27PM +0200, Maxime Coquelin wrote: > > > On 06/16/2017 05:19 PM, Michael S. Tsirkin wrote: > > On Fri, Jun 16, 2017 at 04:57:01PM +0800, Jason Wang wrote: > > > > > > > > > On 2017年06月16日 11:22, Michael S. Tsirkin wrote: > > > > > I think the issues can be solved

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-16 Thread Maxime Coquelin
On 06/16/2017 05:19 PM, Michael S. Tsirkin wrote: On Fri, Jun 16, 2017 at 04:57:01PM +0800, Jason Wang wrote: On 2017年06月16日 11:22, Michael S. Tsirkin wrote: I think the issues can be solved by VIRTIO_F_MAX_CHAIN_SIZE. For now, how about splitting it into two series of patches: 1) enable

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-16 Thread Michael S. Tsirkin
On Fri, Jun 16, 2017 at 04:57:01PM +0800, Jason Wang wrote: > > > On 2017年06月16日 11:22, Michael S. Tsirkin wrote: > > > I think the issues can be solved by VIRTIO_F_MAX_CHAIN_SIZE. > > > > > > For now, how about splitting it into two series of patches: > > > 1) enable 1024 tx queue size for

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-16 Thread Michael S. Tsirkin
On Fri, Jun 16, 2017 at 06:10:27PM +0800, Wei Wang wrote: > On 06/16/2017 04:57 PM, Jason Wang wrote: > > > > > > On 2017年06月16日 11:22, Michael S. Tsirkin wrote: > > > > I think the issues can be solved by VIRTIO_F_MAX_CHAIN_SIZE. > > > > > > > > For now, how about splitting it into two series

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-16 Thread Wei Wang
On 06/16/2017 04:57 PM, Jason Wang wrote: On 2017年06月16日 11:22, Michael S. Tsirkin wrote: I think the issues can be solved by VIRTIO_F_MAX_CHAIN_SIZE. For now, how about splitting it into two series of patches: 1) enable 1024 tx queue size for vhost-user, to let the users of vhost-user to

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-16 Thread Jason Wang
On 2017年06月16日 11:22, Michael S. Tsirkin wrote: I think the issues can be solved by VIRTIO_F_MAX_CHAIN_SIZE. For now, how about splitting it into two series of patches: 1) enable 1024 tx queue size for vhost-user, to let the users of vhost-user to easily use 1024 queue size. Fine with me. 1)

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-15 Thread Michael S. Tsirkin
On Thu, Jun 15, 2017 at 02:52:01PM +0800, Wei Wang wrote: > On 06/15/2017 12:16 PM, Jason Wang wrote: > > > > > > On 2017年06月14日 23:22, Michael S. Tsirkin wrote: > > > On Wed, Jun 14, 2017 at 07:26:54PM +0800, Jason Wang wrote: > > > > > > > > On 2017年06月13日 18:46, Jason Wang wrote: > > > > >

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v1] virtio-net: enable configurable tx queue size

2017-06-15 Thread Wei Wang
On 06/15/2017 12:16 PM, Jason Wang wrote: On 2017年06月14日 23:22, Michael S. Tsirkin wrote: On Wed, Jun 14, 2017 at 07:26:54PM +0800, Jason Wang wrote: On 2017年06月13日 18:46, Jason Wang wrote: On 2017年06月13日 17:50, Wei Wang wrote: On 06/13/2017 05:04 PM, Jason Wang wrote: On 2017年06月13日