Re: [Qemu-devel] [PATCH v3 3/4] hw/misc/pvpanic: Add the MMIO interface

2018-10-18 Thread peng.hao2
> >Signed-off-by: Peng Hao >Signed-off-by: Philippe Mathieu-Daudé >[PMD: Use TYPE_PVPANIC definition, split in 2 patches] >--- >Peng: I hope this is now more obvious how you could reuse the pvpanic device. > Thanks. I will think about your suggestions and patches. >hw/misc/pvpanic.c | 52

Re: [Qemu-devel] [PATCH v3 3/4] hw/misc/pvpanic: Add the MMIO interface

2018-10-18 Thread Peter Maydell
On 18 October 2018 at 14:19, Philippe Mathieu-Daudé wrote: > On 18/10/2018 15:08, Peter Maydell wrote: >> This field is the parent-type for the QOM object, so I don't >> think it makes sense for it to be a union. Any one QOM object >> should have a single distinct parent type. (There are other >>

Re: [Qemu-devel] [PATCH v3 3/4] hw/misc/pvpanic: Add the MMIO interface

2018-10-18 Thread Philippe Mathieu-Daudé
On 18/10/2018 15:08, Peter Maydell wrote: > On 18 October 2018 at 14:04, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Peng Hao >> Signed-off-by: Philippe Mathieu-Daudé >> [PMD: Use TYPE_PVPANIC definition, split in 2 patches] >> --- >> Peng: I hope this is now more obvious how you could

Re: [Qemu-devel] [PATCH v3 3/4] hw/misc/pvpanic: Add the MMIO interface

2018-10-18 Thread Peter Maydell
On 18 October 2018 at 14:04, Philippe Mathieu-Daudé wrote: > Signed-off-by: Peng Hao > Signed-off-by: Philippe Mathieu-Daudé > [PMD: Use TYPE_PVPANIC definition, split in 2 patches] > --- > Peng: I hope this is now more obvious how you could reuse the pvpanic device. > > hw/misc/pvpanic.c | 52

[Qemu-devel] [PATCH v3 3/4] hw/misc/pvpanic: Add the MMIO interface

2018-10-18 Thread Philippe Mathieu-Daudé
Signed-off-by: Peng Hao Signed-off-by: Philippe Mathieu-Daudé [PMD: Use TYPE_PVPANIC definition, split in 2 patches] --- Peng: I hope this is now more obvious how you could reuse the pvpanic device. hw/misc/pvpanic.c | 52 ++- 1 file changed, 51