Re: [Qemu-devel] Add CMP2 instruction

2014-11-09 Thread Guo, Lei
Hi Laurent This pagraph exactly is a cutpaste of the Motorola Programmer's reference manual. I didn't mean to add it as commits to the patch.I just want to introduce this instruction to the reviewer. So don't worry about the copyrights. Best Regards Guo Lei Le 7 novembre 2014

[Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Guo, Lei
This patch aims to add CMP2 instruction for m68k family. Description: Compares the value in Rn to each bound. The effective address contains the bounds pair: upper bound following the lower bound. For signed comparisons, the arithmetically smaller value should be used as the lower bound. For

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Alex Bennée
Guo, Lei guol-f...@cn.fujitsu.com writes: This patch aims to add CMP2 instruction for m68k family. Description: Compares the value in Rn to each bound. The effective address contains the bounds pair: upper bound following the lower bound. For signed comparisons, the arithmetically

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Andreas Färber
Hi, Am 07.11.2014 um 11:14 schrieb Guo, Lei: This patch aims to add CMP2 instruction for m68k family. *Description: *Compares the value in Rn to each bound. The effective address contains the bounds pair: upper bound following the lower bound. For signed comparisons, the

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Richard Henderson
On 11/07/2014 11:14 AM, Guo, Lei wrote: This patch aims to add CMP2 instruction for m68k family. Mainline target-m68k supports coldfire only. There is an external tree for full m68k support: https://gitorious.org/qemu-m68k That said, before you send this to them... +if (ext 0x8000)

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Laurent Vivier
Hi, did you test it ? because after just a first glance this patch seems wrong as the tmp variables cannot be used beyond the first tcg_gen_cond() (conditional branches clobber temporary vars), you must use tcg_temp_local_new() and tcg_temp_free(). Regards, Laurent Le 7 novembre 2014 à

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Laurent Vivier
Le 7 novembre 2014 à 11:14, Guo, Lei guol-f...@cn.fujitsu.com a écrit : This patch aims to add CMP2 instruction for m68k family. Description: Compares the value in Rn to each bound. The effective address contains the bounds pair: upper bound following the lower bound. For

Re: [Qemu-devel] Add CMP2 instruction

2014-11-07 Thread Andreas Schwab
Guo, Lei guol-f...@cn.fujitsu.com writes: @@ -2847,6 +2920,7 @@ void register_m68k_insns (CPUM68KState *env) INSN(bitop_reg, 01c0, f1c0, CF_ISA_A); INSN(arith_im, 0280, fff8, CF_ISA_A); INSN(byterev, 02c0, fff8, CF_ISA_APLUSC); +INSN(cmp2, 02c0, , CF_ISA_A);