RockerPort member @speed is documented to be "in Mbps" (presumably
Megabits/second).  It uses QAPI type 'uint32'.

This is inappropriate for QAPI/QMP.  It should have been made plain
bits/second (no multiple), and maybe 'uint64'.  As far as I can tell,
the QAPI part didn't get review from QAPI experts.  Probably because it
wasn't cc'ed to them.

Too late to fix now, but let's not repeat the mistake.

Reply via email to