Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-25 Thread Mark McLoughlin
On Tue, 2009-11-24 at 22:27 +0100, Pierre Riteau wrote: On 24 nov. 2009, at 12:22, Mark McLoughlin wrote: On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote: Isn't there a way to detect whether the kernel supports the TUNSETOFFLOAD ioctl at all? The kernel will set errno to

[Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-24 Thread Mark McLoughlin
On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote: vnet_hdr is initialized at 1 by default. We need to reset it to 0 if the kernel doesn't support IFF_VNET_HDR. Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr Thanks Pierre, I see why this is needed now Acked-by: Mark McLoughlin

Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-24 Thread Pierre Riteau
On 24 nov. 2009, at 11:28, Mark McLoughlin wrote: On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote: vnet_hdr is initialized at 1 by default. We need to reset it to 0 if the kernel doesn't support IFF_VNET_HDR. Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr Thanks Pierre, I see

Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-24 Thread Mark McLoughlin
On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote: On 24 nov. 2009, at 11:28, Mark McLoughlin wrote: On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote: vnet_hdr is initialized at 1 by default. We need to reset it to 0 if the kernel doesn't support IFF_VNET_HDR.

Re: [Qemu-devel] Re: [PATCH] Fix TAP networking on host kernels without IFF_VNET_HDR support

2009-11-24 Thread Pierre Riteau
On 24 nov. 2009, at 12:22, Mark McLoughlin wrote: On Tue, 2009-11-24 at 12:17 +0100, Pierre Riteau wrote: On 24 nov. 2009, at 11:28, Mark McLoughlin wrote: On Tue, 2009-11-24 at 10:06 +0100, Pierre Riteau wrote: vnet_hdr is initialized at 1 by default. We need to reset it to 0 if the