Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-17 Thread Kevin Wolf
Am 16.06.2010 17:57, schrieb Chris Lalancette: > On 06/16/10 - 05:32:58PM, Kevin Wolf wrote: >> Am 16.06.2010 17:22, schrieb Chris Lalancette: >>> On 06/16/10 - 03:15:11PM, Kevin Wolf wrote: Am 16.06.2010 14:59, schrieb Miguel Di Ciurcio Filho: > On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf

Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 12:22 PM, Chris Lalancette wrote: >> > I didn't mention in the commit, but I've looked at libvirt's source >> > and it is not using 'info snapshots' AFAIK. >> >> Anthony, Dan, are you okay with the change then? > > Right, exactly as Miguel said, libvirt doesn't use "info sn

Re: [Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 17:22, schrieb Chris Lalancette: > On 06/16/10 - 03:15:11PM, Kevin Wolf wrote: >> Am 16.06.2010 14:59, schrieb Miguel Di Ciurcio Filho: >>> On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf wrote: If the human monitor was exactly what its name says, I'd happily apply this on

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 14:59, schrieb Miguel Di Ciurcio Filho: > On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf wrote: >> >> If the human monitor was exactly what its name says, I'd happily apply >> this one (though I think it should be made clear from which image the VM >> state would be loaded). However, it

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Miguel Di Ciurcio Filho
On Wed, Jun 16, 2010 at 9:40 AM, Kevin Wolf wrote: > > If the human monitor was exactly what its name says, I'd happily apply > this one (though I think it should be made clear from which image the VM > state would be loaded). However, it isn't and I'm not sure if this > wouldn't break libvirt. Da

[Qemu-devel] Re: [PATCH] monitor: Really show snapshot information about all devices

2010-06-16 Thread Kevin Wolf
Am 16.06.2010 03:53, schrieb Miguel Di Ciurcio Filho: > The 'info snapshots' monitor command does not show snapshot information from > all > available block devices. > > Usage example: > $ qemu -hda disk1.qcow2 -hdb disk2.qcow2 > > (qemu) info snapshots > Snapshot devices: ide0-hd0 > Snapshot li