Am 09.12.2010 17:18, schrieb Alexander Graf:
Kevin Wolf wrote:
Am 09.12.2010 16:48, schrieb Alexander Graf:
+static void ncq_cb(void *opaque, int ret)
+{
+NCQTransferState *ncq_tfs = (NCQTransferState *)opaque;
+IDEState *ide_state;
+
+if (ret 0) {
+/* XXX error
On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf ag...@suse.de wrote:
+struct AHCIDevice {
+ IDEBus port;
+ int port_no;
+ uint32_t port_state;
+ uint32_t finished;
+ AHCIPortRegs port_regs;
+ struct AHCIState *hba;
+ uint8_t *lst;
+ uint8_t *res_fis;
+ uint8_t
Kevin Wolf wrote:
Am 09.12.2010 16:48, schrieb Alexander Graf:
+static void ncq_cb(void *opaque, int ret)
+{
+NCQTransferState *ncq_tfs = (NCQTransferState *)opaque;
+IDEState *ide_state;
+
+if (ret 0) {
+/* XXX error */
+}
Missing error
Stefan Hajnoczi wrote:
On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf ag...@suse.de wrote:
+struct AHCIDevice {
+IDEBus port;
+int port_no;
+uint32_t port_state;
+uint32_t finished;
+AHCIPortRegs port_regs;
+struct AHCIState *hba;
+uint8_t *lst;
+
Am 09.12.2010 16:48, schrieb Alexander Graf:
+static void ncq_cb(void *opaque, int ret)
+{
+NCQTransferState *ncq_tfs = (NCQTransferState *)opaque;
+IDEState *ide_state;
+
+if (ret 0) {
+/* XXX error */
+}
Missing error handling.
Yes, that's what the