[Qemu-devel] Re: [PATCH 1/6] pci: untangle pci/msi dependency

2010-12-09 Thread Michael S. Tsirkin
On Sat, Dec 04, 2010 at 02:35:53PM +0100, Paolo Bonzini wrote: On 12/02/2010 11:54 PM, Michael S. Tsirkin wrote: +bool assert = pcie_aer_root_does_trigger(root_cmd_set, root_status); Risky variable name, I think it would fail if someone includes assert.h. Paolo We already do, it

[Qemu-devel] Re: [PATCH 1/6] pci: untangle pci/msi dependency

2010-12-06 Thread Isaku Yamahata
On Fri, Dec 03, 2010 at 12:54:33AM +0200, Michael S. Tsirkin wrote: diff --git a/hw/pcie_aer.c b/hw/pcie_aer.c index 235ac53..18bbd5a 100644 --- a/hw/pcie_aer.c +++ b/hw/pcie_aer.c @@ -339,10 +339,10 @@ static bool pcie_aer_msg_root_port(PCIDevice *dev, const PCIEAERMsg *msg) if

[Qemu-devel] Re: [PATCH 1/6] pci: untangle pci/msi dependency

2010-12-04 Thread Paolo Bonzini
On 12/02/2010 11:54 PM, Michael S. Tsirkin wrote: +bool assert = pcie_aer_root_does_trigger(root_cmd_set, root_status); Risky variable name, I think it would fail if someone includes assert.h. Paolo