[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Alexander Graf
On 04.06.2010, at 15:48, Corentin Chary wrote: The tight quality level is a slider on most clients. A user doesn't know when it starts being lossy. He also can only choose 0 as the lowest (iirc). And IIRC the X tightvnc client also always sent the quality level. Alex You can use

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Corentin Chary
The tight quality level is a slider on most clients. A user doesn't know when it starts being lossy. He also can only choose 0 as the lowest (iirc). And IIRC the X tightvnc client also always sent the quality level. Alex You can use -nojpeg for that. Most vnc clients have this options.

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Corentin Chary
Phew - I didn't even know of that option until now. I guess that's a bad sign? :) One way I thought of it was to start being lossy as of quality level 6 or so. That way people who accidently enable jpeg still know high quality means lossless. I'm not sure Anthony agrees on this though.

[Qemu-devel] Re: [PATCH 2/5] vnc: JPEG should be disabled if the client don't set tight quality

2010-06-04 Thread Anthony Liguori
On 06/04/2010 08:16 AM, Alexander Graf wrote: On 04.06.2010, at 15:18, Corentin Chary wrote: Disable JPEG compression by default and only enable it if the VNC client has sent the requested quality. Signed-off-by: Corentin Charycorenti...@iksaif.net --- vnc.c |2 +- 1 files changed, 1