Re: [Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-09 Thread Jes Sorensen
On 12/07/10 18:19, Michael Roth wrote: On 12/07/2010 07:44 AM, Jes Sorensen wrote: +static int va_end_of_header(char *buf, int end_pos) +{ +return !strncmp(buf+(end_pos-2), \n\r\n, 3); +} Maybe I am missing something here, but it looks like you do a strncmp to a char that is one past

[Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-07 Thread Jes Sorensen
On 12/03/10 19:03, Michael Roth wrote: +static void va_server_read_cb(const char *content, size_t content_len) +{ +xmlrpc_mem_block *resp_xml; +VAServerData *server_data = va_state-server_data; +int ret; + +TRACE(called); +resp_xml =

Re: [Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-07 Thread Michael Roth
On 12/07/2010 07:44 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: +static void va_server_read_cb(const char *content, size_t content_len) +{ +xmlrpc_mem_block *resp_xml; +VAServerData *server_data =va_state-server_data; +int ret; + +TRACE(called); +resp_xml

[Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-06 Thread Adam Litke
On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: +static void va_http_send_handler(void *opaque) +{ +VAHTState *s = va_state-send_state; +enum va_http_status http_status; +int fd = va_state-fd; +int ret; + +TRACE(called, fd: %d, fd); + +switch (s-state) {

[Qemu-devel] Re: [RFC][PATCH v5 04/21] virtagent: transport definitions and job callbacks

2010-12-06 Thread Michael Roth
On 12/06/2010 04:02 PM, Adam Litke wrote: On Fri, 2010-12-03 at 12:03 -0600, Michael Roth wrote: +static void va_http_send_handler(void *opaque) +{ +VAHTState *s =va_state-send_state; +enum va_http_status http_status; +int fd = va_state-fd; +int ret; + +TRACE(called, fd: %d,