[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-06-08 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 06/04/2010 05:16 PM, Markus Armbruster wrote: - protocol: json-array of json-object Each element object has a member name - Possible values: file, nbd, ... Additional members depend on the value of name. For name = file: - file: file

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-06-06 Thread Avi Kivity
On 06/04/2010 05:16 PM, Markus Armbruster wrote: - protocol: json-array of json-object Each element object has a member name - Possible values: file, nbd, ... Additional members depend on the value of name. For name = file: - file: file name (json-string) For name = nbd:

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-06-04 Thread Markus Armbruster
Discussion with Christoph and Kevin uncovered yet another issue: protocols. I find it pretty confusing, but let me try to describe it anyway; Christoph and Kevin, please correct my errors. A host block device has a format. A format has a name. Below the format, it has a stack of protocols. A

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-06-04 Thread Kevin Wolf
Am 04.06.2010 16:16, schrieb Markus Armbruster: Discussion with Christoph and Kevin uncovered yet another issue: protocols. I find it pretty confusing, but let me try to describe it anyway; Christoph and Kevin, please correct my errors. A host block device has a format. A format has a

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-06-04 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 04.06.2010 16:16, schrieb Markus Armbruster: Discussion with Christoph and Kevin uncovered yet another issue: protocols. I find it pretty confusing, but let me try to describe it anyway; Christoph and Kevin, please correct my errors. A host block

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-06-04 Thread Kevin Wolf
Am 04.06.2010 17:53, schrieb Markus Armbruster: Kevin Wolf kw...@redhat.com writes: Am 04.06.2010 16:16, schrieb Markus Armbruster: Our abstraction for formats is struct BlockDriver. Our abstraction for protocols is also struct BlockDriver. Except for the special protocol file, but that's

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 05/28/2010 09:21 PM, Markus Armbruster wrote: snip, agreed Summary of the host / guest split: -drive options host or guest? bus, unit, if, index, addr guest, already covered by qdev cyls, heads, secs, trans

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the password and try again. It's what we do today, a password should be set with block_passwd before issuing the change

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Avi Kivity
On 05/31/2010 01:54 PM, Markus Armbruster wrote: We expose some of the cache property to the guest. IMO we need the cache property to be both guest and host, with qemu bridging the impedance mismatch if needed. Yes. How should the device properties look like?

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 05/31/2010 01:54 PM, Markus Armbruster wrote: We expose some of the cache property to the guest. IMO we need the cache property to be both guest and host, with qemu bridging the impedance mismatch if needed. Yes. How should the device

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Luiz Capitulino
On Mon, 31 May 2010 13:05:37 +0200 Markus Armbruster arm...@redhat.com wrote: Avi Kivity a...@redhat.com writes: On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the password and try again. It's what

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-31 Thread Kevin Wolf
Am 31.05.2010 15:48, schrieb Luiz Capitulino: On Mon, 31 May 2010 13:05:37 +0200 Markus Armbruster arm...@redhat.com wrote: Avi Kivity a...@redhat.com writes: On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-30 Thread Avi Kivity
On 05/28/2010 09:21 PM, Markus Armbruster wrote: snip, agreed Summary of the host / guest split: -drive options host or guest? bus, unit, if, index, addr guest, already covered by qdev cyls, heads, secs, transguest, new qdev properties

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-30 Thread Avi Kivity
On 05/28/2010 10:24 PM, Luiz Capitulino wrote: If a password is needed, we should throw an error and let the QMP client set the password and try again. It's what we do today, a password should be set with block_passwd before issuing the change command. Otherwise an error is throw.

[Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-28 Thread Kevin Wolf
Am 28.05.2010 20:21, schrieb Markus Armbruster: I'd like to give posting documentation of new QMP commands for review before posting code a try. But first let me explain briefly why we need new commands. We want a clean separation between host part (blockdev_add) and guest part

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-28 Thread Anthony Liguori
On 05/28/2010 02:13 PM, Kevin Wolf wrote: Am 28.05.2010 20:21, schrieb Markus Armbruster: I'd like to give posting documentation of new QMP commands for review before posting code a try. But first let me explain briefly why we need new commands. We want a clean separation between host

Re: [Qemu-devel] Re: RFC: blockdev_add friends, brief rationale, QMP docs

2010-05-28 Thread Luiz Capitulino
On Fri, 28 May 2010 14:17:07 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 05/28/2010 02:13 PM, Kevin Wolf wrote: Am 28.05.2010 20:21, schrieb Markus Armbruster: I'd like to give posting documentation of new QMP commands for review before posting code a try. But first let me