[Qemu-devel] There are two distinct qdevs named TYPE_OPENPROM

2013-10-29 Thread Markus Armbruster
sun4m.c and sun4u.c both define a qdev named TYPE_OPENPROM. As far as I can tell, they differ only in the name of their memory region. If they ever get linked into the same executable, type_register_internal() will reject the second one. But they aren't, so this isn't a bug. Is it bad style?

Re: [Qemu-devel] There are two distinct qdevs named TYPE_OPENPROM

2013-10-29 Thread Peter Maydell
On 29 October 2013 07:57, Markus Armbruster arm...@redhat.com wrote: sun4m.c and sun4u.c both define a qdev named TYPE_OPENPROM. As far as I can tell, they differ only in the name of their memory region. If they ever get linked into the same executable, type_register_internal() will reject

Re: [Qemu-devel] There are two distinct qdevs named TYPE_OPENPROM

2013-10-29 Thread Mark Cave-Ayland
On 29/10/13 14:32, Peter Maydell wrote: On 29 October 2013 07:57, Markus Armbrusterarm...@redhat.com wrote: sun4m.c and sun4u.c both define a qdev named TYPE_OPENPROM. As far as I can tell, they differ only in the name of their memory region. If they ever get linked into the same