[Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully (was: isa-applesmc doesn't handle second instantiation gracefully)

2010-10-12 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque [...] and a core dump. I know nothing about this device. Instantiating

Re: [Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully

2010-10-12 Thread Anthony Liguori
On 10/12/2010 08:00 AM, Markus Armbruster wrote: Markus Armbrusterarm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque [...] and a core

Re: [Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully

2010-10-12 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 10/12/2010 08:00 AM, Markus Armbruster wrote: Markus Armbrusterarm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error:

Re: [Qemu-devel] qdev: Some ISA devices don't handle second instantiation gracefully

2010-10-12 Thread Anthony Liguori
On 10/12/2010 08:54 AM, Markus Armbruster wrote: I think the proper thing to do is remove all exit(1)s and propagate errors instead. exit() is good enough during startup, i.e. -device. It's wrong for hot plug; anything to be used in a hot plug path must propagate errors. We could keep