[Qemu-devel] qemu openpty

2013-06-05 Thread Michael Tokarev
Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this issue. Here it is, from qemu-char.c: #ifdef

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Andreas Färber
Am 05.06.2013 12:28, schrieb Michael Tokarev: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Brad Smith
On 05/06/13 6:28 AM, Michael Tokarev wrote: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Brad Smith
On 05/06/13 6:28 AM, Michael Tokarev wrote: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Anthony Liguori
Michael Tokarev m...@tls.msk.ru writes: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Brad Smith
On 05/06/13 6:28 AM, Michael Tokarev wrote: Hello. One of old issues with compatibility between different *Nix systems was the way how pty pairs were allocated. And qemu have a twist in #includes, depending on which platform it is run, and quite some compat cruft in qemu-char.c about this

Re: [Qemu-devel] qemu openpty

2013-06-05 Thread Michael Tokarev
05.06.2013 15:23, Andreas Färber wrote: Am 05.06.2013 12:28, schrieb Michael Tokarev: [qemu_openpty() wrapper] I haven't tried yet, but this sounds like something for osdep.c, no need for a special qemu-openpty.c. This is a bit more tricky. At least on glibc, openpty() is in -lutil, but