Re: [RFC 11/15] target/riscv: rvb: generalized reverse

On 11/18/20 12:29 AM, frank.ch...@sifive.com wrote: > +static target_ulong do_grev(target_ulong rs1, > +target_ulong rs2, > +const target_ulong masks[]) > +{ I think the masks should be placed here, and not passed in. What you should pass in

[RFC 11/15] target/riscv: rvb: generalized reverse

From: Frank Chang Signed-off-by: Frank Chang --- target/riscv/bitmanip_helper.c | 79 + target/riscv/helper.h | 7 +++ target/riscv/insn32-64.decode | 2 + target/riscv/insn32.decode | 2 +