Re: [RFC PATCH 17/42] target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word)

2021-03-08 Thread Philippe Mathieu-Daudé
On 2/15/21 5:44 PM, Richard Henderson wrote: > On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: >> +tcg_gen_deposit_i64(cpu_gpr[a->rd], bx, ax, 32, 32); >> +tcg_gen_shri_i64(bx, bx, 32); >> +tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], ax, bx, 0, 32); > > I think you should pull this out

Re: [RFC PATCH 17/42] target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word)

2021-02-15 Thread Richard Henderson
On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote: > +tcg_gen_deposit_i64(cpu_gpr[a->rd], bx, ax, 32, 32); > +tcg_gen_shri_i64(bx, bx, 32); > +tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], ax, bx, 0, 32); I think you should pull this out as a helper: void gen_pextw(TCGv_i64 dl, TCGv_i64 dh,

[RFC PATCH 17/42] target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word)

2021-02-14 Thread Philippe Mathieu-Daudé
Introduce the PEXTUW opcode (Parallel Extend Upper from Word). Signed-off-by: Philippe Mathieu-Daudé --- target/mips/tx79.decode | 4 target/mips/tx79_translate.c | 26 ++ 2 files changed, 30 insertions(+) diff --git a/target/mips/tx79.decode