Re: [RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init

2020-04-25 Thread Dima Stepanov
On Fri, Apr 24, 2020 at 12:17:54PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, Apr 24, 2020 at 4:32 AM Raphael Norwitz > wrote: > > > > I’m not opposed to adding this kind of debugging functionality to the > > vhost-user-blk sample. It could be helpful to easily test these cases > > in the f

Re: [RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init

2020-04-24 Thread Marc-André Lureau
Hi On Fri, Apr 24, 2020 at 4:32 AM Raphael Norwitz wrote: > > I’m not opposed to adding this kind of debugging functionality to the > vhost-user-blk sample. It could be helpful to easily test these cases > in the future. > > That said, I'm not sure how others will feel about adding these kind > o

Re: [RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init

2020-04-23 Thread Raphael Norwitz
I’m not opposed to adding this kind of debugging functionality to the vhost-user-blk sample. It could be helpful to easily test these cases in the future. That said, I'm not sure how others will feel about adding these kind of debugging capabilities to libvhost-user. Marc-Andre, thoughts? If we g

[RFC PATCH v1 1/7] contrib/vhost-user-blk: add option to simulate disconnect on init

2020-04-23 Thread Dima Stepanov
Add "--simulate-disconnect-stage" option for the testing purposes. This option can be used to test the vhost-user reconnect functionality: ./vhost-user-blk ... --simulate-disconnect-stage= In this case the daemon will "crash" in the middle of the VHOST comands communication. Case nums are as foll