Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-11 Thread Christian Schoenebeck
On Dienstag, 11. Januar 2022 13:35:05 CET Christian Schoenebeck wrote: > Curiousity was stronger: the original clang behaviour was as I explained: > https://github.com/llvm-mirror/clang/commit/0a0d2b179085a52c10402feebeb6db8b >

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-11 Thread Christian Schoenebeck
On Montag, 10. Januar 2022 22:05:43 CET Christian Schoenebeck wrote: > On Montag, 10. Januar 2022 21:39:28 CET Akihiko Odaki wrote: > > On 2022/01/11 5:22, Christian Schoenebeck wrote: > > > On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote: > > >> On 2022/01/11 3:46, Christian

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Akihiko Odaki
On 2022/01/11 6:05, Christian Schoenebeck wrote: On Montag, 10. Januar 2022 21:39:28 CET Akihiko Odaki wrote: On 2022/01/11 5:22, Christian Schoenebeck wrote: On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote: On 2022/01/11 3:46, Christian Schoenebeck wrote: On Montag, 10.

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Christian Schoenebeck
On Montag, 10. Januar 2022 21:39:28 CET Akihiko Odaki wrote: > On 2022/01/11 5:22, Christian Schoenebeck wrote: > > On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote: > >> On 2022/01/11 3:46, Christian Schoenebeck wrote: > >>> On Montag, 10. Januar 2022 19:20:15 CET Akihiko Odaki wrote:

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Akihiko Odaki
On 2022/01/11 5:22, Christian Schoenebeck wrote: On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote: On 2022/01/11 3:46, Christian Schoenebeck wrote: On Montag, 10. Januar 2022 19:20:15 CET Akihiko Odaki wrote: On 2022/01/10 22:22, Peter Maydell wrote: On Mon, 10 Jan 2022 at

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Christian Schoenebeck
On Montag, 10. Januar 2022 20:01:40 CET Akihiko Odaki wrote: > On 2022/01/11 3:46, Christian Schoenebeck wrote: > > On Montag, 10. Januar 2022 19:20:15 CET Akihiko Odaki wrote: > >> On 2022/01/10 22:22, Peter Maydell wrote: > >>> On Mon, 10 Jan 2022 at 13:14, Christian Schoenebeck > >>> > >>>

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Peter Maydell
On Mon, 10 Jan 2022 at 19:01, Akihiko Odaki wrote: > Assuming the correctness of the use MAC_OS_X_VERSION_MAX_ALLOWED is > irrelevant with the nature of the identifier (constant or not), the same > problem is in ui/cocoa.m: > #ifndef MAC_OS_X_VERSION_10_13 > #define MAC_OS_X_VERSION_10_13 101300

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Akihiko Odaki
On 2022/01/11 3:46, Christian Schoenebeck wrote: On Montag, 10. Januar 2022 19:20:15 CET Akihiko Odaki wrote: On 2022/01/10 22:22, Peter Maydell wrote: On Mon, 10 Jan 2022 at 13:14, Christian Schoenebeck wrote: I'd suggest to use: #if !defined(MAC_OS_VERSION_12_0) ||

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Christian Schoenebeck
On Montag, 10. Januar 2022 19:20:15 CET Akihiko Odaki wrote: > On 2022/01/10 22:22, Peter Maydell wrote: > > On Mon, 10 Jan 2022 at 13:14, Christian Schoenebeck > > > > wrote: > >> I'd suggest to use: > >> > >> #if !defined(MAC_OS_VERSION_12_0) || > >> > >> (MAC_OS_X_VERSION_MAX_ALLOWED <

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Akihiko Odaki
On 2022/01/10 22:22, Peter Maydell wrote: On Mon, 10 Jan 2022 at 13:14, Christian Schoenebeck wrote: I'd suggest to use: #if !defined(MAC_OS_VERSION_12_0) || (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_VERSION_12_0) #define kAudioObjectPropertyElementMain kAudioObjectPropertyElementMaster

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 14:07, Christian Schoenebeck wrote: > On Montag, 10. Januar 2022 13:24:06 CET Philippe Mathieu-Daudé wrote: >> On 1/10/22 09:44, Philippe Mathieu-Daudé wrote: >>> On 1/10/22 09:17, Akihiko Odaki wrote: On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: > When building on macOS

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Peter Maydell
On Mon, 10 Jan 2022 at 13:14, Christian Schoenebeck wrote: > I'd suggest to use: > > #if !defined(MAC_OS_VERSION_12_0) || > (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_VERSION_12_0) > #define kAudioObjectPropertyElementMain kAudioObjectPropertyElementMaster > #endif This is also how we do this

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Christian Schoenebeck
On Montag, 10. Januar 2022 13:24:06 CET Philippe Mathieu-Daudé wrote: > On 1/10/22 09:44, Philippe Mathieu-Daudé wrote: > > On 1/10/22 09:17, Akihiko Odaki wrote: > >> On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: > >>> When building on macOS 12 we get: > >>> > >>>audio/coreaudio.c:50:5:

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 09:44, Philippe Mathieu-Daudé wrote: > On 1/10/22 09:17, Akihiko Odaki wrote: >> On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: >>> When building on macOS 12 we get: >>> >>>    audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' >>> is deprecated: first deprecated in

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Philippe Mathieu-Daudé
On 1/10/22 09:17, Akihiko Odaki wrote: > On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: >> When building on macOS 12 we get: >> >>    audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' >> is deprecated: first deprecated in macOS 12.0 >> [-Werror,-Wdeprecated-declarations] >>

Re: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-10 Thread Akihiko Odaki
On 2022/01/10 2:06, Philippe Mathieu-Daudé wrote: When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElementMaster

[RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-01-09 Thread Philippe Mathieu-Daudé
When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElementMaster ^