RE: [RFC PATCH v5 20/33] Hexagon (target/hexagon) generator phase 2 - generate header files

2020-12-01 Thread Taylor Simpson
> -Original Message- > From: Alessandro Di Federico > Sent: Thursday, November 19, 2020 4:54 PM > To: Taylor Simpson > Cc: qemu-devel@nongnu.org; Brian Cain ; > richard.hender...@linaro.org; at@qualcomm.com; laur...@vivier.eu > Subject: Re: [RFC PATCH v5 2

Re: [RFC PATCH v5 20/33] Hexagon (target/hexagon) generator phase 2 - generate header files

2020-11-21 Thread Alessandro Di Federico via
On Thu, 29 Oct 2020 19:08:26 -0500 Taylor Simpson wrote: > +def genptr_decl_new(f,regtype,regid,regno): > +if (regtype == "N"): > +if (regid in {"s", "t"}): > +f.write("const int %s%sX = insn->regno[%d];\n" % \ > +(regtype, regid, regno)) > +

Re: [RFC PATCH v5 20/33] Hexagon (target/hexagon) generator phase 2 - generate header files

2020-11-19 Thread Alessandro Di Federico via
On Thu, 29 Oct 2020 19:08:26 -0500 Taylor Simpson wrote: > +from hex_common import * I'd suggest to avoid `import *`. See: python -c 'import this' | sed -n '4p' -- Alessandro Di Federico rev.ng

[RFC PATCH v5 20/33] Hexagon (target/hexagon) generator phase 2 - generate header files

2020-10-29 Thread Taylor Simpson
Python scripts generate the following files helper_protos_generated.h For each instruction we create DEF_HELPER function prototype helper_funcs_generated.h For each instruction we create the helper function definition tcg_funcs_generated.h For each instruction

[RFC PATCH v5 20/33] Hexagon (target/hexagon) generator phase 2 - generate header files

2020-10-29 Thread Taylor Simpson
Python scripts generate the following files helper_protos_generated.h For each instruction we create DEF_HELPER function prototype helper_funcs_generated.h For each instruction we create the helper function definition tcg_funcs_generated.h For each instruction