Re: [RFC v5 004/126] hmp: drop Error pointer indirection in hmp_handle_error

2019-10-11 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 10/11/19 11:03 AM, Vladimir Sementsov-Ogievskiy wrote: > > We don't need Error **, as all callers pass local Error object, which > > isn't used after the call. Use Error * instead. > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > --- > >

Re: [RFC v5 004/126] hmp: drop Error pointer indirection in hmp_handle_error

2019-10-11 Thread Eric Blake
On 10/11/19 11:03 AM, Vladimir Sementsov-Ogievskiy wrote: We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/monitor/hmp.h | 2 +- dump/dump-hmp-cmds.c |

Re: [RFC v5 004/126] hmp: drop Error pointer indirection in hmp_handle_error

2019-10-11 Thread Dr. David Alan Gilbert
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote: > We don't need Error **, as all callers pass local Error object, which > isn't used after the call. Use Error * instead. > > Signed-off-by: Vladimir Sementsov-Ogievskiy for HMP Acked-by: Dr. David Alan Gilbert > --- >

[RFC v5 004/126] hmp: drop Error pointer indirection in hmp_handle_error

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
We don't need Error **, as all callers pass local Error object, which isn't used after the call. Use Error * instead. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/monitor/hmp.h | 2 +- dump/dump-hmp-cmds.c | 4 +- hw/core/machine-hmp-cmds.c | 6 +- monitor/hmp-cmds.c