Re: [RFC v5 054/126] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2019-11-19 Thread Greg Kurz
On Tue, 19 Nov 2019 16:59:23 + Vladimir Sementsov-Ogievskiy wrote: > 19.11.2019 19:56, Greg Kurz wrote: > > Sorry for the late review... > > > > On Fri, 11 Oct 2019 19:04:40 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> If we want to add some info to errp (by error_prepend() or >

Re: [RFC v5 054/126] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2019-11-19 Thread Vladimir Sementsov-Ogievskiy
19.11.2019 19:56, Greg Kurz wrote: > Sorry for the late review... > > On Fri, 11 Oct 2019 19:04:40 +0300 > Vladimir Sementsov-Ogievskiy wrote: > >> If we want to add some info to errp (by error_prepend() or >> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. >> Otherwise, this

Re: [RFC v5 054/126] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2019-11-19 Thread Greg Kurz
Sorry for the late review... On Fri, 11 Oct 2019 19:04:40 +0300 Vladimir Sementsov-Ogievskiy wrote: > If we want to add some info to errp (by error_prepend() or > error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. > Otherwise, this info will not be added when errp == _err

[RFC v5 054/126] virtio-9p: introduce ERRP_AUTO_PROPAGATE

2019-10-11 Thread Vladimir Sementsov-Ogievskiy
If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == _err (the program will exit prior to the error_append_hint() or error_prepend() call). Fix such cases. If we want to