Re: Bug: qemu-system-ppc -M mac99 boots into compat-monitor, not openbios.

[Paolo Bonzini]

On 16/12/20 22:16, Howard Spoelstra wrote:

Hi all,

It seems a qemu-system-ppc from current master no longer boots into 
openbios, but into to the compat monitor.

Command line to reproduce:
/home/hsp/src/qemu-master/build/qemu-system-ppc \
-L pc-bios \
-M mac99,via=pmu -m 1024 -boot c \
-drive file=/home/hsp/Mac-disks/9.2.img,format=raw,media=disk

Bisecting leads to this commit:

commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4
Author: Paolo Bonzini mailto:pbonz...@redhat.com>>
Date:   Tue Oct 27 08:44:23 2020 -0400

     vl: remove separate preconfig main_loop

     Move post-preconfig initialization to the x-exit-preconfig.  If 
preconfig

     is not requested, just exit preconfig mode immediately with the QMP
     command.

     As a result, the preconfig loop will run with accel_setup_post
     and os_setup_post restrictions (xen_restrict, chroot, etc.)
     already done.

     Reviewed-by: Igor Mammedov >
     Signed-off-by: Paolo Bonzini >


  include/sysemu/runstate.h |  1 -
  monitor/qmp-cmds.c        |  9 -
  softmmu/vl.c              | 95 
---

  3 files changed, 41 insertions(+), 64 deletions(-)

Thanks for looking into this,

Best,
Howard


Should be a one-line change, I have sent a patch.

Paolo

Bug: qemu-system-ppc -M mac99 boots into compat-monitor, not openbios.

[Howard Spoelstra]

Hi all,

It seems a qemu-system-ppc from current master no longer boots into
openbios, but into to the compat monitor.
Command line to reproduce:
/home/hsp/src/qemu-master/build/qemu-system-ppc \
-L pc-bios \
-M mac99,via=pmu -m 1024 -boot c \
-drive file=/home/hsp/Mac-disks/9.2.img,format=raw,media=disk

Bisecting leads to this commit:

commit b4e1a342112e50e05b609e857f38c1f2b7aafdc4
Author: Paolo Bonzini 
Date:   Tue Oct 27 08:44:23 2020 -0400

vl: remove separate preconfig main_loop

Move post-preconfig initialization to the x-exit-preconfig.  If
preconfig
is not requested, just exit preconfig mode immediately with the QMP
command.

As a result, the preconfig loop will run with accel_setup_post
and os_setup_post restrictions (xen_restrict, chroot, etc.)
already done.

Reviewed-by: Igor Mammedov 
Signed-off-by: Paolo Bonzini 

 include/sysemu/runstate.h |  1 -
 monitor/qmp-cmds.c|  9 -
 softmmu/vl.c  | 95
---
 3 files changed, 41 insertions(+), 64 deletions(-)

Thanks for looking into this,

Best,
Howard