Re: Compatibility between -device sga and -machine graphics=off

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 10:50:53PM +0200, Gerd Hoffmann wrote: > On Wed, Sep 08, 2021 at 05:08:08PM +0100, Daniel P. Berrangé wrote: > > Given the libvirt XML snippet > > > > > > ... > > > > ... > > > > > > libvirt QEMU driver will always format > > > > -device sga > > > >

Re: Compatibility between -device sga and -machine graphics=off

2021-09-08 Thread Gerd Hoffmann
On Wed, Sep 08, 2021 at 05:08:08PM +0100, Daniel P. Berrangé wrote: > Given the libvirt XML snippet > > > ... > > ... > > > libvirt QEMU driver will always format > > -device sga > > Libguestfs uses this syntax, so we need to make sure it still works > in future even if

Re: Compatibility between -device sga and -machine graphics=off

2021-09-08 Thread Paolo Bonzini
Oh, that's cool. It must be part of the kvmvapic migration data. Still, there are very likely some rare cases that would break (on any machine), e.g. if migrating while seabios is accessing the list of option roms. Paolo Il mer 8 set 2021, 18:36 Daniel P. Berrangé ha scritto: > On Wed, Sep 08,

Re: Compatibility between -device sga and -machine graphics=off

2021-09-08 Thread Daniel P . Berrangé
On Wed, Sep 08, 2021 at 06:28:01PM +0200, Paolo Bonzini wrote: > On 08/09/21 18:08, Daniel P. Berrangé wrote: > > Despite this difference, I was able migrate from a x86 guest using SGA > > to a guest using graphics=off without errors being reported. So it > > doesn't seem to change the migration

Re: Compatibility between -device sga and -machine graphics=off

2021-09-08 Thread Richard W.M. Jones
Just commenting from the libguestfs POV: We don't care about migration, and: On Wed, Sep 08, 2021 at 05:08:08PM +0100, Daniel P. Berrangé wrote: > On non-x86 emulators I see graphics=off has semantic effects beyond > just controlling whether the firmware prints to the serial or not > though.

Re: Compatibility between -device sga and -machine graphics=off

2021-09-08 Thread Paolo Bonzini
On 08/09/21 18:08, Daniel P. Berrangé wrote: Despite this difference, I was able migrate from a x86 guest using SGA to a guest using graphics=off without errors being reported. So it doesn't seem to change the migration data sections sent on the wire at least. It would probably break with

Compatibility between -device sga and -machine graphics=off

2021-09-08 Thread Daniel P . Berrangé
Given the libvirt XML snippet ... ... libvirt QEMU driver will always format -device sga Libguestfs uses this syntax, so we need to make sure it still works in future even if 'sga' is disabled or removed in a QEMU build in favour of SeaBIOS' built-in support. There are