Re: [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage

2023-04-27 Thread Richard Henderson
On 4/26/23 22:27, Taylor Simpson wrote: We remove the last use of check_for_attrib. However, new uses will be introduced later in this series, so we change it to "static inline". This is insufficient -- clang will warn about unused inline functions within the main C file (as opposed to

RE: [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage

2023-04-26 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Wednesday, April 26, 2023 4:23 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > > Subject: Re: [PATCH 08/21]

Re: [PATCH 08/21] Hexagon (target/hexagon) Clean up pred_written usage

2023-04-26 Thread Richard Henderson
On 4/26/23 01:42, Taylor Simpson wrote: Only endloop instructions will conditionally write to a predicate. When there is an endloop instruction, we preload the values into new_pred_value. The only place pred_written is needed is when HEX_DEBUG is on. We remove the last use of check_for_attrib.