RE: [PATCH v8 29/35] Hexagon (target/hexagon) translation

2021-03-15 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Monday, March 15, 2021 8:32 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain > Subject: Re: [PATCH v8 29/35] He

Re: [PATCH v8 29/35] Hexagon (target/hexagon) translation

2021-03-15 Thread Richard Henderson
On 3/14/21 9:06 PM, Taylor Simpson wrote: Yes, but DISAS_NORETURN still means we've already exited. Just like calling abort() in C means that we won't reach any following return statement. Then I'm missing something because the code emitted here does get executed. You really are missing

RE: [PATCH v8 29/35] Hexagon (target/hexagon) translation

2021-03-14 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Saturday, March 13, 2021 7:44 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain > Subject: Re: [PATCH v8 29/35] He

Re: [PATCH v8 29/35] Hexagon (target/hexagon) translation

2021-03-13 Thread Richard Henderson
On 3/13/21 6:40 PM, Taylor Simpson wrote: -Original Message- From: Richard Henderson Sent: Sunday, February 14, 2021 7:04 PM To: Taylor Simpson ; qemu-devel@nongnu.org Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; a...@rev.ng; Brian Cain Subject: Re: [PATCH v8 29

RE: [PATCH v8 29/35] Hexagon (target/hexagon) translation

2021-03-13 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Sunday, February 14, 2021 7:04 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: phi...@redhat.com; alex.ben...@linaro.org; laur...@vivier.eu; > a...@rev.ng; Brian Cain > Subject: Re: [PATCH v8 29/35] He

Re: [PATCH v8 29/35] Hexagon (target/hexagon) translation

2021-02-14 Thread Richard Henderson
On 2/7/21 9:46 PM, Taylor Simpson wrote: > +static inline void ctx_log_reg_write(DisasContext *ctx, int rnum) Drop the inline markup throughout. > +static int read_packet_words(CPUHexagonState *env, DisasContext *ctx, > + uint32_t words[]) > +{ > +bool found_end =