Re: cxl nvdimm Potential probe ordering issues.

2023-01-23 Thread Gregory Price
On Fri, Jan 20, 2023 at 02:41:05PM -0800, Dan Williams wrote: > > Which mode are you referring? > > The next steps for the kernel enabling relevant to this thread are: > > * ram region discovery (platform firmware or kexec established) > * ram region creation > * pmem region discovery (from

Re: cxl nvdimm Potential probe ordering issues.

2023-01-23 Thread Jonathan Cameron via
On Fri, 20 Jan 2023 14:41:05 -0800 Dan Williams wrote: > Gregory Price wrote: > > On Fri, Jan 20, 2023 at 09:38:13AM -0800, Dan Williams wrote: > > > As it stands currently that dax device and the cxl device are not > > > related since a default dax-device is loaded just based on the presence

Re: cxl nvdimm Potential probe ordering issues.

2023-01-20 Thread Dan Williams
Gregory Price wrote: > On Fri, Jan 20, 2023 at 09:38:13AM -0800, Dan Williams wrote: > > As it stands currently that dax device and the cxl device are not > > related since a default dax-device is loaded just based on the presence > > of an EFI_MEMORY_SP address range in the address map. With the

Re: cxl nvdimm Potential probe ordering issues.

2023-01-20 Thread Gregory Price
On Fri, Jan 20, 2023 at 09:38:13AM -0800, Dan Williams wrote: > As it stands currently that dax device and the cxl device are not > related since a default dax-device is loaded just based on the presence > of an EFI_MEMORY_SP address range in the address map. With the new ram > enabling that

Re: cxl nvdimm Potential probe ordering issues.

2023-01-20 Thread Dan Williams
Gregory Price wrote: > On Thu, Jan 19, 2023 at 03:04:49PM +, Jonathan Cameron wrote: > > Gregory, would you mind checking if > > cxl_nvb is NULL here... > > https://elixir.bootlin.com/linux/v6.2-rc4/source/drivers/cxl/pmem.c#L67 > > (printk before it is used should work). > > > > Might also

Re: cxl nvdimm Potential probe ordering issues.

2023-01-20 Thread Dan Williams
Jonathan Cameron wrote: > On Thu, 19 Jan 2023 15:04:49 + > Jonathan Cameron wrote: > > > On Thu, 19 Jan 2023 12:42:44 + > > Jonathan Cameron via wrote: > > > > > On Wed, 18 Jan 2023 14:31:53 -0500 > > > Gregory Price wrote: > > > > > > > I apparently forgot an intro lol > > > > >

Re: cxl nvdimm Potential probe ordering issues.

2023-01-20 Thread Jonathan Cameron via
On Thu, 19 Jan 2023 23:53:53 -0500 Gregory Price wrote: > On Thu, Jan 19, 2023 at 03:04:49PM +, Jonathan Cameron wrote: > > Gregory, would you mind checking if > > cxl_nvb is NULL here... > > https://elixir.bootlin.com/linux/v6.2-rc4/source/drivers/cxl/pmem.c#L67 > > (printk before it is

Re: cxl nvdimm Potential probe ordering issues.

2023-01-19 Thread Gregory Price
On Thu, Jan 19, 2023 at 04:17:11PM +, Jonathan Cameron wrote: > > Whilst I still have no idea if this is the same problem, I have identified > what goes wrong if there is a module probe ordering issue. > https://elixir.bootlin.com/linux/v6.2-rc4/source/drivers/cxl/core/pmem.c#L306 > >

Re: cxl nvdimm Potential probe ordering issues.

2023-01-19 Thread Gregory Price
On Thu, Jan 19, 2023 at 03:04:49PM +, Jonathan Cameron wrote: > Gregory, would you mind checking if > cxl_nvb is NULL here... > https://elixir.bootlin.com/linux/v6.2-rc4/source/drivers/cxl/pmem.c#L67 > (printk before it is used should work). > > Might also be worth checking cxl_nvd and cxl_ds

Re: cxl nvdimm Potential probe ordering issues.

2023-01-19 Thread Jonathan Cameron via
On Thu, 19 Jan 2023 15:04:49 + Jonathan Cameron wrote: > On Thu, 19 Jan 2023 12:42:44 + > Jonathan Cameron via wrote: > > > On Wed, 18 Jan 2023 14:31:53 -0500 > > Gregory Price wrote: > > > > > I apparently forgot an intro lol > > > > > > I tested the DOE linux branch with the

cxl nvdimm Potential probe ordering issues.

2023-01-19 Thread Jonathan Cameron via
On Thu, 19 Jan 2023 12:42:44 + Jonathan Cameron via wrote: > On Wed, 18 Jan 2023 14:31:53 -0500 > Gregory Price wrote: > > > I apparently forgot an intro lol > > > > I tested the DOE linux branch with the 2023-1-11 QEMU branch with both > > volatile, non-volatile, and "legacy"