Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread pannengyuan
On 2019/12/4 2:54, Eric Blake wrote: > On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: >> It's just a memory leak, but it's a regression in 4.2. >> >> Should we take it into 4.2? > > Sorry, I was on holiday and then jury service, so I missed any chance at > getting this into -rc3. 

Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread Eric Blake
On 12/3/19 12:54 PM, Eric Blake wrote: On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: It's just a memory leak, but it's a regression in 4.2. Should we take it into 4.2? Sorry, I was on holiday and then jury service, so I missed any chance at getting this into -rc3.  The memory

Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread Eric Blake
On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: It's just a memory leak, but it's a regression in 4.2. Should we take it into 4.2? Sorry, I was on holiday and then jury service, so I missed any chance at getting this into -rc3. The memory leak only happens on failure, and you'd

for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread Vladimir Sementsov-Ogievskiy
It's just a memory leak, but it's a regression in 4.2. Should we take it into 4.2? 29.11.2019 10:25, pannengy...@huawei.com wrote: > From: PanNengyuan > > In currently implementation there will be a memory leak when > nbd_client_connect() returns error status. Here is an easy way to >