Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc/spapr_cpu_core: Add a proper check for spapr machine

2017-08-12 Thread Greg Kurz
On Sat, 12 Aug 2017 10:38:10 +0200 Thomas Huth wrote: > QEMU currently crashes when the user tries to add a spapr-cpu-core > on a non-pseries machine: > > $ qemu-system-ppc64 -S -machine ppce500,accel=tcg \ > -device POWER5+_v2.1-spapr-cpu-core >

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Peter Maydell
On 12 August 2017 at 12:04, Samuel Thibault wrote: > Peter Maydell, on sam. 12 août 2017 11:53:20 +0100, wrote: >> The utility of the warning is that it means you get told >> about stuff that might break on other architectures. > > Sure, I understand that. But here all

Re: [Qemu-devel] [PATCH v1 3/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-12 Thread Edgar E. Iglesias
On Fri, Aug 11, 2017 at 03:17:41PM -0700, Alistair Francis wrote: > When we perform the atomic_cmpxchg operation we want to perform the > operation on a pair of 32-bit registers. Previously we were just passing > the register size in which was set to MO_32. This would result in the > high register

Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic

2017-08-12 Thread Portia Stephens
> -Original Message- > From: alistai...@gmail.com [mailto:alistai...@gmail.com] On Behalf Of > Alistair Francis > Sent: Friday, August 11, 2017 4:23 PM > To: Alistair Francis ; Portia Stephens > > Cc: qemu-devel@nongnu.org Developers

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Samuel Thibault
Peter Maydell, on sam. 12 août 2017 12:18:16 +0100, wrote: > On 12 August 2017 at 12:04, Samuel Thibault wrote: > > Peter Maydell, on sam. 12 août 2017 11:53:20 +0100, wrote: > >> The utility of the warning is that it means you get told > >> about stuff that might break

Re: [Qemu-devel] [PATCH v1 1/3] target/arm: Update the memops for exclusive load

2017-08-12 Thread Edgar E. Iglesias
On Fri, Aug 11, 2017 at 03:17:36PM -0700, Alistair Francis wrote: > Acording to the ARM ARM exclusive loads require the same allignment as > exclusive stores. Let's update the memops used for the load to match > that of the store. This adds the alignment requirement to the memops. > >

[Qemu-devel] [PATCH] hw/ppc/spapr_cpu_core: Add a proper check for spapr machine

2017-08-12 Thread Thomas Huth
QEMU currently crashes when the user tries to add a spapr-cpu-core on a non-pseries machine: $ qemu-system-ppc64 -S -machine ppce500,accel=tcg \ -device POWER5+_v2.1-spapr-cpu-core hw/ppc/spapr_cpu_core.c:178:spapr_cpu_core_realize_child: Object 0x55cee1f55160 is not an

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Samuel Thibault
Peter Maydell, on sam. 12 août 2017 11:53:20 +0100, wrote: > The utility of the warning is that it means you get told > about stuff that might break on other architectures. Sure, I understand that. But here all fields are aligned on their size inside the packed structure. So there can't be

Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic

2017-08-12 Thread Peter Maydell
On 11 August 2017 at 23:17, Alistair Francis wrote: > I found some issues with the way exclusive store was working. This patch > series seems to fix the test cases that were failing for me. > > The first patch is just a simple adjustment. > > The third patch fixes the

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Peter Maydell
On 11 August 2017 at 22:58, Samuel Thibault wrote: > Hello, > > Programmingkid, on jeu. 10 août 2017 16:44:19 -0400, wrote: >> While compiling I saw these error messages: >> >> slirp/ip6_icmp.c:79:32: warning: taking address of packed member 'ip_src' of >> class or >>

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Eric Blake
On 08/12/2017 06:29 AM, Samuel Thibault wrote: >> >> Alignment is architecture-dependent, and the compiler >> can't know the alignment requirements for every >> architecture. > > Sure. True, but we can at least guess alignments that don't require padding, and then be told by the compiler if our

Re: [Qemu-devel] [PATCH] hw/ppc/spapr_cpu_core: Add a proper check for spapr machine

2017-08-12 Thread Eduardo Habkost
On Sat, Aug 12, 2017 at 10:38:10AM +0200, Thomas Huth wrote: > QEMU currently crashes when the user tries to add a spapr-cpu-core > on a non-pseries machine: > > $ qemu-system-ppc64 -S -machine ppce500,accel=tcg \ > -device POWER5+_v2.1-spapr-cpu-core >

Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic

2017-08-12 Thread Alistair Francis
On Sat, Aug 12, 2017 at 4:42 AM, Edgar E. Iglesias wrote: > On Sat, Aug 12, 2017 at 11:24:30AM +0100, Peter Maydell wrote: >> On 11 August 2017 at 23:17, Alistair Francis >> wrote: >> > I found some issues with the way exclusive store was

Re: [Qemu-devel] [PATCH v1 3/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-12 Thread Richard Henderson
On 08/11/2017 03:17 PM, Alistair Francis wrote: > When we perform the atomic_cmpxchg operation we want to perform the > operation on a pair of 32-bit registers. Previously we were just passing > the register size in which was set to MO_32. This would result in the > high register to be ignored. To

Re: [Qemu-devel] [PATCH v1 0/3] Fixup exclusive store logic

2017-08-12 Thread Edgar E. Iglesias
On Sat, Aug 12, 2017 at 11:24:30AM +0100, Peter Maydell wrote: > On 11 August 2017 at 23:17, Alistair Francis > wrote: > > I found some issues with the way exclusive store was working. This patch > > series seems to fix the test cases that were failing for me. > > > >

Re: [Qemu-devel] [PATCH v1 2/3] tcg/tcg-op: Expose the tcg_gen_ext_i* functions

2017-08-12 Thread Edgar E. Iglesias
On Fri, Aug 11, 2017 at 03:17:38PM -0700, Alistair Francis wrote: > Expose the tcg_gen_ext_i32() and tcg_gen_ext_i64() functions. > > Signed-off-by: Alistair Francis > Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Samuel Thibault
Eric Blake, on sam. 12 août 2017 06:41:30 -0500, wrote: > Here's an idea: Instead of using struct ip6 { ... } QEMU_PACKED, use > > struct ip6 { > ... > }; > QEMU_BUG_ON(sizeof(struct ip6) != 32); That's an interesting way indeed. I however wonder whether there may be not-so-uncommon systems

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Eric Blake
On 08/12/2017 06:47 AM, Samuel Thibault wrote: > Eric Blake, on sam. 12 août 2017 06:41:30 -0500, wrote: >> Here's an idea: Instead of using struct ip6 { ... } QEMU_PACKED, use >> >> struct ip6 { >> ... >> }; >> QEMU_BUG_ON(sizeof(struct ip6) != 32); > > That's an interesting way indeed. I

Re: [Qemu-devel] [PATCH 00/15] Convert over to use keycodemapdb

2017-08-12 Thread Programmingkid
> The keycodemap project[1] provides a database mapping between > many different keysym/keycode/scancode sets, along with a > tool to generate mapping/lookup tables in various programming > languages. It is already used by GTK-VNC, SPICE-GTK and > libvirt. > > This series enables its use in QEMU,

Re: [Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

2017-08-12 Thread Richard Henderson
On 08/12/2017 09:29 AM, Alistair Francis wrote: > Now we aren't ever checking cpu_exclusive_high. Is it even worth having? We are checking cpu_exclusive_high for 64-bit STXP. See paired_cmpxchg64_{l,b}e in target/arm/helper-a64.c. r~

[Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

2017-08-12 Thread Richard Henderson
SetExclusiveMonitors in the pseudocode is on the address + width, and says nothing about the manner of the load. Therefore ldxpw0, w1, [x2] vs ldxrx0, [x2] must record the same metadata so that either may pair with stxpw3, w0, w1, [x2] vs stxrw3,

Re: [Qemu-devel] SLIRP warning messages displayed while compiling

2017-08-12 Thread Philippe Mathieu-Daudé
Hi Eric, On 08/12/2017 08:41 AM, Eric Blake wrote: Here's an idea: Instead of using struct ip6 { ... } QEMU_PACKED, use struct ip6 { ... }; QEMU_BUG_ON(sizeof(struct ip6) != 32); so that the compiler explicitly chokes if it introduced any padding, and then we know all our accesses are

[Qemu-devel] [PATCH] target/arm: Avoid an extra temporary for store_exclusive

2017-08-12 Thread Richard Henderson
Instead of copying addr to a local temp, reuse the value (which we have just compared as equal) already saved in cpu_exclusive_addr. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 26 +- 1 file changed, 9 insertions(+), 17

Re: [Qemu-devel] [PATCH] target/arm: Correct load/store exclusive pairing and alignment

2017-08-12 Thread Alistair Francis
On Sat, Aug 12, 2017 at 8:41 AM, Richard Henderson wrote: > SetExclusiveMonitors in the pseudocode is on the address + width, > and says nothing about the manner of the load. Therefore > > ldxpw0, w1, [x2] > vs > ldxrx0, [x2] > > must record the same

[Qemu-devel] [Bug 1067517] Re: qemu dosn't save snapshots with the 'commit' command

2017-08-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1067517 Title: qemu

[Qemu-devel] [Bug 1307281] Re: qemu crash with assertion in usb_packet_complete_one

2017-08-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307281 Title: qemu crash

[Qemu-devel] [Bug 1038070] Re: > qemu-kvm-1.1.1-r1 - USB activkey doesn't work anymore

2017-08-12 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1038070 Title: >

[Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-12 Thread Matt Parker
This updates the current MemoryRegionOps for the bar 1 memory region from using the old_mmio accessors to the .read and .write accessors. Signed-off-by: Matt Parker --- hw/net/rtl8139.c | 60 +++- 1 file changed, 16

[Qemu-devel] [PATCH] net: rtl8139: do not use old_mmio accesses

2017-08-12 Thread Matt Parker
This updates the current MemoryRegionOps for the bar 1 memory region from using the old_mmio accessors to the .read and .write accessors. Signed-off-by: Matt Parker --- hw/net/rtl8139.c | 60 +++- 1 file changed, 16