[Qemu-devel] [PATCH v2 2/2] target-arm: source code formatting fix

2010-01-25 Thread juha . riihimaki
From: Juha Riihimäki source code alignment through the disas_neon_data_insn() function is inconsistent; this patch aligns the formatting. Signed-off-by: Juha Riihimäki --- target-arm/translate.c | 697 +++- 1 files changed, 390 insertions(+), 307 de

[Qemu-devel] [PATCH v2 1/2] target-arm: neon emulation enhancements

2010-01-25 Thread juha . riihimaki
From: Juha Riihimäki This patch improves the detection of undefined NEON data instruction encodings, fixes bugs in some of the instruction decodings and adds an implementation for 64bit wide vsli and vsri instructions. Signed-off-by: Juha Riihimäki --- target-arm/translate.c | 450 +++

[Qemu-devel] [PATCH v2 0/2] *** SUBJECT HERE ***

2010-01-25 Thread juha . riihimaki
From: Juha Riihimäki Revised version of the ARM NEON instruction decoding fix patch. The patch has now been split in two, first patch introduces the functional changes and the second patch aligns the source code formatting inside the disas_neon_data_insn() function. The functional patch has also

Re: [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error

2010-01-25 Thread Laurent Desnogues
On Wed, Jan 20, 2010 at 9:14 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- >  linux-user/mmap.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/linux-user/mmap.c b/linux-user/mmap.c > index c1c7e48..25fc0b2 100644 > --- a/linux-user/mmap.c > +++ b/li

Re: [Qemu-devel] [PATCH v2 4/4] Try not to exceed max downtime on stage3

2010-01-25 Thread Liran Schour
Pierre Riteau wrote on 21/01/2010 20:03:32: > On 21 janv. 2010, at 16:24, Liran Schour wrote: > > > Move to stage3 only when remaining work can be done below max downtime. > > > > Changes from v1: remove max iterations. Try to infer storage > performance and by that calculate remaining work. ..

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-25 Thread Dor Laor
On 01/21/2010 05:05 PM, Anthony Liguori wrote: On 01/20/2010 07:18 PM, john cooper wrote: Chris Wright wrote: * Daniel P. Berrange (berra...@redhat.com) wrote: To be honest all possible naming schemes for '-cpu' are just as unfriendly as each other. The only user friendly option is '-cpu host'

Re: [Qemu-devel] [PATCH v2 4/4] Try not to exceed max downtime on stage3

2010-01-25 Thread Pierre Riteau
On 25 janv. 2010, at 09:57, Liran Schour wrote: > > > Pierre Riteau wrote on 21/01/2010 20:03:32: > >> On 21 janv. 2010, at 16:24, Liran Schour wrote: >> >>> Move to stage3 only when remaining work can be done below max downtime. >>> >>> Changes from v1: remove max iterations. Try to infer s

Re: [Qemu-devel] qemu-0.12.2 compiling error (on ppc32/ppc64): kvm.c:50: error: 'struct kvm_sregs' has no member named 'pvr'

2010-01-25 Thread Alexander Graf
On 24.01.2010, at 22:16, acrux wrote: > On a powerpc32 (Apple G4) system: > gnu/linux distribution: CRUX PPC 2.6 (32bit) > toolchain: binutils-2.20, gcc-4.4.3, glibc-2.11 > kernel: linux-2.6.32.5 > > [...] > ARmips64el-softmmu/libqemu.a > LINK mips64el-softmmu/qemu-system-mips64el > GEN

Re: [Qemu-devel] [PATCH v2 0/4] Reduce down time during migration without shared storage

2010-01-25 Thread Pierre Riteau
On 21 janv. 2010, at 16:24, Liran Schour wrote: > This series of patches reduce the down time of the guest during a migration > without shared storage. It does that by start transfer dirty blocks in the > iterative phase. In the current code transferring of dirty blocks begins only > during the

[Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Michael S. Tsirkin
On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: > Replace %lld occurrences by PRId64. This is wrong. long long values should be printed with %lld. size_t - with %zd. PRId64 is for int64_t. > Incidentally, this fixes use of curl on Windows, and prevents an assert > when closing

[Qemu-devel] Re: qemu-0.12.2 compiling error (on ppc32/ppc64): kvm.c:50: error: 'struct kvm_sregs' has no member named 'pvr'

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 10:25:30AM +0100, Alexander Graf wrote: > > On 24.01.2010, at 22:16, acrux wrote: > > > On a powerpc32 (Apple G4) system: > > gnu/linux distribution: CRUX PPC 2.6 (32bit) > > toolchain: binutils-2.20, gcc-4.4.3, glibc-2.11 > > kernel: linux-2.6.32.5 > > > > [...] > > AR

[Qemu-devel] Re: qemu-0.12.2 compiling error (on ppc32/ppc64): kvm.c:50: error: 'struct kvm_sregs' has no member named 'pvr'

2010-01-25 Thread Alexander Graf
On 25.01.2010, at 11:28, Michael S. Tsirkin wrote: > On Mon, Jan 25, 2010 at 10:25:30AM +0100, Alexander Graf wrote: >> >> On 24.01.2010, at 22:16, acrux wrote: >> >>> On a powerpc32 (Apple G4) system: >>> gnu/linux distribution: CRUX PPC 2.6 (32bit) >>> toolchain: binutils-2.20, gcc-4.4.3, gli

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-25 Thread Jamie Lokier
Dor Laor wrote: > x86 qemu64 > x86 phenom > x86 core2duo > x86kvm64 > x86 qemu32 > x86 coreduo > x86 486 > x86 pentium > x86 pentium2 > x86 pentium3 > x86 athlon > x86 n270 I wond

Re: [Qemu-devel] [PATCH 0/4] Introduce global config (v3)

2010-01-25 Thread Daniel P. Berrange
On Sun, Jan 24, 2010 at 04:10:35PM +0100, Paolo Bonzini wrote: > On 01/24/2010 04:04 PM, Avi Kivity wrote: > >On 01/24/2010 04:22 PM, Anthony Liguori wrote: > >>This series introduces global config files stored in /etc/qemu. There > >>is both > >>a common config (qemu.conf) and a per-target config

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Sun, 24 Jan 2010 18:35:14 + Jamie Lokier wrote: > Anthony Liguori wrote: > > >I'd like to be able to connect and be sure not to receive any async > > >messages, from simple scripts with simple output parsing. > > > > You can't have simple output parsing with QMP. You need a full JSON >

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Sun, 24 Jan 2010 08:19:53 -0600 Anthony Liguori wrote: > On 01/24/2010 08:17 AM, Avi Kivity wrote: > > On 01/24/2010 04:04 PM, Anthony Liguori wrote: > >>> I agree with that, but we can look at async messages as a baseline > >>> protocol capability (thus no negotiation required), and the new

[Qemu-devel] [PATCH] vnc_refresh: calling vnc_update_client might free vs

2010-01-25 Thread Stefano Stabellini
Hi all, this patch fixes another bug in vnc_refresh: calling vnc_update_client might cause vs to be free()ed, in this case we cannot access vs->next right after to examine the next item on the list. Signed-off-by: Stefano Stabellini --- diff --git a/vnc.c b/vnc.c index cc2a26e..92facde 100644 -

[Qemu-devel] Re: [RFC] New API for asynchronous monitor commands

2010-01-25 Thread Luiz Capitulino
On Fri, 22 Jan 2010 13:03:51 -0600 Adam Litke wrote: > Qemu has a number of commands that can operate asynchronously (savevm, > migrate, > etc) and it will be getting more. For these commands, the user monitor needs > to be suspended, but QMP monitors could continue to to accept other commands.

[Qemu-devel] Re: [RFC] New API for asynchronous monitor commands

2010-01-25 Thread Luiz Capitulino
On Fri, 22 Jan 2010 17:17:27 -0600 Anthony Liguori wrote: > On 01/22/2010 01:03 PM, Adam Litke wrote: > > Qemu has a number of commands that can operate asynchronously (savevm, > > migrate, > > etc) and it will be getting more. For these commands, the user monitor > > needs > > to be suspended

Re: [Qemu-devel] [RFC] New API for asynchronous monitor commands

2010-01-25 Thread Luiz Capitulino
On Sun, 24 Jan 2010 08:01:28 -0600 Anthony Liguori wrote: > On 01/24/2010 04:59 AM, Avi Kivity wrote: > > On 01/22/2010 09:03 PM, Adam Litke wrote: > >> > >> +static void do_async_cmd_handler(Monitor *mon, const mon_cmd_t *cmd, > >> + const QDict *params) > >> +{ >

[Qemu-devel] Re: [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Sun, 24 Jan 2010 12:36:39 +0200 Avi Kivity wrote: > On 01/21/2010 11:09 PM, Luiz Capitulino wrote: > > This commit disables asynchronous messages by default and > > introduces two new QMP commands: async_msg_enable and > > async_msg_disable. > > > > Each QMP Monitor has its own set of asynchro

[Qemu-devel] [PATCH v3 0/8] Convert migrate_set_speed, migrate_set_downtime to QObject

2010-01-25 Thread Markus Armbruster
These conversions take a few extra steps, because do_migrate_set_speed() and do_migrate_set_downtime() interpret their string argument as floating-point number + optional unit suffix. This is quite inappropriate for QMP. v3: reject NaN and infinity in monitor (we shouldn't get them over QMP,

[Qemu-devel] [PATCH v3 2/8] QDict: New qdict_get_double()

2010-01-25 Thread Markus Armbruster
Helper function just like qdict_get_int(), just for QFloat/double. Signed-off-by: Markus Armbruster --- qdict.c | 24 qdict.h |1 + 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/qdict.c b/qdict.c index ba8eef0..32119cf 100644 --- a/qdict.c +++ b/q

[Qemu-devel] [PATCH v3 1/8] monitor: Document argument type 'M'

2010-01-25 Thread Markus Armbruster
Was forgotten in commit b6e098d7. Signed-off-by: Markus Armbruster --- monitor.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index ae3300b..a56d480 100644 --- a/monitor.c +++ b/monitor.c @@ -68,6 +68,8 @@ * 's' string (accept optiona

[Qemu-devel] [PATCH v3 5/8] monitor: convert do_migrate_set_speed() to QObject

2010-01-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- migration.c |2 +- migration.h |2 +- qemu-monitor.hx |3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/migration.c b/migration.c index 6abdc65..cd8d9e6 100644 --- a/migration.c +++ b/migration.c @@ -106,7 +106,7 @@ vo

[Qemu-devel] [PATCH v3 7/8] monitor: Use argument type 'T' for migrate_set_downtime

2010-01-25 Thread Markus Armbruster
Before, it used type 's', which strips quotes and interprets escapes, and is quite inappropriate for QMP. Negative arguments are no flushed to zero. Before, they were cast to uint32_t, which wrecked the sign. Ridiculously large arguments including infinities are now rejected. Before, they were i

[Qemu-devel] [PATCH v3 4/8] monitor: Use argument type 'b' for migrate_set_speed

2010-01-25 Thread Markus Armbruster
Before, it used type 's', which strips quotes and interprets escapes, and is quite inappropriate for QMP. Negative arguments are no flushed to zero. Before, they were cast to uint32_t, which wrecked the sign. Ridiculously large arguments including infinities are now rejected. Before, they were i

[Qemu-devel] [PATCH v3 6/8] monitor: New argument type 'T'

2010-01-25 Thread Markus Armbruster
This is a double value with optional suffixes ms, us, ns. We'll need this to get migrate_set_downtime() QMP-ready. Signed-off-by: Markus Armbruster --- monitor.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 6325404..a9d0c8

[Qemu-devel] [PATCH v3 8/8] monitor: convert do_migrate_set_downtime() to QObject

2010-01-25 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- migration.c |3 ++- migration.h |3 ++- qemu-monitor.hx |3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/migration.c b/migration.c index 7551953..5b28e42 100644 --- a/migration.c +++ b/migration.c @@ -132,7 +132,8 @@

[Qemu-devel] [PATCH v3 3/8] monitor: New argument type 'b'

2010-01-25 Thread Markus Armbruster
This is a double value with optional suffixes G, g, M, m, K, k. We'll need this to get migrate_set_speed() QMP-ready. Signed-off-by: Markus Armbruster --- monitor.c | 64 + 1 files changed, 64 insertions(+), 0 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 0/4] Introduce global config (v3)

2010-01-25 Thread Anthony Liguori
On 01/25/2010 05:31 AM, Daniel P. Berrange wrote: On Sun, Jan 24, 2010 at 04:10:35PM +0100, Paolo Bonzini wrote: On 01/24/2010 04:04 PM, Avi Kivity wrote: On 01/24/2010 04:22 PM, Anthony Liguori wrote: This series introduces global config files stored in /etc/qemu. There is b

[Qemu-devel] Re: [RFC] New API for asynchronous monitor commands

2010-01-25 Thread Adam Litke
On Mon, 2010-01-25 at 11:08 -0200, Luiz Capitulino wrote: > > @@ -85,11 +91,19 @@ typedef struct mon_cmd_t { > > union { > > void (*info)(Monitor *mon); > > void (*info_new)(Monitor *mon, QObject **ret_data); > > +int (*info_async)(Monitor *mon, QMPCompletion *cb, vo

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 12:09:06 +0200 "Michael S. Tsirkin" wrote: > On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: > > Replace %lld occurrences by PRId64. > > diff --git a/json-lexer.c b/json-lexer.c > > index 53697c5..9d64920 100644 > > --- a/json-lexer.c > > +++ b/json-lexer.c >

[Qemu-devel] Re: [RFC] New API for asynchronous monitor commands

2010-01-25 Thread Anthony Liguori
On 01/25/2010 07:08 AM, Luiz Capitulino wrote: On Fri, 22 Jan 2010 13:03:51 -0600 Adam Litke wrote: I like the patch, but I don't think it's a good idea to use this in synchronous commands as they will have to call QMPCompletion (not to mention unneeded suspend/resume calls). I think th

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Sun, 24 Jan 2010 18:35:14 + > Jamie Lokier wrote: > >> Anthony Liguori wrote: >> > >I'd like to be able to connect and be sure not to receive any async >> > >messages, from simple scripts with simple output parsing. >> > >> > You can't have simple output parsing

Re: [Qemu-devel] [PATCH v3 0/8] Convert migrate_set_speed, migrate_set_downtime to QObject

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 14:23:00 +0100 Markus Armbruster wrote: > These conversions take a few extra steps, because > do_migrate_set_speed() and do_migrate_set_downtime() interpret their > string argument as floating-point number + optional unit suffix. This > is quite inappropriate for QMP. Looks

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-25 Thread Anthony Liguori
On 01/25/2010 03:08 AM, Dor Laor wrote: qemu-config.[ch], taking a new command line that parses the argument via QemuOpts, then passing the parsed options to a target-specific function that then builds the table of supported cpus. It should just be a matter of adding qemu_cpudefs_opts to Isn't

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 15:15:59 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Sun, 24 Jan 2010 18:35:14 + > > Jamie Lokier wrote: > > > >> Anthony Liguori wrote: > >> > >I'd like to be able to connect and be sure not to receive any async > >> > >messages, from simple scrip

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 22 Jan 2010 12:05:19 -0600 > Anthony Liguori wrote: > >> On 01/21/2010 03:09 PM, Luiz Capitulino wrote: >> > This commit disables asynchronous messages by default and >> > introduces two new QMP commands: async_msg_enable and >> > async_msg_disable. >> > >> > Ea

[Qemu-devel] [PATCHv2-repost 0/3] qemu: memory notifiers

2010-01-25 Thread Michael S. Tsirkin
This patchset against qemu upstream adds notifiers hook which lets backends get notified on memory changes, and converts kvm to use it. It survived light testing. Michael S. Tsirkin (3): qemu: memory notifiers kvm: move kvm_set_phys_mem around kvm: move kvm to use memory notifiers cpu-co

[Qemu-devel] [PATCHv2-repost 1/3] qemu: memory notifiers

2010-01-25 Thread Michael S. Tsirkin
This adds notifiers for phys memory changes: a set of callbacks that vhost can register and update kernel accordingly. Down the road, kvm code can be switched to use these as well, instead of calling kvm code directly from exec.c as is done now. Signed-off-by: Michael S. Tsirkin Acked-by: Avi Ki

[Qemu-devel] [PATCHv2-repost 2/3] kvm: move kvm_set_phys_mem around

2010-01-25 Thread Michael S. Tsirkin
move kvm_set_phys_mem so that it will be later available earlier in the file. needed for next patch using memory notifiers. Signed-off-by: Michael S. Tsirkin Acked-by: Avi Kivity --- kvm-all.c | 276 ++-- 1 files changed, 138 insertions(

[Qemu-devel] [PATCHv2-repost 3/3] kvm: move kvm to use memory notifiers

2010-01-25 Thread Michael S. Tsirkin
remove direct kvm calls from exec.c, make kvm use memory notifiers framework instead. Signed-off-by: Michael S. Tsirkin Acked-by: Avi Kivity --- exec.c| 17 + kvm-all.c | 40 ++-- kvm.h |8 3 files changed, 35 inserti

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Avi Kivity
On 01/25/2010 04:29 PM, Markus Armbruster wrote: I agree with Anthony that async message masking doesn't really affect the protocol proper. We could pretend it does so we can let protocol capability negotiation (which we need anyway) cover it. But I'm certainly fine with keeping it separate.

Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support

2010-01-25 Thread Markus Armbruster
Anthony Liguori writes: > On 01/21/2010 03:09 PM, Luiz Capitulino wrote: >> """ >> {"QMP": {"capabilities": ["async messages"]}} >> >> { "execute": "query-qmp-mode" } >> {"return": {"mode": "handshake"}} >> >> { "execute": "change", "arguments": { "device": "vnc", "target": "password", >> "arg":

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 25 Jan 2010 12:09:06 +0200 > "Michael S. Tsirkin" wrote: [...] >> Finally, >> don't we want unsigned values in protocol? > > JSON doesn't support them. Uh, where does the RFC say that?

Re: [Qemu-devel] Re: [PATCH 1/3] Support --sysconfdir in configure to specify path to configuration files (v3)

2010-01-25 Thread Avi Kivity
On 01/24/2010 05:23 PM, Anthony Liguori wrote: On 01/24/2010 08:45 AM, Paolo Bonzini wrote: On 01/24/2010 03:22 PM, Anthony Liguori wrote: The default value is ${prefix}/etc/qemu. --sysconfdir can be used to override the default to an absolute path. The expectation is that when installed to

[Qemu-devel] Re: [RFC] New API for asynchronous monitor commands

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 08:15:53 -0600 Anthony Liguori wrote: > On 01/25/2010 07:08 AM, Luiz Capitulino wrote: > > On Fri, 22 Jan 2010 13:03:51 -0600 > > Adam Litke wrote: > > > > I like the patch, but I don't think it's a good idea to use this in > > synchronous commands as they will have to call

[Qemu-devel] [PATCH] json: escape u0000 .. u001F when outputting json

2010-01-25 Thread Anthony Liguori
Markus Armbruster pointed out: JSON requires control characters in strings to be escaped. RFC 4627 section 2.5: A string begins and ends with quotation marks. All Unicode characters may be placed within the quotation marks except for the characters that must be escaped: quotation mark,

[Qemu-devel] Re: [RFC] New API for asynchronous monitor commands

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 08:00:45 -0600 Adam Litke wrote: > On Mon, 2010-01-25 at 11:08 -0200, Luiz Capitulino wrote: > > > @@ -85,11 +91,19 @@ typedef struct mon_cmd_t { > > > union { > > > void (*info)(Monitor *mon); > > > void (*info_new)(Monitor *mon, QObject **ret_data); >

Re: [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 16:33:02 +0200 Avi Kivity wrote: > On 01/25/2010 04:29 PM, Markus Armbruster wrote: > > > > I agree with Anthony that async message masking doesn't really affect > > the protocol proper. We could pretend it does so we can let protocol > > capability negotiation (which we need

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Luiz Capitulino
On Mon, 25 Jan 2010 15:35:53 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Mon, 25 Jan 2010 12:09:06 +0200 > > "Michael S. Tsirkin" wrote: > [...] > >> Finally, > >> don't we want unsigned values in protocol? >

Re: [Qemu-devel] [PATCH] linux-user: Align mmap memory to the target page size.

2010-01-25 Thread Riku Voipio
On Fri, Jan 15, 2010 at 07:43:48AM -0800, Richard Henderson wrote: >> This patch uses a more complex search algorithm that takes the result >> of the previous allocation into account. We normally search upward, >> but notice 2 consecutive results and start searching downward instead. > I've faile

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 01:27:19PM -0200, Luiz Capitulino wrote: > On Mon, 25 Jan 2010 15:35:53 +0100 > Markus Armbruster wrote: > > > Luiz Capitulino writes: > > > > > On Mon, 25 Jan 2010 12:09:06 +0200 > > > "Michael S. Tsirkin" wrote: > > [...] > > >>

[Qemu-devel] Re: [PATCH] json: escape u0000 .. u001F when outputting json

2010-01-25 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster pointed out: > > JSON requires control characters in strings to be escaped. RFC 4627 > section 2.5: > >A string begins and ends with quotation marks. All Unicode >characters may be placed within the quotation marks except for the >characte

Re: [Qemu-devel] [PATCH] linux-user: Align mmap memory to the target page size.

2010-01-25 Thread Richard Henderson
On 01/25/2010 05:35 AM, Riku Voipio wrote: On Fri, Jan 15, 2010 at 07:43:48AM -0800, Richard Henderson wrote: This patch uses a more complex search algorithm that takes the result of the previous allocation into account. We normally search upward, but notice 2 consecutive results and start sear

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
On 25.01.2010, at 17:52, Jes Sorensen wrote: > Hi, > > This is the QEMU patch for providing the e820-reserve space through > qemu-cfg. Howdy. Congratulations to the new mail address - looks neat ;-). Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
Am 25.01.2010 um 18:13 schrieb Jes Sorensen : On 01/25/10 17:58, Alexander Graf wrote: Howdy. Congratulations to the new mail address - looks neat ;-). :-) Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure You

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: >> Replace %lld occurrences by PRId64. > > This is wrong. > long long values should be printed with %lld. > size_t - with %zd. PRId64 is for int64_t. > size_t => %zu, ssize_t => %zd might be better. An

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: > >> Replace %lld occurrences by PRId64. > > > > This is wrong. > > long long values should be printed with %lld. > > size_t - with %zd. P

[Qemu-devel] [PATCH] New API for asynchronous monitor commands (V2)

2010-01-25 Thread Adam Litke
Changes since V1: - Miscellaneous code cleanups (Thanks Luiz) Qemu has a number of commands that can operate asynchronously (savevm, migrate, etc) and it will be getting more. For these commands, the user monitor needs to be suspended, but QMP monitors could continue to to accept other commands.

[Qemu-devel] Re: [PATCH-RFC 01/13] virtio: export virtqueue structure

2010-01-25 Thread Michael S. Tsirkin
On Tue, Jan 12, 2010 at 04:32:44PM -0600, Anthony Liguori wrote: > On 01/11/2010 11:16 AM, Michael S. Tsirkin wrote: >> vhost needs physical addresses for >> ring so expose that structure. >> >> Signed-off-by: Michael S. Tsirkin >> > > I think accessor functions might make more sense. > > Regar

[Qemu-devel] Re: [PATCH-RFC 02/13] kvm: add API to set ioeventfd

2010-01-25 Thread Michael S. Tsirkin
On Tue, Jan 12, 2010 at 04:35:17PM -0600, Anthony Liguori wrote: > On 01/11/2010 11:17 AM, Michael S. Tsirkin wrote: >> Signed-off-by: Michael S. Tsirkin >> --- >> kvm-all.c | 24 >> kvm.h |3 +++ >> 2 files changed, 27 insertions(+), 0 deletions(-) >> >> diff

[Qemu-devel] Re: [PATCH-RFC 01/13] virtio: export virtqueue structure

2010-01-25 Thread Anthony Liguori
On 01/25/2010 01:10 PM, Michael S. Tsirkin wrote: On Tue, Jan 12, 2010 at 04:32:44PM -0600, Anthony Liguori wrote: On 01/11/2010 11:16 AM, Michael S. Tsirkin wrote: vhost needs physical addresses for ring so expose that structure. Signed-off-by: Michael S. Tsirkin I think a

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Stefan Weil
Michael S. Tsirkin schrieb: > On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote: >> Michael S. Tsirkin schrieb: >>> On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: Replace %lld occurrences by PRId64. >>> This is wrong. >>> long long values should be printed with %ll

[Qemu-devel] Re: [PATCH-RFC 02/13] kvm: add API to set ioeventfd

2010-01-25 Thread Anthony Liguori
On 01/25/2010 01:20 PM, Michael S. Tsirkin wrote: On Tue, Jan 12, 2010 at 04:35:17PM -0600, Anthony Liguori wrote: On 01/11/2010 11:17 AM, Michael S. Tsirkin wrote: Signed-off-by: Michael S. Tsirkin --- kvm-all.c | 24 kvm.h |3 +++ 2 files ch

[Qemu-devel] Re: [PATCH-RFC 02/13] kvm: add API to set ioeventfd

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 01:28:49PM -0600, Anthony Liguori wrote: > On 01/25/2010 01:20 PM, Michael S. Tsirkin wrote: >> On Tue, Jan 12, 2010 at 04:35:17PM -0600, Anthony Liguori wrote: >> >>> On 01/11/2010 11:17 AM, Michael S. Tsirkin wrote: >>> Signed-off-by: Michael S. Tsirkin

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 08:23:22PM +0100, Stefan Weil wrote: > Michael S. Tsirkin schrieb: > > On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote: > >> Michael S. Tsirkin schrieb: > >>> On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: > Replace %lld occurrences by PRI

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 09:32:05PM +0200, Michael S. Tsirkin wrote: > On Mon, Jan 25, 2010 at 08:23:22PM +0100, Stefan Weil wrote: > > Michael S. Tsirkin schrieb: > > > On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote: > > >> Michael S. Tsirkin schrieb: > > >>> On Sun, Jan 24, 2010 at 09

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Stefan Weil
Stefan Weil schrieb: > Michael S. Tsirkin schrieb: >> On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: >>> Replace %lld occurrences by PRId64. >> This is wrong. >> long long values should be printed with %lld. >> size_t - with %zd. PRId64 is for int64_t. >> > > size_t => %zu, ssize

[Qemu-devel] Re: [PATCH-RFC 02/13] kvm: add API to set ioeventfd

2010-01-25 Thread Anthony Liguori
On 01/25/2010 01:28 PM, Michael S. Tsirkin wrote: It is called in the binding. Pls take a look. The function does not reference a specific CPU: it binds an eventfd descriptor to a specific address/data pair for all CPUs. This problem is really a symptom of a bigger problem. Let me respond

Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld

2010-01-25 Thread Daniel P. Berrange
On Mon, Jan 25, 2010 at 07:47:56PM +0200, Michael S. Tsirkin wrote: > On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote: > > Michael S. Tsirkin schrieb: > > > On Sun, Jan 24, 2010 at 09:23:41PM +, Herve Poussineau wrote: > > >> Replace %lld occurrences by PRId64. > > > > > > This is w

[Qemu-devel] Re: [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-25 Thread Anthony Liguori
On 01/11/2010 11:23 AM, Michael S. Tsirkin wrote: start/stop backend on driver start/stop Signed-off-by: Michael S. Tsirkin --- hw/virtio-net.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c in

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
On 25.01.2010, at 18:46, Jes Sorensen wrote: > On 01/25/10 18:28, Alexander Graf wrote: That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Anthony Liguori
On 01/25/2010 02:04 PM, Alexander Graf wrote: On 25.01.2010, at 18:46, Jes Sorensen wrote: On 01/25/10 18:28, Alexander Graf wrote: That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way

[Qemu-devel] Re: [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 01:58:08PM -0600, Anthony Liguori wrote: > On 01/11/2010 11:23 AM, Michael S. Tsirkin wrote: >> start/stop backend on driver start/stop >> >> Signed-off-by: Michael S. Tsirkin >> --- >> hw/virtio-net.c | 40 >> 1 files changed, 4

[Qemu-devel] Re: [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-25 Thread Anthony Liguori
On 01/25/2010 02:27 PM, Michael S. Tsirkin wrote: On Mon, Jan 25, 2010 at 01:58:08PM -0600, Anthony Liguori wrote: On 01/11/2010 11:23 AM, Michael S. Tsirkin wrote: start/stop backend on driver start/stop Signed-off-by: Michael S. Tsirkin --- hw/virtio-net.c | 40 +++

[Qemu-devel] Re: [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 03:00:16PM -0600, Anthony Liguori wrote: > On 01/25/2010 02:27 PM, Michael S. Tsirkin wrote: >> On Mon, Jan 25, 2010 at 01:58:08PM -0600, Anthony Liguori wrote: >> >>> On 01/11/2010 11:23 AM, Michael S. Tsirkin wrote: >>> start/stop backend on driver start/sto

Re: [Qemu-devel] Re: [PATCH 1/3] Support --sysconfdir in configure to specify path to configuration files (v3)

2010-01-25 Thread Paolo Bonzini
I'm not sure about the choice for Windows. Do we want possibly a dozen of .conf files all in the same directory as the binaries, or maybe it's better to set sysconfdir = ${prefix}/conf, confdir=${sysconfdir} on Windows? I honestly don't know. What's the normal thing to do with Windows? The r

[Qemu-devel] Re: [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-25 Thread Michael S. Tsirkin
On Mon, Jan 25, 2010 at 03:00:16PM -0600, Anthony Liguori wrote: > On 01/25/2010 02:27 PM, Michael S. Tsirkin wrote: >> On Mon, Jan 25, 2010 at 01:58:08PM -0600, Anthony Liguori wrote: >> >>> On 01/11/2010 11:23 AM, Michael S. Tsirkin wrote: >>> start/stop backend on driver start/sto

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Alexander Graf
On 25.01.2010, at 22:05, Jes Sorensen wrote: > On 01/25/10 21:14, Anthony Liguori wrote: >> On 01/25/2010 02:04 PM, Alexander Graf wrote: >>> Yes, sounds good. Should be fairly extensible then. What about memory >>> holes? Do we need to take care of them? >> >> It would be nice for QEMU to be ab

[Qemu-devel] Re: [PATCH-RFC 13/13] virtio-net: connect to vhost net backend

2010-01-25 Thread Anthony Liguori
On 01/25/2010 03:05 PM, Michael S. Tsirkin wrote: it *has* an int: struct EventNotifier { int fd; }; Yes, this would be a lot better. Regards, Anthony Liguori

Re: [Qemu-devel] Re: [PATCH 1/3] Support --sysconfdir in configure to specify path to configuration files (v3)

2010-01-25 Thread Anthony Liguori
On 01/25/2010 03:05 PM, Paolo Bonzini wrote: I'm not sure about the choice for Windows. Do we want possibly a dozen of .conf files all in the same directory as the binaries, or maybe it's better to set sysconfdir = ${prefix}/conf, confdir=${sysconfdir} on Windows? I honestly don't know. What'

Re: [Qemu-devel] Re: [PATCH 1/3] Support --sysconfdir in configure to specify path to configuration files (v3)

2010-01-25 Thread Paolo Bonzini
On 01/25/2010 10:14 PM, Anthony Liguori wrote: On 01/25/2010 03:05 PM, Paolo Bonzini wrote: I'm not sure about the choice for Windows. Do we want possibly a dozen of .conf files all in the same directory as the binaries, or maybe it's better to set sysconfdir = ${prefix}/conf, confdir=${syscon

Re: [Qemu-devel] [PATCH] Add definitions for current cpu models..

2010-01-25 Thread Dor Laor
On 01/25/2010 04:21 PM, Anthony Liguori wrote: On 01/25/2010 03:08 AM, Dor Laor wrote: qemu-config.[ch], taking a new command line that parses the argument via QemuOpts, then passing the parsed options to a target-specific function that then builds the table of supported cpus. It should just be

[Qemu-devel] Re: [PATCH, RESEND] usb: increase buffer for USB control requests

2010-01-25 Thread Christian Krause
Hello Michael, On 01/24/2010 10:20 PM, Michael S. Tsirkin wrote: > On Sun, Jan 24, 2010 at 05:34:52PM +0100, Christian Krause wrote: >> Resend. The patch was already sent to the list on 2009-12-11. It would >> be great if it could be reviewed and applied. Thank you very much >> in advance. >> >> T

[Qemu-devel] Re: [PATCH] Seabios - read e820 reserve from qemu_cfg

2010-01-25 Thread Kevin O'Connor
On Mon, Jan 25, 2010 at 05:46:42PM +0100, Jes Sorensen wrote: > Hi, > > Right now KVM/QEMU relies on hard coded values in Seabios for the > reserved area for the TSS pages and the EPT page. > > I'd like to suggest we change this to pass the value from QEMU via > qemu-cfg making it possible to mov

[Qemu-devel] [PATCH] Seabios - read e820 reserve from qemu_cfg

2010-01-25 Thread Jes Sorensen
Hi, Right now KVM/QEMU relies on hard coded values in Seabios for the reserved area for the TSS pages and the EPT page. I'd like to suggest we change this to pass the value from QEMU via qemu-cfg making it possible to move it around dynamically in the future. Attached is a patch to Seabios for

[Qemu-devel] [PATCH] QEMU-KVM - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
Hi, This is the QEMU-KVM bits for providing the e820-reserve space through qemu-cfg. Cheers, Jes Use qemu-cfg to notify the BIOS of the location of the TSS range to reserve in the e820 table, to avoid relying on hard coded values. Signed-off-by: Jes Sorensen --- hw/fw_cfg.h |5 +++

[Qemu-devel] [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
Hi, This is the QEMU patch for providing the e820-reserve space through qemu-cfg. Cheers, Jes Use qemu-cfg to notify the BIOS of the location of the TSS range to reserve in the e820 table, to avoid relying on hard coded values. Signed-off-by: Jes Sorensen --- hw/pc.c |5 +

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 17:58, Alexander Graf wrote: Howdy. Congratulations to the new mail address - looks neat ;-). :-) Two comments: 1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure You'd get one variable for len of the table, one with

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 18:28, Alexander Graf wrote: That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 21:14, Anthony Liguori wrote: On 01/25/2010 02:04 PM, Alexander Graf wrote: Yes, sounds good. Should be fairly extensible then. What about memory holes? Do we need to take care of them? It would be nice for QEMU to be able to add additional e820 regions that don't necessarily fit t

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Jes Sorensen
On 01/25/10 22:08, Alexander Graf wrote: On 25.01.2010, at 22:05, Jes Sorensen wrote: Only problem is that we don't really have a way to pass back info saying 'you messed up trying to pinch an area that the BIOS wants for itself'. Eh - the BIOS shouldn't even try to use regions that are decla

[Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through qemu_cfg

2010-01-25 Thread Gleb Natapov
On Mon, Jan 25, 2010 at 06:13:35PM +0100, Jes Sorensen wrote: > On 01/25/10 17:58, Alexander Graf wrote: > >Howdy. Congratulations to the new mail address - looks neat ;-). > > :-) > > >Two comments: > > > >1) I don't see how passing a single region is any help. I'd rather like to > >see a devic

[Qemu-devel] KVM call agenda for Jan 26

2010-01-25 Thread Chris Wright
Please send in any agenda items you are interested in covering.