Re: [Qemu-devel] qemu per vm config file support

2010-04-13 Thread Amit Shah
On (Mon) Apr 12 2010 [21:06:29], Manish Regmi wrote: Hi, These days i am playing with qemu and kvm. The command line parameters can become very long. Is there any technical reason why config file is not implemented in qemu yet. See -readconfig and -writeconfig. There's partial support for

[Qemu-devel] Re: [PATCH v2 3/6] Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap.

2010-04-13 Thread Yoshiaki Tamura
Avi Kivity wrote: On 04/12/2010 01:58 PM, Yoshiaki Tamura wrote: Is it necessary to update migration and vga bitmaps? We can simply update the master bitmap, and update the migration and vga bitmaps only when they need it. That can be done in a different patch. Let me explain the role of

Re: [Qemu-devel] QEMU regression problems

2010-04-13 Thread Roy Tam
2010/4/12 Gerhard Wiesinger li...@wiesinger.com: Hello, Checkit reports some problems under DOS: 1.) NPU functions are not correct: NPU Trigonometric Functions: FAILED. Seems to be a problem of the instruction set. 2.) Real-Time Clock Alarm: FAILED (This might be also the reason for the KVM

[Qemu-devel] KVM call agenda for Apr 13

2010-04-13 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

[Qemu-devel] Re: Missing singlestep for already-translated code?

2010-04-13 Thread takasi-y
Hi, So for the already-translated code, we will miss singlestep? At least SH4(and mips?) shows such behaviour. I think a patch below enables single stepping in such case, too. But, I'm not sure if this behaviour is on purpose, nor this patch is correct. /yoshii diff --git

[Qemu-devel] [PATCH] fix migration with large mem

2010-04-13 Thread Izik Eidus
From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 2001 From: Izik Eidus iei...@redhat.com Date: Tue, 13 Apr 2010 12:24:57 +0300 Subject: [PATCH] fix migration with large mem In cases of guests with large mem that have pages that all their bytes content are the same, we will spend

[Qemu-devel] [PATCH 1/3] block: Convert first_drv to QLIST

2010-04-13 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 22 -- block_int.h |2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/block.c b/block.c index 5d087de..12cf434 100644 --- a/block.c +++ b/block.c @@ -58,7 +58,8 @@ static

[Qemu-devel] [PATCH 2/3] qemu-img: Eliminate bdrv_new_open() code duplication

2010-04-13 Thread Stefan Hajnoczi
Several commands have code to create a BlockDriverState and open a file. The bdrv_new_open() function can be used to perform these steps. This patch converts the qemu-img commands to actually use bdrv_new_open(). Replaced the bdrv_new_open() 'readonly' argument with bdrv_open()-style flags to

[Qemu-devel] [PATCH 3/3] qemu-img: Fix BRDV_O_FLAGS typo

2010-04-13 Thread Stefan Hajnoczi
It should be BDRV_O_FLAGS instead of BRDV_O_FLAGS. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- qemu-img.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b30effa..7203b8b 100644 --- a/qemu-img.c +++

[Qemu-devel] [PATCH 0/3] block and qemu-img: Further cleanups

2010-04-13 Thread Stefan Hajnoczi
These patches apply to Kevin's block branch.

[Qemu-devel] Re: Missing singlestep for already-translated code?

2010-04-13 Thread Jun Koi
On Tue, Apr 13, 2010 at 6:21 PM, takas...@ops.dti.ne.jp wrote: Hi, So for the already-translated code, we will miss singlestep? At least SH4(and mips?) shows such behaviour. I think a patch below enables single stepping in such case, too. But, I'm not sure if this behaviour is on purpose,

[Qemu-devel] Re: [PATCH v2 3/6] Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap.

2010-04-13 Thread Avi Kivity
On 04/13/2010 11:01 AM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 04/12/2010 01:58 PM, Yoshiaki Tamura wrote: Is it necessary to update migration and vga bitmaps? We can simply update the master bitmap, and update the migration and vga bitmaps only when they need it. That can be done in a

[Qemu-devel] [PATCH] block.h: bdrv_create2 doesn't exist any more

2010-04-13 Thread Kevin Wolf
The bdrv_create2 implementation has been disappeared long ago. Remove its prototype from the header file, too. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/block.h b/block.h index 4a57dd5..05ad572 100644 ---

[Qemu-devel] Re: [PATCH v2 3/6] Modifies wrapper functions for byte-based phys_ram_dirty bitmap to bit-based phys_ram_dirty bitmap.

2010-04-13 Thread Yoshiaki Tamura
Avi Kivity wrote: On 04/13/2010 11:01 AM, Yoshiaki Tamura wrote: Avi Kivity wrote: On 04/12/2010 01:58 PM, Yoshiaki Tamura wrote: Is it necessary to update migration and vga bitmaps? We can simply update the master bitmap, and update the migration and vga bitmaps only when they need it. That

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Jan Kiszka
Paul Brook wrote: A major reason for this deadlock could likely be removed by shutting down the tap (if peered) or dropping packets in user space (in case of vlan) when a NIC is stopped or otherwise shut down. Currently most (if not all) NIC models seem to signal both queue full and RX

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Jan Kiszka
Jamie Lokier wrote: Paul Brook wrote: A major reason for this deadlock could likely be removed by shutting down the tap (if peered) or dropping packets in user space (in case of vlan) when a NIC is stopped or otherwise shut down. Currently most (if not all) NIC models seem to signal both

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Jan Kiszka
Paul Brook wrote: But anyway, this flow control mechanism is buggy - what if instead of an interface down, you just have a *slow* guest? That should not push back so much that it makes other guests networking with each other slow down. The OP described multiple guests connected via a host

[Qemu-devel] [PATCH] SCSI: Add disk reset handler

2010-04-13 Thread Jan Kiszka
Ensure that pending requests of an SCSI disk are purged on system reset and also restore max_lba. The latter is now only present in the reset handler as that one is already automatically called during init. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/scsi-disk.c | 32

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Paul Brook
Paul Brook wrote: But anyway, this flow control mechanism is buggy - what if instead of an interface down, you just have a *slow* guest? That should not push back so much that it makes other guests networking with each other slow down. The OP described multiple guests connected via a

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Jan Kiszka
Paul Brook wrote: Paul Brook wrote: A major reason for this deadlock could likely be removed by shutting down the tap (if peered) or dropping packets in user space (in case of vlan) when a NIC is stopped or otherwise shut down. Currently most (if not all) NIC models seem to signal both queue

[Qemu-devel] Re: Missing singlestep for already-translated code?

2010-04-13 Thread Jan Kiszka
Jun Koi wrote: Hi, I am looking into the singlestep command in monitor interface, and it seems that we only take into account the singlestep flag when we are translating code. So for the already-translated code, we will miss singlestep? This feature is broken. For TCG, it should at least

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Paul Brook
Paul Brook wrote: A major reason for this deadlock could likely be removed by shutting down the tap (if peered) or dropping packets in user space (in case of vlan) when a NIC is stopped or otherwise shut down. Currently most (if not all) NIC models seem to signal both queue full and RX

[Qemu-devel] KVM call minutes for Apr 13

2010-04-13 Thread Chris Wright
No topics, short call

Re: [Qemu-devel] Re: Missing singlestep for already-translated code?

2010-04-13 Thread Alexander Graf
On 13.04.2010, at 15:36, Jan Kiszka wrote: Jun Koi wrote: Hi, I am looking into the singlestep command in monitor interface, and it seems that we only take into account the singlestep flag when we are translating code. So for the already-translated code, we will miss singlestep? This

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-13 Thread Ian Molton
Paul Brook wrote: Paul Brook wrote: So now everything that looks like a stream of bytes has to use the virtio-serial code... IMO, yes. That's the whole point of virtio-serial. You can handle it however you like in your in your favourite guest OS, but I object to qemu having multiple

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-13 Thread Paul Brook
Bear in mind that its rather unfair to (as has been in this case) have a patch reviewed, modified based on criticism, and then rejected after effort has been wasted working on it. I'm pretty sure I raised all these issues the first time this code was submitted. Paul

[Qemu-devel] [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Michael S. Tsirkin
The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed. This happens because tun/tap devices can hang on to skbs undefinitely. As noted by Herbert, possible solutions include a timeout followed by a copy/change of

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Herbert Xu
On Tue, Apr 13, 2010 at 05:59:44PM +0300, Michael S. Tsirkin wrote: The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed. This happens because tun/tap devices can hang on to skbs undefinitely. As noted by

Re: [Qemu-devel] Re: Missing singlestep for already-translated code?

2010-04-13 Thread Jan Kiszka
Alexander Graf wrote: On 13.04.2010, at 15:36, Jan Kiszka wrote: Jun Koi wrote: Hi, I am looking into the singlestep command in monitor interface, and it seems that we only take into account the singlestep flag when we are translating code. So for the already-translated code, we will

Re: [Qemu-devel] [PATCH 2/2] VirtIO RNG

2010-04-13 Thread Paul Brook
So, rather than bike-shedding, how about making some kind of decision? Ok, let me make this simple. Features such as rate limiting and EGD protocol translation should not be part of individual device emulation. They are part of the host interface, not the guest machine. If you really want

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Jan Kiszka
Michael S. Tsirkin wrote: The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed. And before that, tap1 may not be able to send further packets to anyone else on the bridge as its TX resources were blocked by tap2 -

[Qemu-devel] Re: Problem with QEMU on KVM

2010-04-13 Thread Jan Kiszka
Mulyadi Santosa wrote: Hi Jamie... On Mon, Apr 12, 2010 at 19:07, Jamie Lokier ja...@shareable.org wrote: There are various -no-kvm-XXX options to try: -no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC -no-kvm-pit disable KVM kernel mode PIT -no-kvm-pit-reinjection disable KVM

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Jan Kiszka
Eric Dumazet wrote: Le mardi 13 avril 2010 à 17:36 +0200, Jan Kiszka a écrit : Michael S. Tsirkin wrote: The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed. And before that, tap1 may not be able to send

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2010 at 06:40:38PM +0200, Eric Dumazet wrote: Le mardi 13 avril 2010 à 17:36 +0200, Jan Kiszka a écrit : Michael S. Tsirkin wrote: The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed.

[Qemu-devel] Re: [PATCH] block: Split bdrv_open

2010-04-13 Thread Christoph Hellwig
On Mon, Apr 12, 2010 at 04:49:16PM +0200, Kevin Wolf wrote: bdrv_open contains quite some code that is only useful for opening images (as opposed to opening files by a protocol), for example snapshots. This patch splits the code so that we have bdrv_open_file() for files (uses protocols),

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Blue Swirl
On 4/12/10, Paul Brook p...@codesourcery.com wrote: A major reason for this deadlock could likely be removed by shutting down the tap (if peered) or dropping packets in user space (in case of vlan) when a NIC is stopped or otherwise shut down. Currently most (if not all) NIC models seem

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

2010-04-13 Thread jvrao
jvrao wrote: Alexander Graf wrote: On 12.04.2010, at 13:58, Jamie Lokier wrote: Mohammed Gamal wrote: On Mon, Apr 12, 2010 at 12:29 AM, Jamie Lokier ja...@shareable.org wrote: Javier Guerra Giraldez wrote: On Sat, Apr 10, 2010 at 7:42 AM, Mohammed Gamal m.gamal...@gmail.com wrote: On

Re: [Qemu-devel] How to lock-up your tap-based VM network

2010-04-13 Thread Blue Swirl
On 4/13/10, Blue Swirl blauwir...@gmail.com wrote: On 4/12/10, Paul Brook p...@codesourcery.com wrote: A major reason for this deadlock could likely be removed by shutting down the tap (if peered) or dropping packets in user space (in case of vlan) when a NIC is stopped or otherwise

Re: [Qemu-devel] Problem with DOS application and 286 DOS Extender application

2010-04-13 Thread Gerhard Wiesinger
On Tue, 13 Apr 2010, Roy Tam wrote: 2010/4/13 Gerhard Wiesinger li...@wiesinger.com: Hello, I'm having a problem with a DOS application which uses a 286 DOS Extender, error message is as the following: unable to create task for execution Interrupt 10 (Ah) while creating task: Invalid task

Re: [Qemu-devel] Problem with QEMU on KVM

2010-04-13 Thread Gerhard Wiesinger
On Mon, 12 Apr 2010, Jamie Lokier wrote: Mulyadi Santosa wrote: Hi Gerhard... On Sun, Apr 11, 2010 at 20:52, Gerhard Wiesinger li...@wiesinger.com wrote: OK, uses the following ports: Port 0x20: 8259 interrupt controller Port 0x40: 8253 timer Interrupt 0x1A: ah=0x00: fetches system timer

Re: [Qemu-devel] [GSoC 2010] Pass-through filesystem support.

2010-04-13 Thread Mohammed Gamal
On Tue, Apr 13, 2010 at 9:08 PM, jvrao jv...@linux.vnet.ibm.com wrote: jvrao wrote: Alexander Graf wrote: On 12.04.2010, at 13:58, Jamie Lokier wrote: Mohammed Gamal wrote: On Mon, Apr 12, 2010 at 12:29 AM, Jamie Lokier ja...@shareable.org wrote: Javier Guerra Giraldez wrote: On Sat, Apr

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2010 at 08:31:03PM +0200, Eric Dumazet wrote: Le mardi 13 avril 2010 à 20:39 +0300, Michael S. Tsirkin a écrit : When a socket with inflight tx packets is closed, we dont block the close, we only delay the socket freeing once all packets were delivered and freed.

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2010 at 10:38:06PM +0200, Eric Dumazet wrote: Le mardi 13 avril 2010 à 23:25 +0300, Michael S. Tsirkin a écrit : On Tue, Apr 13, 2010 at 08:31:03PM +0200, Eric Dumazet wrote: Le mardi 13 avril 2010 à 20:39 +0300, Michael S. Tsirkin a écrit : When a socket with

[Qemu-devel] [PATCH v2] Write cmos hd data for ide drives using -device parm

2010-04-13 Thread Bruce Rogers
When specifying ide devices using -device, the cmos information which the bios depends on is not written. This patch generalizes the cmos hd data setting for the existing code path and adds the ability to call that code on a per machine, per ide drive basis. This is important for older

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Eric Dumazet
Le mardi 13 avril 2010 à 17:36 +0200, Jan Kiszka a écrit : Michael S. Tsirkin wrote: The following situation was observed in the field: tap1 sends packets, tap2 does not consume them, as a result tap1 can not be closed. And before that, tap1 may not be able to send further packets to

Re: [Qemu-devel] [PATCH] arm: Fix compiler warning (fprintf format string)

2010-04-13 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 10:49:50PM +0200, Stefan Weil wrote: When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil w...@mail.berlios.de

Re: [Qemu-devel] [PATCH] m68k: Fix compiler warning (fprintf format string)

2010-04-13 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 10:49:51PM +0200, Stefan Weil wrote: When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. It also removes a type cast which is not needed.

Re: [Qemu-devel] [PATCH] sh4: Fix compiler warning (fprintf format string)

2010-04-13 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 10:49:52PM +0200, Stefan Weil wrote: When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil w...@mail.berlios.de

Re: [Qemu-devel] [PATCH] sparc: Fix compiler warning (fprintf format string)

2010-04-13 Thread Aurelien Jarno
On Fri, Apr 09, 2010 at 10:49:53PM +0200, Stefan Weil wrote: When argument checking is enabled, gcc throws this error: error: format not a string literal and no format arguments The patch rewrites the statement to satisfy the compiler. Signed-off-by: Stefan Weil w...@mail.berlios.de

Re: [Qemu-devel] [PATCH] linux-user: do_shmdt(): Fix page_set_flags's 2nd arg.

2010-04-13 Thread Aurelien Jarno
On Sun, Apr 11, 2010 at 02:09:57AM +0900, takas...@ops.dti.ne.jp wrote: 2nd arg of page_set_flags() should be start+size, but size. Signed-off-by: Takashi YOSHII takas...@ops.dti.ne.jp Thanks, applied. --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] Qemu sharing files help

2010-04-13 Thread Arpit Patel
Hi, I have Ubuntu on my host system and I am using following command on it, to load kernel.. *qemu -kernel kernelimage -initrd initrd.img /dev/zero -append cmdline * Was wondering, how can I share/copy files from host Ubuntu system to the one with above command? Someone mentioned using sshfs,

Re: [Qemu-devel] Problem with DOS application and 286 DOS Extender application

2010-04-13 Thread Jamie Lokier
Gerhard Wiesinger wrote: It is a non public, proprietary application which uses the Ergo Computing 286 DOS Extender. I guess some other application which use the same DOS extender have the same problem. So best thing is to find another application which uses the Ergo Computing 286 DOS

[Qemu-devel] Re: ehci update

2010-04-13 Thread Jan Kiszka
David S. Ahern wrote: After a month of code refactoring and clean ups, etc, I thought I would send along an update. The attached patch is relative to your ehci branch; I also attached the full usb-ehci.c file for easier reading. Thanks for your work! I applied it and once again merged git head

[Qemu-devel] Re: ehci update

2010-04-13 Thread David S. Ahern
On 04/13/2010 05:35 PM, Jan Kiszka wrote: David S. Ahern wrote: After a month of code refactoring and clean ups, etc, I thought I would send along an update. The attached patch is relative to your ehci branch; I also attached the full usb-ehci.c file for easier reading. Thanks for your

[Qemu-devel] Re: [PATCH] tun: orphan an skb on tx

2010-04-13 Thread Herbert Xu
On Tue, Apr 13, 2010 at 08:31:03PM +0200, Eric Dumazet wrote: Herbert Acked your patch, so I guess its OK, but I think it can be dangerous. The tun socket accounting was never designed to stop it from flooding another tun interface. It's there to stop it from transmitting above a destination

Re: [SeaBIOS] [Qemu-devel] QEMU regression problems

2010-04-13 Thread Kevin O'Connor
On Tue, Apr 13, 2010 at 02:26:10PM +0800, Roy Tam wrote: 2010/4/12 Gerhard Wiesinger li...@wiesinger.com: 3.) There is also a problem with the reported base memory under QEMM386 (HIMEM.SYS and EMM386.EXE is correct here). It is 646kB instead of 640kB. Therefore base memory test fails. I

Re: [Qemu-devel] Re: ehci update

2010-04-13 Thread Alexander Graf
On 14.04.2010, at 01:50, David S. Ahern wrote: On 04/13/2010 05:35 PM, Jan Kiszka wrote: David S. Ahern wrote: After a month of code refactoring and clean ups, etc, I thought I would send along an update. The attached patch is relative to your ehci branch; I also attached the full

[Qemu-devel] Re: SeaBIOS error with Juniper FreeBSD kernel

2010-04-13 Thread Kevin O'Connor
On Tue, Apr 13, 2010 at 08:48:35PM +0200, Bjørn Mork wrote: Gleb Natapov g...@redhat.com writes: On Sun, Feb 28, 2010 at 02:39:04PM -0500, Kevin O'Connor wrote: On Sun, Feb 21, 2010 at 04:18:38PM -0700, Brandon Bennett wrote: I have narrowed it down to SMBIOS. If I disable CONFIG_SMBIOS

[Qemu-devel] Re: [PULL] pci,vhost-net,eepro100

2010-04-13 Thread Anthony Liguori
On 04/11/2010 03:29 PM, Michael S. Tsirkin wrote: The following changes since commit f7e2aca83419dde3c94fa1d5e615581bb4ded9c0: tcg/ppc: Fix typo (2010-04-06 03:10:03 +0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony

Re: [Qemu-devel] Re: ehci update

2010-04-13 Thread David S. Ahern
On 04/13/2010 07:20 PM, Alexander Graf wrote: It still needs a lot of love, but definitely an improvement from the last version. The biggest difference for the performance boost and stability is discovering that the usbfs in linux limits transactions to 16k versus the EHCI spec which allows

[Qemu-devel] [PATCH v5 00/17] virtio-serial fixes, new abi for port discovery, flow control

2010-04-13 Thread Amit Shah
Hello, These patches rework the way ports are announced to the guests. A control message is used to let the guest know a new port is added. Initial port discovery and port hot-plug work via this way now. This was done to have the host and guest port numbering in sync to avoid surprises after

[Qemu-devel] [PATCH v5 01/17] virtio-serial: save/load: Ensure target has enough ports

2010-04-13 Thread Amit Shah
The target could be started with max_nr_ports for a virtio-serial device lesser than what was available on the source machine. Fail the migration in such a case. Signed-off-by: Amit Shah amit.s...@redhat.com Reported-by: Juan Quintela quint...@redhat.com --- hw/virtio-serial-bus.c | 13

[Qemu-devel] [PATCH v5 02/17] virtio-serial: save/load: Ensure nr_ports on src and dest are same.

2010-04-13 Thread Amit Shah
The number of ports on the source as well as the destination machines should match. If they don't, it means some ports that got hotplugged on the source aren't instantiated on the destination. Or that ports that were hot-unplugged on the source are created on the destination. Signed-off-by: Amit

[Qemu-devel] [PATCH v5 06/17] virtio-serial: whitespace: match surrounding code

2010-04-13 Thread Amit Shah
The virtio-serial code doesn't mix declarations and definitions, so separate them out on different lines. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/virtio-serial-bus.c

[Qemu-devel] [PATCH v5 03/17] virtio-serial: save/load: Ensure we have hot-plugged ports instantiated

2010-04-13 Thread Amit Shah
If some ports that were hot-plugged on the source are not available on the destination, fail migration instead of trying to deref a NULL pointer. Signed-off-by: Amit Shah amit.s...@redhat.com Reported-by: Juan Quintela quint...@redhat.com --- hw/virtio-serial-bus.c |7 +++ 1 files

[Qemu-devel] [PATCH v5 07/17] virtio-serial: Remove redundant check for 0-sized write request

2010-04-13 Thread Amit Shah
The check for a 0-sized write request to a guest port is not necessary; the while loop below won't be executed in this case and all will be fine. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v5 05/17] virtio-serial: Use control messages to notify guest of new ports

2010-04-13 Thread Amit Shah
Allow the port 'id's to be set by a user on the command line. This is needed by management apps that will want a stable port numbering scheme for hot-plug/unplug and migration. Since the port numbers are shared with the guest (to identify ports in control messages), we just send a control message

[Qemu-devel] [PATCH v5 08/17] virtio-serial: Update copyright year to 2010

2010-04-13 Thread Amit Shah
Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c|2 +- hw/virtio-serial-bus.c |2 +- hw/virtio-serial.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 17b221d..6b8 100644 ---

[Qemu-devel] [PATCH v5 09/17] virtio-serial: Propagate errors in initialising ports / devices in guest

2010-04-13 Thread Amit Shah
If adding of ports or devices in the guest fails we can send out a QMP event so that management software can deal with it. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-serial-bus.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git