[Qemu-devel] Re: [PATCH] virtio-serial: Simplify virtio_serial_load()

2010-06-26 Thread Markus Armbruster
Did this fall through the cracks? Markus Armbruster arm...@redhat.com writes: For all i, ports_map[i] is used in and only in the i-th iteration. Replace the dynamic array by a scalar variable. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/virtio-serial-bus.c | 12

Re: [Qemu-devel] [PATCH] tcg-s390: New TCG Target.

2010-06-26 Thread malc
On Fri, 25 Jun 2010, Richard Henderson wrote: Original patch from Ulrich Hecht, further work from Alexander Graf and Richard Henderson. Cc: Ulrich Hecht u...@suse.de Cc: Alexander Graf ag...@suse.de Signed-off-by: Richard Henderson r...@twiddle.net [..snip..] +/* #define DEBUG_S390_TCG

Re: [Qemu-devel] [PATCH 00/19] RFC: Reporting QEMU binary capabilities

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: [...] The main problem encountered with this patch series is the split between argv and config parameters. The qemu-config.c file provides the information is a good data format, allowing programatic access to the list of parameters for each

Re: [Qemu-devel] [PATCH 03/19] Add enum handlers for easy efficient string - int conversion

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: There is quite alot of code using an enumeration of possible values, which also needs todo conversions to/from a string representation of enum values. These string - int conversions have been repeated in an adhoc manner throughout the code.

Re: [Qemu-devel] [PATCH 04/19] Add support for a option parameter as an enum

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: This adds a new option parameter QEMU_OPT_ENUM. The user provides the value in its string representation. The parser validates this and converts it to integer representation for internal use. If the user supplies an invalid value it will report

Re: [Qemu-devel] [PATCH 05/19] Ensure that QEMU exits if drive_add parsing fails

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: The drive_add() method returns NULL if it failed to parse the parameter values for any reason. All callers must check this and exit if failure occurred. Annotate the method so that the compiler validates this. Good move. Need more of that.

Re: [Qemu-devel] [PATCH 06/19] Convert drive options to use enumeration data type

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: This converts the drive options if, trans, media, cache, aio, rerror and werror to use the QEMU_OPT_ENUM datatype. This standardizes the string parsing and error reporting $ qemu -drive file=foo,werror=stop3 qemu: -drive

Re: [Qemu-devel] [PATCH 11/19] Add a query-devices command to QMP

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Mon, Jun 07, 2010 at 10:14:00AM -0500, Anthony Liguori wrote: On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Adds a command to QMP called 'query-devices' to allow for discovery of all devices known to the QEMU binary. THis is inteded to

Re: [Qemu-devel] [PATCH 12/19] Add a query-cputypes command to QMP

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: This adds a new QMP command called 'query-cputypes' to allow for discovery of CPU types known to the QEMU binary. This is intended to relpace the need to parse '-cpu ?', '-cpu ?model' and '-cpu ?dump' Most targets have a simple structure

Re: [Qemu-devel] [PATCH 14/19] Add a query-argv command to QMP

2010-06-26 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: Add a new QMP command called 'query-argv' to information about the command line arguments supported by the QEMU binary. This is intended to remove the need for apps to parse '-help' output.

Re: [Qemu-devel] [PATCH 16/19] Add a query-netdev command to QMP

2010-06-26 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 06/07/2010 09:42 AM, Daniel P. Berrange wrote: This adds a new QMP command called query-netdev to provide information about the available netdev backends in the QEMU binary. There is no existing '-netdev ?' support, but if there was, this would

Re: [Qemu-devel] [PATCH 17/19] Add a query-config command to QMP

2010-06-26 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: Add a new command to QMP called 'query-config' that provides information about the allowed configuration file entries for the binary. The config file is really just another syntax for the command-line options using QemuOptsList. Not sure we want

Re: [Qemu-devel] [PATCH 5/7] add qdev property type cpu

2010-06-26 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: [...] diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 5a8739d..2759c83 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -1,6 +1,7 @@ #include net.h #include qdev.h #include qerror.h +#include cpus.h void

Re: [Qemu-devel] [PATCH 6/7] replace void* uses with opaque CPUState*

2010-06-26 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Because we all love type safety, don't we? And incomplete types! Much better choice for an abstract data type than abusing poor old void *. You also get rid of a use of the DEFINE_PROP_PTR() abomination. Thanks!

[Qemu-devel] Tracing: outstanding tasks

2010-06-26 Thread Stefan Hajnoczi
Here are the outstanding tasks for QEMU tracing, which Prerna and I have been working on. Tracing aids debugging, profiling, and observing execution via lightweight logging at key points in the code path. The current prototype is available from the 'tracing' branch at:

[Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-26 Thread Christoph Hellwig
On Sat, Jun 26, 2010 at 07:32:09AM +0200, Markus Armbruster wrote: Christoph Hellwig h...@lst.de writes: +DriveInfo *drive_of_blockdev(BlockDriverState *bs) I'd call this find_drive_by_blockdev. For what it's worth, all externally visible functions dealing with drives start with

[Qemu-devel] Re: [PATCH 05/12] blockdev: Clean up automatic drive deletion

2010-06-26 Thread Christoph Hellwig
Looks correct to me, Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] Re: [PATCH 06/12] qdev: Decouple qdev_prop_drive from DriveInfo

2010-06-26 Thread Christoph Hellwig
On Fri, Jun 25, 2010 at 06:53:26PM +0200, Markus Armbruster wrote: Make the property point to BlockDriverState, cutting out the DriveInfo middleman. This prepares the ground for block devices that don't have a DriveInfo. Currently all user-defined ones have a DriveInfo, because the only way

[Qemu-devel] Re: [PATCH 07/12] blockdev: drive_get_by_id() is no longer used, remove

2010-06-26 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev

2010-06-26 Thread Christoph Hellwig
On Fri, Jun 25, 2010 at 06:53:28PM +0200, Markus Armbruster wrote: For instance, -device scsi-disk,drive=foo -device scsi-disk,drive=foo happily creates two SCSI disks connected to the same block device. It's all downhill from there. And from some quick testing a while ago the thing seems to

[Qemu-devel] Re: [PATCH 09/12] savevm: Survive hot-unplug of snapshot device

2010-06-26 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de Of course specifying an explicit medium for snapshot, be that the snapshot section of a qcow2 image or just a separate flat file and managing that one explicitly would be even better.

[Qemu-devel] Re: [PATCH 11/12] ide: Make PIIX and ISA IDE init functions return the qdev

2010-06-26 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] Re: [PATCH 10/12] block: Fix virtual media change for if=none

2010-06-26 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

[Qemu-devel] [Bug 571432] Re: qemu-system-arm crashed with SIGSEGV in subpage_register()

2010-06-26 Thread sam tygier
that did not seem to help: I: linux-image-2.6.32.11-l13_1.0lucid_armel.deb download complete I: Setting up serial tty in image I: Getting Virtual Machine kernel from the server I: Switching to Virtual Machine for second stage processing Adding `local diversion of /usr/sbin/invoke-rc.d to

[Qemu-devel] [Bug 571432] Re: qemu-system-arm crashed with SIGSEGV in subpage_register()

2010-06-26 Thread sam tygier
the actual qemu output from: qemu-system-arm -M versatilepb -cpu cortex-a8 -kernel qemu-vmlinuz -no-reboot -nographic -drive file=qemu-armel-201006261210.img,aio=native,cache=none -m 256 -net nic,model=rtl8139 -append console=ttyAMA0,115200n8 root=/dev/sda rw mem=256M devtmpfs.mount=0

[Qemu-devel] [Bug 571432] Re: qemu-system-arm crashed with SIGSEGV in subpage_register()

2010-06-26 Thread sam tygier
looks like i dont have much choice of nic on arm. s...@oberon:/data/beagleboard/ubuntu-lucid/build/qemu-test2$ qemu-system-arm -net nic,model=? qemu: Supported NIC models: smc91c111 s...@oberon:/data/beagleboard/ubuntu-lucid/build/qemu-test2$ qemu-system-x86_64 -net nic,model=? qemu: Supported

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2010-06-26 Thread LightBit
SeaBIOS 6.0 solved problem for me. ** Attachment added: SeaBIOS 6.0 http://launchpadlibrarian.net/50945984/bios.bin -- Windows 98 doesn't detect mouse on qemu and SeaBIOS. https://bugs.launchpad.net/bugs/521994 You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-26 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: On Sat, Jun 26, 2010 at 07:32:09AM +0200, Markus Armbruster wrote: Christoph Hellwig h...@lst.de writes: +DriveInfo *drive_of_blockdev(BlockDriverState *bs) I'd call this find_drive_by_blockdev. For what it's worth, all externally visible

Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev

2010-06-26 Thread Markus Armbruster
Christoph Hellwig h...@lst.de writes: On Fri, Jun 25, 2010 at 06:53:28PM +0200, Markus Armbruster wrote: For instance, -device scsi-disk,drive=foo -device scsi-disk,drive=foo happily creates two SCSI disks connected to the same block device. It's all downhill from there. And from some quick

[Qemu-devel] [Bug 571432] Re: qemu-system-arm crashed with SIGSEGV in subpage_register()

2010-06-26 Thread sam tygier
i had a try with qemu 0.12.4+noroms-0ubuntu3 but it did not help -- qemu-system-arm crashed with SIGSEGV in subpage_register() https://bugs.launchpad.net/bugs/571432 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: New

[Qemu-devel] qemu-kvm guest network stalls

2010-06-26 Thread William King
I have an ubuntu lucid host and an ubuntu lucid guest. Under heavy network load the guest network stalls and is only able to come back after running sudo /etc/init.d/networking restart on the guest. Here are some (hopefully) helpful details.

[Qemu-devel] [PATCH] Don't declare XSAVE as supported

2010-06-26 Thread Andi Kleen
Don't declare XSAVE as supported i386 cpuid.c currently claims XSAVE is supported in the CPUID filter, but that's not true: Only FXSAVE is supported. Remove that bit from the filter. Signed-off-by: Andi Kleen a...@linux.intel.com diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index

[Qemu-devel] [PATCH] Add more boundary checking to sse3/4 parsing

2010-06-26 Thread Andi Kleen
Add more boundary checking to sse3/4 parsing s?sse3 uses tables with only two entries per op, but it is indexed with b1 which can contain variables upto 3. This happens when ssse3 or sse4 are used with REP* prefixes. Add boundary checking for this case. Signed-off-by: Andi Kleen