Re: [Qemu-devel] [PATCH] linux-user: remove unnecessary local from __get_user(), __put_user()

2010-11-15 Thread Riku Voipio
On Mon, Nov 08, 2010 at 06:13:58PM +, Peter Maydell wrote: Remove an unnecessary local variable from the __get_user() and __put_user() macros. This avoids confusing compilation failures if the name of the local variable ('size') happens to be the same as the variable the macro user is

[Qemu-devel] Re: [PATCH v8 07/11] pci: introduce a parser for pci device path

2010-11-15 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 04:30:43PM +0900, Isaku Yamahata wrote: introduce a function to parse pci device path of the format, [Domain:]Slot.Function:Slot.Function:Slot.Function. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Hmm. How about we use openfirmware path like what Gleb's

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Gleb Natapov
On Mon, Nov 15, 2010 at 09:53:50AM +0200, Michael S. Tsirkin wrote: On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: On Sun, Nov 14, 2010 at 05:39:41PM +0200, Gleb Natapov wrote: +/* + * This function

[Qemu-devel] Re: [PATCH v8 01/11] pci: revise pci command register initialization

2010-11-15 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 04:30:37PM +0900, Isaku Yamahata wrote: This patch cleans up command register initialization with comments. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp Probably just fold with the next patch. --- hw/pci.c | 42 ++

Re: Re: [Qemu-devel] How to make shadow memory for a process? and how to trace the data propation from the instruction level in QEMU?

2010-11-15 Thread Mulyadi Santosa
Hi OK it's getting interesting perhaps it would lead into instrumentation topic, which is quite hot topic in qemu-devel quite recently, so you jump into the wagon just about the right time :) 2010/11/15 F. Zhang qemust...@163.com: I am very pleased to share ideas with you. But my

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov g...@redhat.com wrote: Signed-off-by: Gleb Natapov g...@redhat.com ---  hw/fw_cfg.c |   14 ++  hw/fw_cfg.h |    4 +++-  sysemu.h    |    1 +  vl.c        |   51

[Qemu-devel] Re: [PATCH v8 07/11] pci: introduce a parser for pci device path

2010-11-15 Thread Isaku Yamahata
On Mon, Nov 15, 2010 at 10:06:13AM +0200, Michael S. Tsirkin wrote: On Mon, Nov 15, 2010 at 04:30:43PM +0900, Isaku Yamahata wrote: introduce a function to parse pci device path of the format, [Domain:]Slot.Function:Slot.Function:Slot.Function. Signed-off-by: Isaku Yamahata

[Qemu-devel] Re: [PATCH v8 07/11] pci: introduce a parser for pci device path

2010-11-15 Thread Gleb Natapov
On Mon, Nov 15, 2010 at 05:57:40PM +0900, Isaku Yamahata wrote: On Mon, Nov 15, 2010 at 10:06:13AM +0200, Michael S. Tsirkin wrote: On Mon, Nov 15, 2010 at 04:30:43PM +0900, Isaku Yamahata wrote: introduce a function to parse pci device path of the format,

Re: [Qemu-devel] [PATCH RESENT] msix: allow byte and word reading from mmio

2010-11-15 Thread Bernhard Kohl
Am 22.08.2010 23:34, schrieb ext Anthony Liguori: On 08/19/2010 07:56 AM, Bernhard Kohl wrote: It's legal that the guest reads a single byte or word from mmio. I have an OS which reads single bytes and it works fine on real hardware. Maybe this happens due to casting. Signed-off-by:

[Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port

2010-11-15 Thread Bernhard Kohl
Am 01.09.2010 16:44, schrieb Bernhard Kohl: We have an OS which writes to port 0x400 when probing for special hardware. This causes an exit of the VM. With SeaBIOS this port isn't used anyway. Signed-off-by: Bernhard Kohlbernhard.k...@nsn.com --- hw/pc.c |2 -- 1 files changed, 0

Re: [Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port

2010-11-15 Thread Alexander Graf
On 15.11.2010, at 10:53, Bernhard Kohl wrote: Am 01.09.2010 16:44, schrieb Bernhard Kohl: We have an OS which writes to port 0x400 when probing for special hardware. This causes an exit of the VM. With SeaBIOS this port isn't used anyway. Signed-off-by: Bernhard Kohlbernhard.k...@nsn.com

[Qemu-devel] Re: [PATCHv4 13/15] Add bootindex for option roms.

2010-11-15 Thread Gleb Natapov
On Sun, Nov 14, 2010 at 09:33:06PM +, Blue Swirl wrote: On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov g...@redhat.com wrote: Extend -option-rom command to have additional parameter ,bootindex=. This patch is broken: CCarm-softmmu/palm.o /src/qemu/hw/palm.c: In function

Re: [Qemu-devel] [PATCH V6 02/15] xen: Support new libxc calls from xen unstable.

2010-11-15 Thread Alexander Graf
On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com Update the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We also check libxenctrl version in

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

2010-11-15 Thread Alexander Graf
On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each

Re: [Qemu-devel] virtio-blk broken after system reset

2010-11-15 Thread Kevin Wolf
Am 13.11.2010 11:09, schrieb Jan Kiszka: Am 13.11.2010 11:01, Michael Tokarev wrote: 13.11.2010 10:51, Jan Kiszka wrote: Am 13.11.2010 08:49, Stefan Hajnoczi wrote: On Fri, Nov 12, 2010 at 10:02 PM, Jan Kiszka jan.kis...@web.de wrote: Hi, both after hard and guest-initiated reset, something

[Qemu-devel] Re: [PATCH RESENT] msix: allow byte and word reading from mmio

2010-11-15 Thread Michael S. Tsirkin
On Thu, Aug 19, 2010 at 02:56:51PM +0200, Bernhard Kohl wrote: It's legal that the guest reads a single byte or word from mmio. Interesting. The spec seems to say this: For all accesses to MSI-X Table and MSI-X PBA fields, software must use aligned full DWORD or aligned full

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

2010-11-15 Thread Alexander Graf
On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each

Re: [Qemu-devel] [PATCH V6 05/15] xen: Add xen in -accel option.

2010-11-15 Thread Alexander Graf
On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This come with the initialisation of Xen. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- Makefile.target |5 + hw/xen.h| 10 ++ vl.c

Re: [Qemu-devel] Add support for SystemTAP and DTrace tracing backends (v6)

2010-11-15 Thread Stefan Hajnoczi
On Fri, Nov 12, 2010 at 1:20 PM, Daniel P. Berrange berra...@redhat.com wrote: An update of the SystemTAP/DTrace patches from  http://lists.gnu.org/archive/html/qemu-devel/2010-11/msg00563.html The first patch contains the generic DTrace tracing backend support. The second patch contains

Re: [Qemu-devel] [PATCH V6 06/15] xen: Add the Xen platform pci device

2010-11-15 Thread Alexander Graf
On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Steven Smith ssm...@xensource.com Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Steven Smith ssm...@xensource.com

Re: [Qemu-devel] [PATCH V6 03/15] xen: Add xen_machine_fv

2010-11-15 Thread Kevin Wolf
Am 15.11.2010 11:35, schrieb Alexander Graf: On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com Add the Xen FV (Fully Virtualized) machine to Qemu; this is groundwork to add Xen device model support in Qemu. Signed-off-by: Anthony

Re: [Qemu-devel] Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify

2010-11-15 Thread Stefan Hajnoczi
On Sun, Nov 14, 2010 at 12:19 PM, Avi Kivity a...@redhat.com wrote: On 11/14/2010 01:05 PM, Avi Kivity wrote: I agree, but let's enable virtio-ioeventfd carefully because bad code is out there. Sure.  Note as long as the thread waiting on ioeventfd doesn't consume too much cpu, it will

[Qemu-devel] [PATCH] device-assignment: register a reset function

2010-11-15 Thread Bernhard Kohl
This is necessary because during reboot of a VM the assigned devices continue DMA transfers which causes memory corruption. Signed-off-by: Thomas Ostler thomas.ost...@nsn.com Signed-off-by: Bernhard Kohl bernhard.k...@nsn.com --- Sorry for for the long delay. Finally we added Alex' suggestions

Re: [Qemu-devel] [PATCH V6 09/15] xen: Introduce the Xen mapcache

2010-11-15 Thread Alexander Graf
On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Jun Nakajima jun.nakaj...@intel.com On IA32 host or IA32 PAE host, at present, generally, we can't create an HVM guest with more than 2G memory, because generally it's almost impossible for Qemu to find a large enough and

[Qemu-devel] [PATCH] make-release: fix mtime for a wider range of git versions

2010-11-15 Thread Bernhard Kohl
With the latest git versions, e.g. 1.7.2.3, git still prints out the tag info in addition to the requested format. So let's simply fetch the first line from the output. In addition I use the --pretty option instead of --format which is not recognized in very old git versions, e.g. 1.5.5.6.

Re: [Qemu-devel] How to make shadow memory for a process? and how to trace the data propation from the instruction level in QEMU?

2010-11-15 Thread Lluís
Mulyadi Santosa writes: Yes, I have read that paper, it’s wonderful! Besides the Argos, the bitblaze group, led by Dawn Song in Berkeley, has achieved great success in the taint analysis. The website about their dynamic analysis work (called TEMU) can be found at:

[Qemu-devel] [PATCH] audio: disable timer when idle.

2010-11-15 Thread Gerd Hoffmann
This patch makes sure the audio timer gets disabled when no voice is active. It adds a variable to track whenever the timer is needed or not to the global audio state. audio_timer_reset() will set that variable. audio_timer() will check that variable and only re-arm the timer when needed. One

Re: [Qemu-devel] [PATCH] ARM: semi-hosting support for stderr

2010-11-15 Thread Christophe Lyon
On 14.11.2010 18:50, Peter Maydell wrote: Although newlib/libgloss use different modes for opening stdout and stderr, the ARM C library implementation does not, for instance; so your patch is relying on a detail of implementation of a particular semihosting user. So I don't think we can apply

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

2010-11-15 Thread Paolo Bonzini
On 11/15/2010 11:46 AM, Alexander Graf wrote: I take back my Acked-by. Sorry, I guess I should have read things in more detail first O_o. I still believe that this patch can go in before the others, but I'd at least like to see some comments on the (0) pointer thing:). I agree, it kind of

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Kevin O'Connor
On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: Why not just return a newline separated list that is null terminated? Doing it like this will needlessly complicate firmware side. How do you know how much memory

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Gleb Natapov
On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: Why not just return a newline separated list that is null terminated? Doing it like this will

Re: [Qemu-devel] [PATCH V6 02/15] xen: Support new libxc calls from xen unstable.

2010-11-15 Thread Stefano Stabellini
On Mon, 15 Nov 2010, Alexander Graf wrote: /* - * tweaks needed to build with different xen versions - * 0x00030205 - 3.1.0 - * 0x00030207 - 3.2.0 - * 0x00030208 - unstable + * We don't support Xen prior to 3.3.0. */ -#include xen/xen-compat.h -#if

Re: [Qemu-devel] [PATCH V6 03/15] xen: Add xen_machine_fv

2010-11-15 Thread Stefano Stabellini
On Mon, 15 Nov 2010, Kevin Wolf wrote: + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the Software), to deal + * in the Software without restriction, including without limitation the rights

Re: [Qemu-devel] [PATCH] make trace options use autoconfy names

2010-11-15 Thread Stefan Hajnoczi
On Sun, Nov 14, 2010 at 1:52 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/14/2010 02:38 PM, Andreas Färber wrote: - --trace-file=*) trace_file=$optarg + --enable-trace-file=*) trace_file=$optarg ;; but this should be --with-trace-file=... please. It is not being enabled, just set to

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

2010-11-15 Thread Anthony PERARD
On Mon, 15 Nov 2010, Alexander Graf wrote: On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default one tcg. We can specify more than one accelerator by

[Qemu-devel] [PATCHv5 06/15] Add get_fw_dev_path callback to IDE bus.

2010-11-15 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/ide/qdev.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index 88ff657..01a181b 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -24,9 +24,12 @@ /*

[Qemu-devel] [PATCHv5 07/15] Add get_dev_path callback for system bus.

2010-11-15 Thread Gleb Natapov
Prints out mmio or pio used to access child device. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/pci_host.c |2 ++ hw/sysbus.c | 30 ++ hw/sysbus.h |4 3 files changed, 36 insertions(+), 0 deletions(-) diff --git a/hw/pci_host.c

[Qemu-devel] [PATCHv5 13/15] Add bootindex for option roms.

2010-11-15 Thread Gleb Natapov
Extend -option-rom command to have additional parameter ,bootindex=. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/loader.c| 16 +++- hw/loader.h|8 hw/multiboot.c |3 ++- hw/ne2000.c|2 +- hw/nseries.c |4 ++-- hw/palm.c |6

[Qemu-devel] [PATCHv5 04/15] Add get_fw_dev_path callback to ISA bus in qdev.

2010-11-15 Thread Gleb Natapov
Use device ioports to create unique device path. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/isa-bus.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index c0ac7e9..c423c1b 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c

[Qemu-devel] [PATCHv5 01/15] Introduce fw_name field to DeviceInfo structure.

2010-11-15 Thread Gleb Natapov
Add fw_name to DeviceInfo to use in device path building. In contrast to name fw_name should refer to functionality device provides instead of particular device model like name does. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/fdc.c|1 + hw/ide/isa.c|1 + hw/ide/qdev.c

[Qemu-devel] [PATCHv5 10/15] Add get_dev_path callback for usb bus.

2010-11-15 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/usb-bus.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 256b881..8b4583c 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -5,11 +5,13 @@

[Qemu-devel] [PATCHv5 02/15] Introduce new BusInfo callback get_fw_dev_path.

2010-11-15 Thread Gleb Natapov
New get_fw_dev_path callback will be used for build device path usable by firmware in contrast to qdev qemu internal device path. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/qdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qdev.h b/hw/qdev.h index

[Qemu-devel] [PATCHv5 12/15] Change fw_cfg_add_file() to get full file path as a parameter.

2010-11-15 Thread Gleb Natapov
Change fw_cfg_add_file() to get full file path as a parameter instead of building one internally. Two reasons for that. First caller may need to know how file is named. Second this moves policy of file naming out from fw_cfg. Platform may want to use more then two levels of directories for

[Qemu-devel] [PATCHv5 15/15] Pass boot device list to firmware.

2010-11-15 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/fw_cfg.c | 15 +++ hw/fw_cfg.h |5 - sysemu.h|1 + vl.c| 49 + 4 files changed, 69 insertions(+), 1 deletions(-) diff --git a/hw/fw_cfg.c b/hw/fw_cfg.c

[Qemu-devel] [PATCHv5 00/15] boot order specification

2010-11-15 Thread Gleb Natapov
I am using open firmware naming scheme to specify device path names. In this version: fixed compilation problem, changed how device list is passed into firmware. Names look like this on pci machine: /p...@i0cf8/i...@1,1/dr...@1/d...@0 /p...@i0cf8/i...@1/f...@03f1/flo...@1

[Qemu-devel] [PATCHv5 08/15] Add get_fw_dev_path callback for pci bus.

2010-11-15 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/pci.c | 108 - 1 files changed, 85 insertions(+), 23 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 962886e..114b435 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -43,12 +43,14 @@

[Qemu-devel] [PATCHv5 03/15] Keep track of ISA ports ISA device is using in qdev.

2010-11-15 Thread Gleb Natapov
Store all io ports used by device in ISADevice structure. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 25 + hw/isa.h |4

[Qemu-devel] [PATCHv5 05/15] Store IDE bus id in IDEBus structure for easy access.

2010-11-15 Thread Gleb Natapov
Signed-off-by: Gleb Natapov g...@redhat.com --- hw/ide/cmd646.c |4 ++-- hw/ide/internal.h |3 ++- hw/ide/isa.c |2 +- hw/ide/piix.c |4 ++-- hw/ide/qdev.c |3 ++- hw/ide/via.c |4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCHv5 09/15] Record which USBDevice USBPort belongs too.

2010-11-15 Thread Gleb Natapov
Ports on root hub will have NULL here. This is needed to reconstruct path from device to its root hub to build device path. Signed-off-by: Gleb Natapov g...@redhat.com --- hw/usb-bus.c |3 ++- hw/usb-hub.c |2 +- hw/usb-musb.c |2 +- hw/usb-ohci.c |2 +- hw/usb-uhci.c |2 +-

[Qemu-devel] [PATCHv5 11/15] Add bootindex parameter to net/block/fd device

2010-11-15 Thread Gleb Natapov
If bootindex is specified on command line a string that describes device in firmware readable way is added into sorted list. Later this list will be passed into firmware to control boot order. Signed-off-by: Gleb Natapov g...@redhat.com --- block_int.h |4 +++- hw/e1000.c |4

[Qemu-devel] [PATCHv5 14/15] Add notifier that will be called when machine is fully created.

2010-11-15 Thread Gleb Natapov
Action that depends on fully initialized device model should register with this notifier chain. Signed-off-by: Gleb Natapov g...@redhat.com --- sysemu.h |2 ++ vl.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/sysemu.h b/sysemu.h index

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

2010-11-15 Thread Alexander Graf
On 15.11.2010, at 15:47, Anthony PERARD wrote: On Mon, 15 Nov 2010, Anthony PERARD wrote: On Mon, 15 Nov 2010, Alexander Graf wrote: On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This option gives the ability to switch one

Re: [Qemu-devel] [PATCH V6 04/15] Introduce -accel command option.

2010-11-15 Thread Anthony PERARD
On Mon, 15 Nov 2010, Anthony PERARD wrote: On Mon, 15 Nov 2010, Alexander Graf wrote: On 21.10.2010, at 19:36, anthony.per...@citrix.com wrote: From: Anthony PERARD anthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default

[Qemu-devel] [PATCH 1/2] virtio-9p: Use chroot to safely access files in passthrough model

2010-11-15 Thread M. Mohan Kumar
In passthrough security model, following symbolic links in the server side could result in accessing files outside guest's export path.This could happen under two conditions: 1) If a modified guest kernel is sending symbolic link as part of the file path and when resolving that symbolic link at

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
On 11/15/2010 08:52 AM, Juan Quintela wrote: Michael S. Tsirkinm...@redhat.com wrote: There's no reason for tap to run when VM is stopped. If we let it, it confuses the bridge on TX and corrupts DMA memory on RX. Signed-off-by: Michael S. Tsirkinm...@redhat.com once here, what

[Qemu-devel] [PATCH 2/2] virtio-9p: Use chroot interface in passthrough model

2010-11-15 Thread M. Mohan Kumar
Make use of chroot interfaces for passthrough security model to fix the vulnerability in following symbolic links. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/virtio-9p-local.c | 284 ++ 1 files changed, 218 insertions(+), 66

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 08:55:07AM -0600, Anthony Liguori wrote: On 11/15/2010 08:52 AM, Juan Quintela wrote: Michael S. Tsirkinm...@redhat.com wrote: There's no reason for tap to run when VM is stopped. If we let it, it confuses the bridge on TX and corrupts DMA memory on RX.

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 03:52:54PM +0100, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: There's no reason for tap to run when VM is stopped. If we let it, it confuses the bridge on TX and corrupts DMA memory on RX. Signed-off-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-15 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each one and use the first whose works. So, -accel xen,kvm,tcg which

Re: [Qemu-devel] [PATCH] make trace options use autoconfy names

2010-11-15 Thread Paolo Bonzini
On 11/15/2010 03:17 PM, Stefan Hajnoczi wrote: On Sun, Nov 14, 2010 at 1:52 PM, Paolo Bonzinipbonz...@redhat.com wrote: On 11/14/2010 02:38 PM, Andreas Färber wrote: - --trace-file=*) trace_file=$optarg + --enable-trace-file=*) trace_file=$optarg ;; but this should be --with-trace-file=...

Re: [Qemu-devel] Re: [PATCH] pc: disable the BOCHS BIOS panic port

2010-11-15 Thread Bernhard Kohl
Am 15.11.2010 11:09, schrieb ext Alexander Graf: On 15.11.2010, at 10:53, Bernhard Kohl wrote: Am 01.09.2010 16:44, schrieb Bernhard Kohl: We have an OS which writes to port 0x400 when probing for special hardware. This causes an exit of the VM. With SeaBIOS this port isn't used

[Qemu-devel] Re: [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-15 Thread M. Mohan Kumar
This patch introduce a fallback mechanism for old systems that do not support utimensat(). This fix build failure with following warnings: hw/virtio-9p-local.c: In function 'local_utimensat': hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat'

Re: [Qemu-devel] [PATCH 1/2] virtio-9p: Use chroot to safely access files in passthrough model

2010-11-15 Thread Stefan Hajnoczi
On Mon, Nov 15, 2010 at 2:52 PM, M. Mohan Kumar mo...@in.ibm.com wrote: In passthrough security model, following symbolic links in the server side could result in accessing files outside guest's export path.This could happen under two conditions: 1) If a modified guest kernel is sending

Re: [Qemu-devel] [PATCH] Introduce -accel command option.

2010-11-15 Thread Anthony Liguori
On 11/15/2010 09:45 AM, anthony.per...@citrix.com wrote: From: Anthony PERARDanthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a comma. QEMU will try each one and

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

2010-11-15 Thread Christian Brunner
Hi Stefan, thanks for your feedback. Yehuda and Sage have already committed some pathes to our git repository. What I'm not sure about is the rados_(de)initialization for multiple rbd images. I suspect that _deinitialize should only be called for the last rbd image. Yehuda and Sage know

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

2010-11-15 Thread Stefan Weil
Am 25.10.2010 18:54, schrieb Michael S. Tsirkin: On Mon, Oct 25, 2010 at 06:23:24PM +0200, Stefan Weil wrote: Am 25.10.2010 14:11, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: Am 13.10.2010 09:13, schrieb Markus Armbruster: Stefan

[Qemu-devel] Re: [PATCH] make-release: fix mtime for a wider range of git versions

2010-11-15 Thread Bernhard Kohl
Am 15.11.2010 12:48, schrieb Bernhard Kohl: With the latest git versions, e.g. 1.7.2.3, git still prints out the tag info in addition to the requested format. So let's simply fetch the first line from the output. In addition I use the --pretty option instead of --format which is not recognized

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

2010-11-15 Thread Yehuda Sadeh Weinraub
On Mon, Nov 15, 2010 at 9:04 AM, Christian Brunner c.m.brun...@gmail.com wrote: Hi Stefan, thanks for your feedback. Yehuda and Sage have already committed some pathes to our git repository. What I'm not sure about is the rados_(de)initialization for multiple rbd images. I suspect that

[Qemu-devel] [Bug 611142] Re: seabios should have native scsi support

2010-11-15 Thread Serge Hallyn
(Clearly this must be done upstream first, so marking Triaged for the Ubuntu task) ** Changed in: qemu-kvm (Ubuntu) Status: New = Triaged -- seabios should have native scsi support https://bugs.launchpad.net/bugs/611142 You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 241119] Re: usb_add of a Creative ZEN unrecognized in guest

2010-11-15 Thread Alexandrosg
Hi. I have a similar problem, with a simple JetFlash usb drive. After adding it with usb_add, info usb shows nothing and I start getting the following message in the console: husb: config #1 need -1 husb: 1 interfaces claimed for configuration 1 husb: grabbed usb device 1.3

[Qemu-devel] Re: [PATCH] pci: allow hotplug removal of cold-plugged devices

2010-11-15 Thread Cam Macdonell
On Sun, Nov 14, 2010 at 7:18 AM, Michael S. Tsirkin m...@redhat.com wrote: This patch fixes 5beb8ad503c88a76f2b8106c3b74b4ce485a60e1 which broke hotplug removal of cold plugged devices: - pass addition/removal state to hotplug callbacks - use that in piix and pcie This also fixes an assert

[Qemu-devel] [PATCH 0/3] v11: Threadlets: A generic task offloading framework

2010-11-15 Thread Arun R Bharadwaj
Hi, This is the v11 of the refactored patch-series to have a generic asynchronous task offloading framework (called threadlets) within qemu. I have run KVM autotest suite with this patch. This test suite ran successfully for the following tests: -connecthon -ebizzy

[Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-15 Thread Arun R Bharadwaj
From: Gautham R Shenoy gautham.she...@gmail.com This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The patch creates a global queue on-to which subsystems can queue their tasks to be executed asynchronously. The patch also provides API's that allow a

[Qemu-devel] [PATCH 2/3] Move threadlets infrastructure to qemu-threadlets.c

2010-11-15 Thread Arun R Bharadwaj
The reason for creating this generic infrastructure is so that other subsystems, such as virtio-9p could make use of it for offloading tasks that could block. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by:

[Qemu-devel] [PATCH 3/3] Add helper functions to enable virtio-9p make use of the threadlets

2010-11-15 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com infrastructure for offloading blocking tasks such as making posix calls on to the helper threads and handle the post_posix_operations() from the context of the iothread. This frees the vcpu thread to process any other guest operations while the processing of

[Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking)

2010-11-15 Thread Stefan Weil
This patch adds more printf format checking. Additional modifications were needed for this code change: * alpha-dis.c: The local definition of MAX conflicts with a previous definition from osdep.h, so add an #undef. * dis-asm.h: Add include for fprintf_function (qemu-common.h). The standard

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Mike Ryan
Anyone care to comment? On Wed, Nov 10, 2010 at 05:47:35PM -0800, Mike Ryan wrote: Add an option to specify the host interface to send multicast packets on when using a multicast socket for networking. The option takes the name of a host interface (e.g., eth0) and sets the IP_MULTICAST_IF

[Qemu-devel] [PATCH] target-sparc: Use fprintf_function (format checking)

2010-11-15 Thread Stefan Weil
This change was missing in commit 9a78eead0c74333a394c0f7bbfc4423ac746fcd5. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- target-sparc/cpu.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-sparc/cpu.h

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

2010-11-15 Thread Anthony Liguori
On 11/12/2010 10:54 AM, François Revol wrote: Le 12 nov. 2010 à 15:32, Anthony Liguori a écrit : I did try years ago, but at least the current wav driver really didn't like fifos back then. I recall trying for hours to get it pipe to ffmpeg or others without much luck. Also, this poses

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Anthony Liguori
On 11/15/2010 12:54 PM, Mike Ryan wrote: Anyone care to comment? I must admit, I don't understand the use-case well enough to really give an appropriate amount of review as to whether this is the best solution to the problem. Michael, do you have any thoughts? Regards, Anthony

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Mike Ryan
I'll clarify/elaborate a bit: When using a multicast socket, the OS chooses a default physical interface to send packets. The patch I've supplied allows the user to select the interface. Suppose you have a setup like so: BoxA --- BoxB --- BoxC You wish to run virtual machines on BoxB and BoxC

[Qemu-devel] How to detect a stopped guest os?

2010-11-15 Thread Wilhelm
Hello, I know, this is not the right place to ask, but I wasn't abled to find a users mailing list. The question: is there any qemu (monitor) command to detect if the guest os has stopped / poweroff? -- Wilhelm

[Qemu-devel] [PATCH] audio: Use GCC_FMT_ATTR (format checking)

2010-11-15 Thread Stefan Weil
Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- audio/audio_pt_int.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/audio/audio_pt_int.c b/audio/audio_pt_int.c index f15cc70..908c569 100644 --- a/audio/audio_pt_int.c +++

Re: [Qemu-devel] [PATCH] make trace options use autoconfy names

2010-11-15 Thread Andreas Färber
Am 15.11.2010 um 16:48 schrieb Paolo Bonzini: On 11/15/2010 03:17 PM, Stefan Hajnoczi wrote: On Sun, Nov 14, 2010 at 1:52 PM, Paolo Bonzinipbonz...@redhat.com wrote: On 11/14/2010 02:38 PM, Andreas Färber wrote: - --trace-file=*) trace_file=$optarg + --enable-trace-file=*)

Re: [Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking)

2010-11-15 Thread Andreas Färber
Am 15.11.2010 um 19:39 schrieb Stefan Weil: This patch adds more printf format checking. Additional modifications were needed for this code change: * alpha-dis.c: The local definition of MAX conflicts with a previous definition from osdep.h, so add an #undef. * dis-asm.h: Add include for

[Qemu-devel] [PATCH] darwin-user: Use GCC_FMT_ATTR (format checking)

2010-11-15 Thread Stefan Weil
The redundant forward declaration of qerror in machload.c is removed because it should be taken from qemu.h. Please note that this patch is untested because I have no matching environment to compile it. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de ---

[Qemu-devel] Re: [PATCH RESENT] msix: allow byte and word reading from mmio

2010-11-15 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 05:40:30PM +0100, Bernhard Kohl wrote: Am 15.11.2010 11:42, schrieb ext Michael S. Tsirkin: On Thu, Aug 19, 2010 at 02:56:51PM +0200, Bernhard Kohl wrote: It's legal that the guest reads a single byte or word from mmio. Interesting. The spec seems to say this:

[Qemu-devel] [PATCH 2/4] virtio: Convert fprintf() to error_report()

2010-11-15 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio.c | 35 ++- 1 files changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index a2a657e..849a60f 100644 --- a/hw/virtio.c +++ b/hw/virtio.c @@ -14,6 +14,7 @@

[Qemu-devel] [PATCH 0/4] virtio: Convert fprintf() to error_report()

2010-11-15 Thread Stefan Hajnoczi
The virtio hardware emulation code uses fprintf(stderr, ...) error messages. Improve things slightly by moving to error_report() so error messages will be printed to the monitor, if present. We want to handle device error states properly instead of bailing out with exit(1) but this series does

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
On 11/15/2010 02:26 PM, Michael S. Tsirkin wrote: Are there any system ones? There's one in qemu-char.c. Not sure it's easy to just say for the future that there can't be BHs that get delivered during vmstop. Can we just stop processing them? We ran into a lot of problems trying

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
On 11/15/2010 02:53 PM, Stefan Hajnoczi wrote: vhost has a solution for this: register a VMChangeStateHandler function that stops ioeventfd while vm_stop(0) is in effect. Then poll to see if there is work pending. I will add equivalent functionality to virtio-ioeventfd. I still think

Re: [Qemu-devel] [PATCH 1/3] Make paio subsystem use threadlets infrastructure

2010-11-15 Thread Anthony Liguori
On 11/15/2010 11:53 AM, Arun R Bharadwaj wrote: From: Gautham R Shenoygautham.she...@gmail.com This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The patch creates a global queue on-to which subsystems can queue their tasks to be executed asynchronously.

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Anthony Liguori
On 11/15/2010 01:52 PM, Mike Ryan wrote: I'll clarify/elaborate a bit: When using a multicast socket, the OS chooses a default physical interface to send packets. The patch I've supplied allows the user to select the interface. Suppose you have a setup like so: BoxA --- BoxB --- BoxC You

[Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 10:09:29AM -0600, Anthony Liguori wrote: On 11/15/2010 09:18 AM, Michael S. Tsirkin wrote: On Mon, Nov 15, 2010 at 08:55:07AM -0600, Anthony Liguori wrote: On 11/15/2010 08:52 AM, Juan Quintela wrote: Michael S. Tsirkinm...@redhat.com wrote: There's no reason for tap

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Stefan Hajnoczi
On Mon, Nov 15, 2010 at 4:09 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 11/15/2010 09:18 AM, Michael S. Tsirkin wrote: On Mon, Nov 15, 2010 at 08:55:07AM -0600, Anthony Liguori wrote: On 11/15/2010 08:52 AM, Juan Quintela wrote: Michael S. Tsirkinm...@redhat.com   wrote:

[Qemu-devel] [PATCH] configure: Add compiler option -Wmissing-format-attribute

2010-11-15 Thread Stefan Weil
With the previous patches, hopefully all functions with printf like arguments use gcc's format checking. This was tested with default build configuration on linux and windows hosts (including some cross compilations), so chances are good that there remain few (if any) functions without format

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Blue Swirl
2010/11/15 Gleb Natapov g...@redhat.com: On Sun, Nov 14, 2010 at 10:50:13PM +, Blue Swirl wrote: On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov g...@redhat.com wrote: Signed-off-by: Gleb Natapov g...@redhat.com ---  hw/fw_cfg.c |   14 ++  hw/fw_cfg.h |    4 +++-  

Re: [Qemu-devel] [PATCH] *-dis: Replace fprintf_ftype by fprintf_function (format checking)

2010-11-15 Thread Stefan Weil
Am 15.11.2010 21:01, schrieb Andreas Färber: Am 15.11.2010 um 19:39 schrieb Stefan Weil: This patch adds more printf format checking. Additional modifications were needed for this code change: * alpha-dis.c: The local definition of MAX conflicts with a previous definition from osdep.h, so

[Qemu-devel] [PATCH] trace: Use fprintf_function (format checking)

2010-11-15 Thread Stefan Weil
fprintf_function adds format checking with GCC_FMT_ATTR. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- simpletrace.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/simpletrace.h b/simpletrace.h index 72614ec..2f44ed3 100644

[Qemu-devel] Re: [PATCH] configure: Add compiler option -Wmissing-format-attribute

2010-11-15 Thread Stefan Weil
Am 15.11.2010 21:22, schrieb Stefan Weil: With the previous patches, hopefully all functions with printf like arguments use gcc's format checking. This was tested with default build configuration on linux and windows hosts (including some cross compilations), so chances are good that there

  1   2   >