Last chance to object to the following patches :)
The following changes since commit e927d48722fdcba50f82d653c5a1927752483054:
pci: allow hotplug removal of cold-plugged devices (2010-11-16 14:55:23 +0200)
are available in the git repository at:
On Mon, Nov 22, 2010 at 09:37:07AM +0200, Gleb Natapov wrote:
It's probably required to make them stable anyway.
Why?
To avoid bus renumbering on reboot after you add a pci-to-pci bridge.
Why should qemu care?
Stable bus numbering is a feature *users* care about, because
some
Am 21.11.2010 03:19, schrieb Alexander Graf:
On 19.11.2010, at 14:46, Kevin Wolf wrote:
Am 19.11.2010 14:08, schrieb Alexander Graf:
On 19.11.2010, at 10:15, Kevin Wolf wrote:
Am 18.11.2010 19:43, schrieb Alexander Graf:
Then I believe that core.c is now a mixture of some generic ATA
On 11/19/2010 07:28 PM, Christoph Hellwig wrote:
On Thu, Nov 18, 2010 at 03:44:34PM +0100, Hannes Reinecke wrote:
qemu_malloc doesn't check for zero argument, so we need to
check ourselves.
I'm not sure if it's a that good idea to remove the implicit
-sg != NULL assumption. Any reason you
On 11/21/10 03:04, Alexander Graf wrote:
On 20.11.2010, at 00:06, Gerd Hoffmann wrote:
The ahci map_page() function checks whenever it got a full page
mapped. This is wrong. The data structures are much smaller:
command list is 1k and fis is 256 bytes. Checking whenever we can
access that
Am 21.11.2010 23:17, schrieb ronnie sahlberg:
List,
Please find attached a gzipped patch against master that adds support of
iSCSI.
It is sent in gz format because of its uncompressed size, 100kb.
I think there's something missing in your mail. :-)
Anyway, I got the code from the KVM
Am 21.11.2010 16:22, schrieb Anthony Liguori:
On 11/08/2010 01:02 PM, Marcelo Tosatti wrote:
Following patchset fixes block migration corruption issues
Applied all. Thanks.
This was the old version. Anyway, I'll include a diff between v1 and v2
in my next pull request.
Kevin
On 11/21/10 20:16, Michael S. Tsirkin wrote:
Stop running devices on vmstop, so that VM does not interact with
outside world at that time.
Whitelist system handlers which run even when VM is stopped.
These are specific handlers like monitor, gdbstub, migration.
I'm not really sure about ui:
We should announce and support the block device characterics page
only on block devices, not on CDROMs. And the VPD page 0x83 has
an off-by-one error.
Signed-off-by: Hannes Reinecke h...@suse.de
Acked-by: Christoph Hellwig h...@lst.de
---
hw/scsi-disk.c | 18 ++
1 files
The SCSI parallel interface has a limit of 8 devices, but
not the SCSI stack in general. So we should be removing the
hard-coded limit and use MAX_SCSI_DEVS instead.
And we only need to scan those devices which are allocated
by the bus.
Signed-off-by: Hannes Reinecke h...@suse.de
Acked-by:
The is the second version of the megasas patchset; changes are:
v1 - v2:
- Include suggestions (and acked-by) from Christoph Hellwig
- Updated patch description as requested by Gerd Hoffman
- Use generic iov_size() implementation
- Drop old patches
- Make SCSI HBA configurable
This patchset can
Traditionally, the linux stack is using SCSI status codes
which are shifted by one as compared to those defined in SAM.
A SCSI emulation should naturally return the SAM defined codes,
not the linux ones.
So to avoid any confusion this patch modifies the existing
definitions to match those found
The 'sense' field in the HBA status structure is misnamed, as it
actually carries the SCSI status. Rename it.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/lsi53c895a.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/lsi53c895a.c
The current sense handling in scsi-bus is only used by the
scsi-disk driver; the scsi-generic driver is using its own.
So we should move the current sense handling into the
scsi-disk driver.
Signed-off-by: Hannes Reinecke h...@suse.de
Acked-by: Christoph Hellwig h...@lst.de
---
hw/scsi-bus.c |
Rather than have the iovec part of the structure with a fixed size
of '1' we should be allocating it dynamically. This will allow us
to pass in SGLs directly.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/scsi-disk.c | 102 +---
1 files
On Mon, Nov 22, 2010 at 10:57:34AM +0100, Gerd Hoffmann wrote:
On 11/21/10 20:16, Michael S. Tsirkin wrote:
Stop running devices on vmstop, so that VM does not interact with
outside world at that time.
Whitelist system handlers which run even when VM is stopped.
These are specific handlers
The 'bus' argument is now pointless, as we already pass the
request itself and the bus can be derived from it.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/esp.c |5 ++---
hw/lsi53c895a.c |5 ++---
hw/scsi-bus.c |3 +--
hw/scsi-disk.c|8
I understand why you're adding this but this is one of those horrible
abuses of qdev that we really need to avoid.
There are two valid reasons why hotplug is not possible:
1) Hotplugging is not supported by the *slot*. This is something that
needs to be exposes through ACPI. This is not a qdev
We parse the CDB twice, which is completely unnecessary.
Signed-off-by: Hannes Reinecke h...@suse.de
Acked-by: Christoph Hellwig h...@lst.de
---
hw/scsi-disk.c | 74
1 files changed, 21 insertions(+), 53 deletions(-)
diff --git
The SCSI spec has a quite detailed list of sense codes available.
It even mandates the use of specific ones for some failure cases.
The current implementation just has one type of 'generic' error
which is actually a violation of the spec in certain cases.
This patch introduces various predefined
The get_sense callback copies existing sense information into
the provided buffer. This is required if sense information
should be transferred together with the command response.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/scsi-disk.c|9 +
hw/scsi-generic.c | 17
Add callback to create a request with a predefined iovec.
This is required for drivers which can use the iovec
of a command directly.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/scsi-disk.c| 25 +
hw/scsi-generic.c | 44
On Mon, Nov 22, 2010 at 07:43:37PM +0900, Isaku Yamahata wrote:
On Mon, Nov 22, 2010 at 09:54:02AM +0200, Michael S. Tsirkin wrote:
On Fri, Nov 19, 2010 at 06:55:57PM +0900, Isaku Yamahata wrote:
Here is v2. I updated the comments, and dropped the pci qdev reset patch.
Patch
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/scsi-disk.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-disk.c
Currently the SCSIRequest structure is abstracted away and
cannot accessed directly from the driver. This requires
the handler to do a lookup on an abstract 'tag' which
identifies the SCSIRequest structure.
With this patch the SCSIRequest structure is exposed to
the driver. This allows use to use
On 11/22/2010 11:15 AM, Hannes Reinecke wrote:
The is the second version of the megasas patchset; changes are:
v1 - v2:
- Include suggestions (and acked-by) from Christoph Hellwig
- Updated patch description as requested by Gerd Hoffman
- Use generic iov_size() implementation
- Drop old
On 11/22/2010 11:15 AM, Hannes Reinecke wrote:
This patch introduces configuration variables
CONFIG_SCSI_LSI
CONFIG_SCSI_MEGASAS
and renames the existing CONFIG_ESP to CONFIG_SCSI_ESP.
With this the available SCSI HBAs can be configured for each
target configuration instead of compiling it in
On Mon, Nov 22, 2010 at 09:54:02AM +0200, Michael S. Tsirkin wrote:
On Fri, Nov 19, 2010 at 06:55:57PM +0900, Isaku Yamahata wrote:
Here is v2. I updated the comments, and dropped the pci qdev reset patch.
Patch description:
The goal of this patch series is to implement secondary bus
On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
Instead of just a debug printf that almost no one compiles in shouldn't
we reject the incorrect commands?
On 11/21/10 16:33, Avi Kivity wrote:
+{ 1280, 768, 16 , 0x175},
+{ 1280, 768, 24 , 0x176},
+{ 1280, 768, 32 , 0x177},
Acked-by: Gerd Hoffmann kra...@redhat.com
cheers,
Gerd
Looks good.
@@ -95,14 +95,30 @@ static SCSIRequest *scsi_new_request(SCSIDevice *d,
uint32_t tag,
return req;
}
+static SCSIRequest *scsi_new_request_iovec(SCSIDevice *d, uint32_t tag,
+uint32_t lun, struct iovec *iov, int iov_num)
+{
+SCSIRequest *req;
+SCSIDiskReq *r;
+
On 11/22/2010 12:20 PM, Christoph Hellwig wrote:
On Thu, Nov 18, 2010 at 03:47:32PM +0100, Hannes Reinecke wrote:
scsi_req_parse() already provides for a data direction setting,
so we should be using it to check for correct direction.
Instead of just a debug printf that almost no one
On Mon, Nov 22, 2010 at 11:15:35AM +0100, Hannes Reinecke wrote:
Currently the SCSIRequest structure is abstracted away and
cannot accessed directly from the driver. This requires
the handler to do a lookup on an abstract 'tag' which
identifies the SCSIRequest structure.
With this patch the
Am 19.11.2010 17:30, schrieb jes.soren...@redhat.com:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
You're compiling the nbd block driver out here. This is certainly not
what you were attempting. (However, it's the only way to make it work,
On Fri, 19 Nov 2010 19:50:10 -0600
Anthony Liguori anth...@codemonkey.ws wrote:
On 11/11/2010 08:03 AM, Luiz Capitulino wrote:
Functions register_ioport_read() and register_ioport_write() are almost
identical, the only difference is that they write to different arrays.
Introduce
On Mon, Nov 22, 2010 at 10:16:57AM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at 09:37:07AM +0200, Gleb Natapov wrote:
It's probably required to make them stable anyway.
Why?
To avoid bus renumbering on reboot after you add a pci-to-pci bridge.
Why should
On Mon, Nov 22, 2010 at 11:17:10AM +0100, Gerd Hoffmann wrote:
An ideal interface would explicitly allow a user to mark a series of PCI
slots as no supporting hotplug. It would be convenient in order to
ensure that your virtio-net wasn't accidentally ejected by a click-happy
Windows user.
On 11/22/2010 08:38 AM, Kevin Wolf wrote:
You're free to dislike NBD as much as you want. Just compiling it out
unconditionally and calling it a cleanup is a bit too much. ;-)
A configure option for disabling NBD sounds reasonable, though I'm not
sure what you're trying to achieve with it. It
On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at 04:50:29PM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at 03:04:51PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at 10:16:57AM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at
On 11/22/10 15:54, Anthony Liguori wrote:
On 11/22/2010 08:38 AM, Kevin Wolf wrote:
You're free to dislike NBD as much as you want. Just compiling it out
unconditionally and calling it a cleanup is a bit too much. ;-)
A configure option for disabling NBD sounds reasonable, though I'm not
On Mon, Nov 22, 2010 at 04:56:16PM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at 04:50:29PM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at 03:04:51PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at
On 11/22/10 11:15, Hannes Reinecke wrote:
This patch introduces configuration variables
CONFIG_SCSI_LSI
CONFIG_SCSI_MEGASAS
and renames the existing CONFIG_ESP to CONFIG_SCSI_ESP.
With this the available SCSI HBAs can be configured for each
target configuration instead of compiling it in
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
On 11/22/10 15:54, Anthony Liguori wrote:
On 11/22/2010 08:38 AM, Kevin Wolf wrote:
You're free to dislike NBD as much as you want. Just compiling it out
unconditionally and calling it a cleanup is a bit too much. ;-)
A configure option
On 11/22/10 16:08, Anthony Liguori wrote:
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
On 11/22/10 15:54, Anthony Liguori wrote:
Using block format whitelisting should be enough to disable nbd. I
don't see a need for an explicit --disable-nbd option.
Right, the right solution is
On 11/22/2010 09:10 AM, Jes Sorensen wrote:
On 11/22/10 16:08, Anthony Liguori wrote:
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
On 11/22/10 15:54, Anthony Liguori wrote:
Using block format whitelisting should be enough to disable nbd. I
don't see a need for an explicit
Thanks. I will try to reproduce this as soon as I can (which will be next
week.) IF anyone else can get to it sooner, to confirm that the proposed
fix works, by all means please comment the result here so the fix can
finally get cleared.
--
KVM segmentation fault, using SCSI+writeback and
On 11/22/10 16:20, Anthony Liguori wrote:
On 11/22/2010 09:10 AM, Jes Sorensen wrote:
On 11/22/10 16:08, Anthony Liguori wrote:
On 11/22/2010 08:58 AM, Jes Sorensen wrote:
Right, the right solution is probably to create a block driver list
argument for configure, similar to what we
On Mon, Nov 22, 2010 at 04:58:11PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at 04:56:16PM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at 04:50:29PM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at
On Mon, Nov 22, 2010 at 06:41:28PM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at 04:58:11PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at 04:56:16PM +0200, Michael S. Tsirkin wrote:
On Mon, Nov 22, 2010 at 04:52:32PM +0200, Gleb Natapov wrote:
On Mon, Nov 22, 2010 at
Michael, this patch implements the feature with a bind address instead
of a bind interface. It should address the cross-platform issues that
were raised.
Others: any comments?
On Wed, Nov 17, 2010 at 05:16:26PM -0800, Mike Ryan wrote:
Add an option to specify the host IP to send multicast
Move the last found TB to the head of the list so it will be found more
quickly next time it will be looked for.
Signed-off-by: Kirill Batuzov batuz...@ispras.ru
Signed-off-by: Pavel Yushchenko p...@ispras.ru
---
Hello. This patch gives significant boost to a used by us rather rich
(for
On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke h...@suse.de wrote:
Looks good. If you send out another version of the patchset you might
like to fix this nitpick:
+ if (!r-io_header.iovec_count) {
+ if (r-buflen != r-req.cmd.xfer) {
+ if (r-buf != NULL)
+
On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke h...@suse.de wrote:
The 'bus' argument is now pointless, as we already pass the
request itself and the bus can be derived from it.
Signed-off-by: Hannes Reinecke h...@suse.de
---
hw/esp.c | 5 ++---
hw/lsi53c895a.c | 5
On Mon, Nov 22, 2010 at 10:15 AM, Hannes Reinecke h...@suse.de wrote:
+static int scsi_get_sense(SCSIRequest *req, uint8_t *outbuf, int len)
+{
+ SCSIGenericState *s = DO_UPCAST(SCSIGenericState, qdev, req-dev);
+ int size = SCSI_SENSE_BUF_SIZE;
If there is no error we return
On 22.11.2010, at 16:05, Jes Sorensen wrote:
On 11/22/10 11:15, Hannes Reinecke wrote:
This patch introduces configuration variables
CONFIG_SCSI_LSI
CONFIG_SCSI_MEGASAS
and renames the existing CONFIG_ESP to CONFIG_SCSI_ESP.
With this the available SCSI HBAs can be configured for each
Linux seems to maintain the length of the original args, even when the new
args are shorter and NULL-terminated, so the trailing whitespace in ps(1)
output is probably unavoidable. I've seen the same result with other daemons
that overwrite argv.
Keeps the call to prctl(), since some tools get
* Juan Quintela (quint...@redhat.com) wrote:
Please send in any agenda items you are interested in covering.
usb-ccid
On 11/22/2010 03:45 PM, Chris Wright wrote:
* Juan Quintela (quint...@redhat.com) wrote:
Please send in any agenda items you are interested in covering.
usb-ccid
aka external device emulation in qemu.
This is an easy topic to discuss in an abstract sense and I'm sure
everyone
On Mon, Nov 22, 2010 at 07:43:37PM +0900, Isaku Yamahata wrote:
On Mon, Nov 22, 2010 at 09:54:02AM +0200, Michael S. Tsirkin wrote:
On Fri, Nov 19, 2010 at 06:55:57PM +0900, Isaku Yamahata wrote:
Here is v2. I updated the comments, and dropped the pci qdev reset patch.
Patch
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching
them to respond to these signals, introduce monitor commands that stop and start
individual vcpus.
The purpose of these commands are to implement CPU hard limits using an external
tool that watches the CPU consumption
On 11/22/2010 03:45 PM, Chris Wright wrote:
* Juan Quintela (quint...@redhat.com) wrote:
Please send in any agenda items you are interested in covering.
usb-ccid
- vcpu hard limits
Regards,
Anthony Liguori
--
To unsubscribe from this list: send the line unsubscribe kvm in
On 11/22/2010 05:00 PM, Anthony Liguori wrote:
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching
them to respond to these signals, introduce monitor commands that stop and start
individual vcpus.
The purpose of these commands are to implement CPU hard limits using an
* Anthony Liguori (aligu...@us.ibm.com) wrote:
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching
them to respond to these signals, introduce monitor commands that stop and
start
individual vcpus.
In the past SIGSTOP has introduced time skew. Have you verified
The usermode version of qemu_ld doesn't used mem_index,
leading to set-but-not-used warnings.
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/ia64/tcg-target.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index
Use ld4 not ld8 for reading the tlb of 32-bit targets.
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/ia64/tcg-target.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 62f0804..da81f1b 100644
---
Fix compilation error when GUEST_BASE is not defined.
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/ia64/tcg-target.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index a0f3877..80c6950 100644
---
Three compilation errors, one tcg_abort, two code-generation errors, and
one warning fix. Though for the most part I'm using --disable-werror
until the code base is generally fixed up for gcc 4.6.
I don't know if Aurelien is still active or not, but I've cc'd him anyway.
Hopefully the ia64 bits
From: Richard Henderson r...@redhat.com
Rename the members of target_ucontext so that they don't conflict
with possible host macros for ucontext members. This has already
been done for the other targets.
Signed-off-by: Richard Henderson r...@twiddle.net
---
linux-user/signal.c | 18
The port was not properly merged following
86feb1c860dc38e9c89e787c5210e8191800385e
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/ia64/tcg-target.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index
From: Richard Henderson r...@redhat.com
The arguments to tcg_gen_helper32 for these functions were not
updated correctly in rev 2bece2c88331f024a46527634e3dd91c71d22141.
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/tcg-op.h |4 ++--
1 files changed, 2 insertions(+), 2
A typo in the usermode address calculation path; R3 used where R2 needed.
Signed-off-by: Richard Henderson r...@twiddle.net
---
tcg/ia64/tcg-target.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index da81f1b..57d0bcc
On 11/22/2010 05:04 PM, Chris Wright wrote:
* Anthony Liguori (aligu...@us.ibm.com) wrote:
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching
them to respond to these signals, introduce monitor commands that stop and start
individual vcpus.
In the past
* Anthony Liguori (aligu...@linux.vnet.ibm.com) wrote:
On 11/22/2010 05:04 PM, Chris Wright wrote:
* Anthony Liguori (aligu...@us.ibm.com) wrote:
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of
teaching
them to respond to these signals, introduce monitor commands that
On 11/22/2010 05:56 PM, Chris Wright wrote:
* Anthony Liguori (aligu...@linux.vnet.ibm.com) wrote:
On 11/22/2010 05:04 PM, Chris Wright wrote:
* Anthony Liguori (aligu...@us.ibm.com) wrote:
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching
them to
Attached the patch for qemu-kvm 0.13. This patch is tested on natty with
qemu-kvm 0.13.0+noroms-0ubuntu7 and the German and NEO2 keyboard layout.
** Patch added: caps-lock-key-up-event.patch
Public bug reported:
Problem
During compile with qemu-kvm-0.13.0, can't successfully make through with error:
#make make install
kvm-all.o: In function `kvm_run':
/home/liheyuan/code/qemu-kvm-0.13.0/qemu-kvm.c:675: undefined reference to
`kvm_handle_internal_error'
collect2: ld returned 1 exit
The args_type of migrate_set_speed in qmp-commands.hx is wrong.
When we set migrate speed by json, qemu will be core dumped.
Signed-off-by: Wen Congyang
---
qmp-commands.hx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index
On 11/23/2010 01:00 AM, Anthony Liguori wrote:
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching
them to respond to these signals, introduce monitor commands that stop and start
individual vcpus.
The purpose of these commands are to implement CPU hard limits using an
On 11/23/2010 01:04 AM, Chris Wright wrote:
* Anthony Liguori (aligu...@us.ibm.com) wrote:
qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching
them to respond to these signals, introduce monitor commands that stop and
start
individual vcpus.
In the past SIGSTOP
80 matches
Mail list logo
