[Qemu-devel] [PATCH uq/master 2/2] MCE, unpoison memory address across reboot

2011-01-13 Thread Huang Ying
In Linux kernel HWPoison processing implementation, the virtual address in processes mapping the error physical memory page is marked as HWPoison. So that, the further accessing to the virtual address will kill corresponding processes with SIGBUS. If the error physical memory page is used by a

[Qemu-devel] [PATCH uq/master 1/2] Add qemu_ram_remap

2011-01-13 Thread Huang Ying
qemu_ram_remap() unmaps the specified RAM pages, then re-maps these pages again. This is used by KVM HWPoison support to clear HWPoisoned page tables across guest rebooting, so that a new page may be allocated later to recover the memory error. Signed-off-by: Huang Ying ying.hu...@intel.com ---

Re: [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-13 Thread Gerd Hoffmann
Hi, There isn't much spice-specific stuff in there. The clipboard bits for example should work unmodified with vnc, one would just have to hack up a vnc extention to tunnel the agent protocol over vnc (and vnc client support of course). VNC already supports copy/paste as part of the

Re: [Qemu-devel] tcg shift ops and magnitudes larger than register size

2011-01-13 Thread Edgar E. Iglesias
On Wed, Jan 12, 2011 at 08:13:45PM -0500, Mike Frysinger wrote: are there any rules with the tcg sar/shl/shr ops and their magnitudes ? such as magnitudes cannot be larger than the register size ? Yes, the result is undefined in those cases. i have a 32bit register with the value of

[Qemu-devel] Re: [PATCH v2] Avoid divide by zero when there is no block device to migrate

2011-01-13 Thread Kevin Wolf
Am 12.01.2011 14:41, schrieb Pierre Riteau: When block migration is requested and no read-write block device is present, a divide by zero exception is triggered because total_sector_sum equals zero. Signed-off-by: Pierre Riteau pierre.rit...@irisa.fr --- This v2 fixes a line that was

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-13 Thread Gerd Hoffmann
Hi, The VDAgentMouseState messages have one problem: They send the pointer position as-is, which introduces a dependency on the screen size. Yeah, if we could get rid of that, that would be great. We could even introduce a new mouse message type to the existing spice vdagent protocol and

Re: [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit

2011-01-13 Thread Fabien Chouteau
On 01/04/2011 11:27 AM, Fabien Chouteau wrote: On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet. Signed-off-by: Fabien Chouteauchout...@adacore.com --- gdbstub.c |4 1 files changed, 4 insertions(+), 0

Re: [Spice-devel] [Qemu-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-13 Thread Gerd Hoffmann
Hi, The VDAgentMouseState messages have one problem: They send the pointer position as-is, which introduces a dependency on the screen size. Yeah, if we could get rid of that, that would be great. We could even introduce a new mouse message type to the existing spice vdagent protocol and

[Qemu-devel] Re: [PATCH uq/master 2/2] MCE, unpoison memory address across reboot

2011-01-13 Thread Jan Kiszka
Am 13.01.2011 09:34, Huang Ying wrote: In Linux kernel HWPoison processing implementation, the virtual address in processes mapping the error physical memory page is marked as HWPoison. So that, the further accessing to the virtual address will kill corresponding processes with SIGBUS. If

Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings

2011-01-13 Thread Isaku Yamahata
How about creating stub functions instead of #ifdefs? something like pc-stubs.c #ifndef CONFIG_VMWARE_VGA pci_vmsvga_init() { error ... } #endif #ifndef CONFIG_... ... On Wed, Jan 12, 2011 at 11:34:29PM -0700, David Ahern wrote: David Ahern (8): fix 'no such file' error from

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-13 Thread Michal Suchanek
On 13 January 2011 00:34, Mateusz Loskot mate...@loskot.net wrote: On 12/01/11 17:15, Mateusz Loskot wrote: On 12/01/11 16:48, Michal Suchanek wrote: On 12 January 2011 16:21, Mateusz Loskotmate...@loskot.net  wrote: Thinking of future, could anyone estimate when it will be possible to boot

[Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Gerd Hoffmann
Hi, Just throwing a quick writeup into the ring to kickstart the design discussion ;) cheers, Gerd #ifndef __QEMU_PVTABLET__ #define __QEMU_PVTABLET__ 1 /* * qemu patavirtual tablet interface */ #include inttypes.h /* our virtio-serial channel */ #define QEMU_PVTABLET_NAME

[Qemu-devel] Re: [Spice-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-13 Thread Tiziano Müller
Am Mittwoch, den 12.01.2011, 17:12 +0100 schrieb Gerd Hoffmann: Hi folks, Looks like the spicevmc patch kicked the guest qagent discussion, so lets start with this, although it isn't related much to the agent issue itself ... The spicevmc chardev just pipes data from a chardev user

Re: [Qemu-devel] [PATCHv1] slirp: Use strcasecmp() to check tftp mode, tsize

2011-01-13 Thread Edgar E. Iglesias
On Wed, Jan 12, 2011 at 03:57:18PM +0200, Sergei Gavrikov wrote: From: Sergei Gavrikov sergei.gavri...@gmail.com According to RFC 1350 (TFTP Revision 2) the mode field can contain any combination of upper and lower case; also RFC 2349 propagates that the transfer size option (tsize) is case

[Qemu-devel] Re: [Spice-devel] spicevmv chardev, guest agents and paravirtual mouse

2011-01-13 Thread Gerd Hoffmann
Hi, (4) termial forwarding. Just an idea right now. Nowdays that the spice client side moves to gtk it would be easy to embed a termial widget, therby allowing easy access to the serial console using something like this: -chardev spicevmc,id=console,type=terminal

[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Stefan Hajnoczi
Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the windowing system to process input events and handle multihead. Why does a pv tablet tie itself to a display channel? What about mouse

Re: [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit

2011-01-13 Thread Edgar E. Iglesias
On Thu, Jan 13, 2011 at 10:24:50AM +0100, Fabien Chouteau wrote: On 01/04/2011 11:27 AM, Fabien Chouteau wrote: On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet. Signed-off-by: Fabien Chouteauchout...@adacore.com ---

[Qemu-devel] Re: [PATCH uq/master 2/2] MCE, unpoison memory address across reboot

2011-01-13 Thread Jan Kiszka
Am 13.01.2011 09:34, Huang Ying wrote: In Linux kernel HWPoison processing implementation, the virtual address in processes mapping the error physical memory page is marked as HWPoison. So that, the further accessing to the virtual address will kill corresponding processes with SIGBUS. If

Re: [Qemu-devel] [PATCH] Close Gdb stub connection in gdb_exit

2011-01-13 Thread Fabien Chouteau
On 01/13/2011 12:01 PM, Edgar E. Iglesias wrote: On Thu, Jan 13, 2011 at 10:24:50AM +0100, Fabien Chouteau wrote: On 01/04/2011 11:27 AM, Fabien Chouteau wrote: On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet.

[Qemu-devel] [PATCH v2] gdbstub: Close connection in gdb_exit

2011-01-13 Thread Fabien Chouteau
On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet. Version 2: Fix linux-user build error. Signed-off-by: Fabien Chouteau chout...@adacore.com --- gdbstub.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-)

[Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the windowing system to process input events and handle multihead. Why does a pv tablet tie

Re: [Qemu-devel] [PATCH v2 1/4] pci: allow devices being tagged as not hotpluggable.

2011-01-13 Thread Gerd Hoffmann
@@ -1620,6 +1620,11 @@ static int pci_qdev_init(DeviceState *qdev, DeviceInfo *base) info-is_bridge); if (pci_dev == NULL) return -1; +if (qdev-hotplugged info-no_hotplug) { +qerror_report(QERR_DEVICE_NO_HOTPLUG,

[Qemu-devel] [PATCH 00/12] Threadlets Infrastructure.

2011-01-13 Thread Arun R Bharadwaj
Hi, This series implements threadlets infrastructure: Changelog: * Changed the name aio_thread to handle_work. * Corrected the usage of aiocb-ret which has to be accessed under aiocb_mutex. * Merged the patche which add dequeue_work with the patch which removes the unused active field in

[Qemu-devel] [PATCH 02/12] Introduce work concept in posix-aio-compat.c

2011-01-13 Thread Arun R Bharadwaj
This patch introduces work concept by introducing the ThreadletWork structure. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- posix-aio-compat.c | 20 ++-- 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index

[Qemu-devel] [PATCH 01/12] Add aiocb_mutex and aiocb_completion.

2011-01-13 Thread Arun R Bharadwaj
This patch adds the aiocb_mutex to protect aiocb. This patch also removes the infinite loop present in paio_cancel. Since there can only be one cancellation at a time, we need to introduce a condition variable. For this, we need a global aiocb_completion condition variable. This patch also adds

[Qemu-devel] [PATCH 03/12] Add callback function to ThreadletWork structure.

2011-01-13 Thread Arun R Bharadwaj
This patch adds the callback function to the ThreadletWork structure and moves aio handler as a callback function. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- posix-aio-compat.c | 89 +--- 1 files changed, 50 insertions(+), 39

Re: [Qemu-devel] [PATCH v2 2/4] piix: tag as not hotpluggable.

2011-01-13 Thread Gerd Hoffmann
Hi, +.no_hotplug = 1, What about piix3-usb-uhci friends? Hmm. Good question. UHCI controllers are hotpluggable. But of course it isn't when it is a function of the chipset because pci can hotplug slots only. Guess the best way to handle this for now is to just disable

[Qemu-devel] [PATCH 04/12] Add ThreadletQueue.

2011-01-13 Thread Arun R Bharadwaj
This patch adds a global queue of type ThreadletQueue and removes the earlier usage of request_list queue. We want to create the thread on the first submit. Hence we need to track whether the globalqueue is initialized or not. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH 07/12] Remove thread_create routine.

2011-01-13 Thread Arun R Bharadwaj
Remove thread_create and use qemu_thread_create instead. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- posix-aio-compat.c | 29 ++--- 1 files changed, 2 insertions(+), 27 deletions(-) diff --git a/posix-aio-compat.c b/posix-aio-compat.c index

[Qemu-devel] [PATCH 05/12] Threadlet: Add submit_work threadlet API.

2011-01-13 Thread Arun R Bharadwaj
This patch adds submit work threadlet API and shows how the qemu_paio_submit changes to submit_work. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- posix-aio-compat.c | 33 ++--- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH 06/12] Threadlet: Add dequeue_work threadlet API and remove active field.

2011-01-13 Thread Arun R Bharadwaj
This patch adds dequeue_work threadlet API and shows how the paio_cancel changes to dequeue_work. The active field in the qemu_aiocb structure is now useless. Remove it. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- posix-aio-compat.c | 38 --

[Qemu-devel] [PATCH 10/12] Move threadlet code to qemu-threadlets.c

2011-01-13 Thread Arun R Bharadwaj
This patch moves the threadlet queue API code to qemu-threadlets.c where these APIs can be used by other subsystems. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- Makefile.objs |1 posix-aio-compat.c | 144

[Qemu-devel] [PATCH 08/12] Threadlet: Add aio_signal_handler threadlet API

2011-01-13 Thread Arun R Bharadwaj
This patch adds aio_signal_handler threadlet API. Earler posix-aio-compat.c had its own signal handler code. Now abstract this, in the later patch it is moved to a generic code so that it can be used by other subsystems. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH 11/12] Threadlets: Add functionality to create private queues.

2011-01-13 Thread Arun R Bharadwaj
This patch allows subsystems to create their own private queues with associated pools of threads. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- qemu-threadlets.c | 75 ++--- qemu-threadlets.h |4 +++ 2 files changed, 58

[Qemu-devel] [PATCH 09/12] Remove all instances of CONFIG_THREAD

2011-01-13 Thread Arun R Bharadwaj
Remove all instances of CONFIG_THREAD, which is not used anymore. Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com --- configure |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure b/configure index a079a49..addf733 100755 --- a/configure +++ b/configure @@

[Qemu-devel] Re: [PATCH] softfloat: fix floatx80_is_{quiet, signaling}_nan()

2011-01-13 Thread Peter Maydell
On 13 January 2011 01:31, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Jan 12, 2011 at 03:05:10PM -0600, Peter Maydell wrote: Actually, will   return ((a.high 0x7fff) == 0x7fff) (a.low = LIT64(0x4000)); do? Untested but I think it will do the right thing. I'm not sure

[Qemu-devel] [PATCH 12/12] Threadlets: Add documentation

2011-01-13 Thread Arun R Bharadwaj
Signed-off-by: Arun R Bharadwaj a...@linux.vnet.ibm.com Signed-off-by: Gautham R Shenoy gautham.she...@gmail.com --- docs/async-support.txt | 141 1 files changed, 141 insertions(+), 0 deletions(-) create mode 100644 docs/async-support.txt diff

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-13 Thread Mateusz Loskot
On 13/01/11 10:13, Michal Suchanek wrote: On 13 January 2011 00:34, Mateusz Loskotmate...@loskot.net wrote: On 12/01/11 17:15, Mateusz Loskot wrote: On 12/01/11 16:48, Michal Suchanek wrote: On 12 January 2011 16:21, Mateusz Loskotmate...@loskot.netwrote: Thinking of future, could

[Qemu-devel] [PATCH 4/5] iohandlers: Enable an iohandler only if the associated handler exists

2011-01-13 Thread Amit Shah
If an iohandler is asked to be enabled but the handler doesn't exist, don't enable the handler. This can be used to simplify the conditions in main_loop_wait(). Signed-off-by: Amit Shah amit.s...@redhat.com --- vl.c | 29 - 1 files changed, 20 insertions(+), 9

[Qemu-devel] [PATCH 1/5] iohandlers: Avoid code duplication

2011-01-13 Thread Amit Shah
Add a get_iohandler() function instead of looking up the ioh twice in qemu_set_fd_handler2(). Signed-off-by: Amit Shah amit.s...@redhat.com --- vl.c | 44 ++-- 1 files changed, 26 insertions(+), 18 deletions(-) diff --git a/vl.c b/vl.c index

Re: [Qemu-devel] [PATCH v2] gdbstub: Close connection in gdb_exit

2011-01-13 Thread Edgar E. Iglesias
On Thu, Jan 13, 2011 at 12:46:57PM +0100, Fabien Chouteau wrote: On Windows, this is required to flush the remaining data in the IO stream, otherwise Gdb do not receive the last packet. Version 2: Fix linux-user build error. Hi, It seems a bit odd to explicitely close for system mode but

[Qemu-devel] [PATCH 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-13 Thread Amit Shah
Hi, This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque) -- Specify io handlers for an fd int remove_fd_handlers(int fd) -- Remove fd handlers for fd (mark ioh for deletion) int set_read_poll_fd_action(int fd,

[Qemu-devel] [PATCH 2/5] iohandlers: Introduce assign_fd_handlers() and remove_fd_handlers

2011-01-13 Thread Amit Shah
This function will be used to assign fd handlers. Future commits will be enable each handler to be enabled/disabled individually. Make qemu_set_fd_handler2() a wrapper to assign_fd_handlers(). remove_fd_handlers() removes all the assigned handlers and marks the iohandler for deletion. It's a

[Qemu-devel] [PATCH 5/5] iohandlers: Add IOHandlerOps struct

2011-01-13 Thread Amit Shah
Collect all the handlers in a IOHandlerOps struct instead of being passed one at a time to each function. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.h |7 ++- vl.c| 51 --- 2 files changed, 34 insertions(+), 24

Re: [Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh

2011-01-13 Thread Markus Armbruster
David Ahern daah...@cisco.com writes: make_device_config currently emits an error: make config-all-devices.mak GEN x86_64-softmmu/config-devices.mak /home/dsa/kvm/releases/qemu.git/make_device_config.sh: line 21: /home/dsa/kvm/releases/qemu.git/default-configs/pci.mak : No such file or

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +set_read_poll_fd_action(fd, true); +set_read_fd_action(fd, true); +set_write_fd_action(fd,

[Qemu-devel] Re: [PATCH 2/5] iohandlers: Introduce assign_fd_handlers() and remove_fd_handlers

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 14:00, Amit Shah wrote: This function will be used to assign fd handlers. Future commits will be enable each handler to be enabled/disabled individually. Make qemu_set_fd_handler2() a wrapper to assign_fd_handlers(). remove_fd_handlers() removes all the assigned handlers and marks

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Amit Shah
On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote: On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +set_read_poll_fd_action(fd, true); +

[Qemu-devel] Re: [PATCH 5/5] iohandlers: Add IOHandlerOps struct

2011-01-13 Thread Gerd Hoffmann
Hi, +ioh-ops.fd_read_poll = ops-fd_read_poll; +ioh-ops.fd_read = ops-fd_read; +ioh-ops.fd_write = ops-fd_write; You can write this as ioh-ops = *ops btw. I guess the long-term plan (to be committed after killing the last user of the old interface) is to store a pointer to the

[Qemu-devel] Re: [PATCH 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 14:00, Amit Shah wrote: Hi, This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque) -- Specify io handlers for an fd int remove_fd_handlers(int fd) -- Remove fd handlers for fd (mark ioh for

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 15:00, Amit Shah wrote: On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote: On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +

[Qemu-devel] Re: [PATCH 5/5] iohandlers: Add IOHandlerOps struct

2011-01-13 Thread Amit Shah
On (Thu) Jan 13 2011 [15:02:37], Gerd Hoffmann wrote: Hi, +ioh-ops.fd_read_poll = ops-fd_read_poll; +ioh-ops.fd_read = ops-fd_read; +ioh-ops.fd_write = ops-fd_write; You can write this as ioh-ops = *ops btw. I guess the long-term plan (to be committed after killing the

[Qemu-devel] Re: [PATCH 2/5] iohandlers: Introduce assign_fd_handlers() and remove_fd_handlers

2011-01-13 Thread Amit Shah
On (Thu) Jan 13 2011 [14:59:26], Gerd Hoffmann wrote: +int assign_fd_handlers(int fd, + IOCanReadHandler *fd_read_poll, + IOHandler *fd_read, + IOHandler *fd_write, + void *opaque); +void

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Amit Shah
On (Thu) Jan 13 2011 [15:08:51], Gerd Hoffmann wrote: On 01/13/11 15:00, Amit Shah wrote: On (Thu) Jan 13 2011 [14:55:25], Gerd Hoffmann wrote: On 01/13/11 14:00, Amit Shah wrote: { -return assign_fd_handlers(fd, fd_read_poll, fd_read, fd_write, opaque); +assign_fd_handlers(fd,

Re: [Qemu-devel] [PATCH 0/8] misc cleanups for x86_64 disabling config settings

2011-01-13 Thread David Ahern
On 01/13/11 02:57, Isaku Yamahata wrote: How about creating stub functions instead of #ifdefs? something like pc-stubs.c #ifndef CONFIG_VMWARE_VGA pci_vmsvga_init() { error ... } #endif #ifndef CONFIG_... ... I wasn't trying to re-architect how the CONFIG_ is implemented;

Re: [Qemu-devel] [PATCH 1/8] fix 'no such file' error from make_device_config.sh

2011-01-13 Thread David Ahern
On 01/13/11 06:43, Markus Armbruster wrote: David Ahern daah...@cisco.com writes: make_device_config currently emits an error: make config-all-devices.mak GEN x86_64-softmmu/config-devices.mak /home/dsa/kvm/releases/qemu.git/make_device_config.sh: line 21:

[Qemu-devel] Re: [PATCH 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Gerd Hoffmann
Hi, I can't see such a race window given that most qemu code runs serialized anyway. If you call assign_fd_handlers() + set_write_fd_action(false) in sequence I can't see how a select call can happen inbetween ... Not today, but later when we have threads doing this stuff? Unlikely I

Re: [Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2011-01-13 Thread Kevin Wolf
Am 23.12.2010 22:58, schrieb Nicholas A. Bellinger: On Tue, 2010-12-21 at 12:49 +1100, Benjamin Herrenschmidt wrote: Yep, so it appears that commit 89c0f6438d16 did introduce the bogus 'double complete' in scsi_read_complete, which I think was intended to handle residual counts for

[Qemu-devel] [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-13 Thread Amit Shah
Hi, This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque) -- Specify io handlers for an fd int remove_fd_handlers(int fd) -- Remove fd handlers for fd (mark ioh for deletion) int set_read_poll_fd_action(int fd,

[Qemu-devel] [PATCH v2 5/5] iohandlers: Add IOHandlerOps struct

2011-01-13 Thread Amit Shah
Collect all the handlers in a IOHandlerOps struct instead of being passed one at a time to each function. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.h |7 ++- vl.c| 56 2 files changed, 38 insertions(+),

Re: spice vdagent protocol, was Re: [Qemu-devel] KVM call minutes for Jan 11

2011-01-13 Thread Adam Litke
On Tue, 2011-01-11 at 20:33 +0200, Alon Levy wrote: Spice guest agent: - virt agent, matahari, spice agent...what is in spice agent? - spice char device - mouse, copy 'n paste, screen resolution change - could be generic (at least input and copy/paste) - send protocol details of

[Qemu-devel] [PATCH v2 1/5] iohandlers: Avoid code duplication

2011-01-13 Thread Amit Shah
Add a get_iohandler() function instead of looking up the ioh twice in qemu_set_fd_handler2(). Signed-off-by: Amit Shah amit.s...@redhat.com --- vl.c | 44 ++-- 1 files changed, 26 insertions(+), 18 deletions(-) diff --git a/vl.c b/vl.c index

[Qemu-devel] [PATCH v2 2/5] iohandlers: Introduce assign_fd_handlers() and remove_fd_handlers

2011-01-13 Thread Amit Shah
This function will be used to assign fd handlers. Future commits will be enable each handler to be enabled/disabled individually. Make qemu_set_fd_handler2() a wrapper to assign_fd_handlers(). remove_fd_handlers() removes all the assigned handlers and marks the iohandler for deletion. It's a

[Qemu-devel] [PATCH v2 4/5] iohandlers: Enable an iohandler only if the associated handler exists

2011-01-13 Thread Amit Shah
If an iohandler is asked to be enabled but the handler doesn't exist, don't enable the handler. This can be used to simplify the conditions in main_loop_wait(). Signed-off-by: Amit Shah amit.s...@redhat.com --- vl.c | 29 - 1 files changed, 20 insertions(+), 9

[Qemu-devel] [PATCH v2 3/5] iohandlers: Allow each iohandler to be enabled/disabled individually

2011-01-13 Thread Amit Shah
Each iohandler for an fd can now be individually enabled or disabled. Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.h |4 +++ vl.c| 78 -- 2 files changed, 79 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] No rule to make target ../libhw32/virtio.o

2011-01-13 Thread Mateusz Loskot
Hi, I'm building current Git master (SHA1:facf1a60) using latest MingW32 on Windows Vista and compilation fails with the following error: g:/src/qemu/_git/master/disas.c: In function 'generic_print_address': g:/src/qemu/_git/master/disas.c:65:5: warning: 'I' flag used with '%x' gnu_printf

[Qemu-devel] Re: [PATCH v2 0/5] iohandlers: Add support for enabling/disabling individual handlers

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 16:00, Amit Shah wrote: This patchset adds new interfaces to work with iohandlers. It adds: int assign_fd_handlers(int fd, IOHandlerOps *ops, void *opaque) -- Specify io handlers for an fd int remove_fd_handlers(int fd) -- Remove fd handlers for fd (mark ioh for deletion)

Re: [Qemu-devel] No rule to make target ../libhw32/virtio.o

2011-01-13 Thread Mark Cave-Ayland
On 13/01/11 15:09, Mateusz Loskot wrote: Hi, I'm building current Git master (SHA1:facf1a60) using latest MingW32 on Windows Vista and compilation fails with the following error: g:/src/qemu/_git/master/disas.c: In function 'generic_print_address': g:/src/qemu/_git/master/disas.c:65:5:

[Qemu-devel] Re: Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-13 Thread Mateusz Loskot
On 07/01/11 17:28, Mateusz Loskot wrote: I'm wondering if the following setup would work at all: 1. Quad-core workstation with 16GB RAM with Windows Vista 64-bit as host OS 2. The Windows runs VirtualBox with Linux installed as guest OS. 3. The Linux guest OS runs QEMU 4. QEMU runs Solaris

[Qemu-devel] [PATCH 1/3] mainstone: fix name of the allocated memory for roms

2011-01-13 Thread Dmitry Eremin-Solenikov
Mainstone board has two flash chips (emulated by two ram regions), however currently code tries to allocate them with the same name, which fails. Fix that to make mainstone emulation work again. Signed-off-by: Dmitry Eremin-Solenikov dbarysh...@gmail.com --- hw/mainstone.c |2 +- 1 files

[Qemu-devel] [PATCH 2/3] Scoop: fix access to registers from second instance

2011-01-13 Thread Dmitry Eremin-Solenikov
Second instance of scoop contains registers shifted to 0x40 from the start of the page. Instead of messing with register mapping, just limit register address to 0x00..0x3f. Signed-off-by: Dmitry Eremin-Solenikov dbarysh...@gmail.com --- hw/zaurus.c |4 ++-- 1 files changed, 2 insertions(+),

[Qemu-devel] [PATCH 3/3] pxa2xx: fix vmstate_pxa2xx_i2c

2011-01-13 Thread Dmitry Eremin-Solenikov
vmstate_pxa2xx_i2c incorrectly recursed to itself instead of going to store slave device. Fix that stop stop qemu from segfaulting during savevm for pxa2xx-based devices. Signed-off-by: Dmitry Eremin-Solenikov dbarysh...@gmail.com --- hw/pxa2xx.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH 1/3] ide: factor dma handling helpers

2011-01-13 Thread Kevin Wolf
Am 20.12.2010 13:45, schrieb Christoph Hellwig: Factor the DMA I/O path that is duplicated between read and write commands, into common helpers using the s-is_read flag added for the macio ATA controller. Signed-off-by: Christoph Hellwig h...@lst.de Thanks, applied all to the block branch.

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 04:19 AM, Gerd Hoffmann wrote: Hi, Just throwing a quick writeup into the ring to kickstart the design discussion ;) cheers, Gerd #ifndef __QEMU_PVTABLET__ #define __QEMU_PVTABLET__ 1 /* * qemu patavirtual tablet interface */ #includeinttypes.h /* our virtio-serial

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 05:51 AM, Gerd Hoffmann wrote: On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the windowing system to process input events and

Re: [Qemu-devel] Linux as VirtualBox quest OS with QEMU running Solaris

2011-01-13 Thread Mateusz Loskot
On 13/01/11 12:40, Mateusz Loskot wrote: On 13/01/11 10:13, Michal Suchanek wrote: On 13 January 2011 00:34, Mateusz Loskotmate...@loskot.net wrote: On 12/01/11 17:15, Mateusz Loskot wrote: On 12/01/11 16:48, Michal Suchanek wrote: On 12 January 2011 16:21, Mateusz Loskotmate...@loskot.net

Re: [Qemu-devel] No rule to make target ../libhw32/virtio.o

2011-01-13 Thread Mateusz Loskot
On 13/01/11 15:24, Mark Cave-Ayland wrote: On 13/01/11 15:09, Mateusz Loskot wrote: Hi, I'm building current Git master (SHA1:facf1a60) using latest MingW32 on Windows Vista and compilation fails with the following error: g:/src/qemu/_git/master/disas.c: In function 'generic_print_address':

Re: [Qemu-devel] Re: KVM call agenda for Jan 11

2011-01-13 Thread Avi Kivity
On 01/11/2011 04:43 PM, Anthony Liguori wrote: - invalidate all buffers for that block device on machine A after migration. * with NFS, just close + reopen the file (and pray that nobody else has it also opened) * with block devices: use BLKFLBLK ioctl, and pray that nobody else

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Avi Kivity
On 01/13/2011 05:52 PM, Anthony Liguori wrote: /* host-guest, sent before any other events */ typedef struct qemu_pvtablet_init { uint32_t res_x; /* x axis resolution */ uint32_t res_y; /* y axis resolution */ uint32_t features; /* qemu_pvtablet_features */ uint32_t

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Avi Kivity
On 01/13/2011 12:19 PM, Gerd Hoffmann wrote: Hi, Just throwing a quick writeup into the ring to kickstart the design discussion ;) typedef struct qemu_pvtablet_message { uint32_t size;/* whole message size */ uint32_t type;/* qemu_pvtablet_type */

[Qemu-devel] Re: [fedora-virt] Fedora Virt status

2011-01-13 Thread Boris Derzhavets
Windows 7 KVM install runs unbelievably fast on SL 6 ( alpha 3) vs F14 with the most recent libvirt stuff : [root@fedora14b ~]# rpm -qa|grep libvirt libvirt-python-0.8.7-1.fc14.x86_64 libvirt-0.8.7-1.fc14.x86_64 libvirt-client-0.8.7-1.fc14.x86_64 Boris. P.S. It happens no matter of pre-install

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 10:14 AM, Avi Kivity wrote: On 01/13/2011 05:52 PM, Anthony Liguori wrote: /* host-guest, sent before any other events */ typedef struct qemu_pvtablet_init { uint32_t res_x; /* x axis resolution */ uint32_t res_y; /* y axis resolution */ uint32_t features; /*

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Anthony Liguori
On 01/13/2011 10:18 AM, Avi Kivity wrote: On 01/13/2011 12:19 PM, Gerd Hoffmann wrote: Hi, Just throwing a quick writeup into the ring to kickstart the design discussion ;) typedef struct qemu_pvtablet_message { uint32_t size;/* whole message size */ uint32_t type;

Re: [Qemu-devel] Re: [Spice-devel] paravirtual mouse/tablet

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 16:55, Anthony Liguori wrote: On 01/13/2011 05:51 AM, Gerd Hoffmann wrote: On 01/13/11 12:01, Stefan Hajnoczi wrote: Can you elaborate how the spice display channel comes into play? On a physical machine you just have input devices with no notion of display. It's up to the

[Qemu-devel] Re: [PATCH 8/8] x86_64 config: fix compile for CONFIG_FDC=n

2011-01-13 Thread Paolo Bonzini
On 01/13/2011 07:34 AM, David Ahern wrote: +#ifdef CONFIG_FDC /* floppy type */ fd0 = fdctrl_get_drive_type(floppy_controller, 0); @@ -403,6 +408,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t above_4g_mem_size, val |= 0x02; /* FPU is there */ val |= 0x04; /*

[Qemu-devel] Re: [PATCH 0/8] misc cleanups for x86_64 disabling config settings

2011-01-13 Thread Paolo Bonzini
On 01/13/2011 10:57 AM, Isaku Yamahata wrote: How about creating stub functions instead of #ifdefs? I think David's #ifdef's are okay. Ultimately what you'd want is to drive all this from configuration files, and if this were done you wouldn't need stub functions. Paolo

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Paolo Bonzini
On 01/13/2011 05:39 PM, Anthony Liguori wrote: On 01/13/2011 10:14 AM, Avi Kivity wrote: On 01/13/2011 05:52 PM, Anthony Liguori wrote: /* host-guest, sent before any other events */ typedef struct qemu_pvtablet_init { uint32_t res_x; /* x axis resolution */ uint32_t res_y; /* y axis

[Qemu-devel] Re: [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n

2011-01-13 Thread Paolo Bonzini
On 01/13/2011 07:34 AM, David Ahern wrote: Signed-off-by: David Aherndaah...@cisco.com --- hw/pc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index e7514fd..11b570f 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -1087,8 +1087,10 @@ void

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Alexander Graf
On 13.01.2011, at 17:39, Anthony Liguori wrote: On 01/13/2011 10:14 AM, Avi Kivity wrote: On 01/13/2011 05:52 PM, Anthony Liguori wrote: /* host-guest, sent before any other events */ typedef struct qemu_pvtablet_init { uint32_t res_x; /* x axis resolution */ uint32_t res_y; /*

[Qemu-devel] [PATCH 02/19] Introduce read() to FdMigrationState.

2011-01-13 Thread Yoshiaki Tamura
Currently FdMigrationState doesn't support read(), and this patch introduces it to get response from the other side. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- migration-tcp.c | 15 +++ migration.c | 12 migration.h |3 +++ 3 files

[Qemu-devel] [PATCH 12/19] Insert event_tap_mmio() to cpu_physical_memory_rw() in exec.c.

2011-01-13 Thread Yoshiaki Tamura
Record mmio write event to replay it upon failover. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- exec.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index 49c28b1..4a171cc 100644 --- a/exec.c +++ b/exec.c @@ -33,6 +33,7 @@

[Qemu-devel] [PATCH 15/19] savevm: introduce qemu_savevm_trans_{begin, commit}.

2011-01-13 Thread Yoshiaki Tamura
Introduce qemu_savevm_state_{begin,commit} to send the memory and device info together, while avoiding cancelling memory state tracking. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- savevm.c | 88 ++ sysemu.h |

[Qemu-devel] [PATCH 01/19] Make QEMUFile buf expandable, and introduce qemu_realloc_buffer() and qemu_clear_buffer().

2011-01-13 Thread Yoshiaki Tamura
Currently buf size is fixed at 32KB. It would be useful if it could be flexible. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |2 ++ savevm.c | 20 +++- 2 files changed, 21 insertions(+), 1 deletions(-) diff --git a/hw/hw.h b/hw/hw.h index

Re: [Qemu-devel] paravirtual mouse/tablet

2011-01-13 Thread Gerd Hoffmann
On 01/13/11 17:18, Avi Kivity wrote: On 01/13/2011 12:19 PM, Gerd Hoffmann wrote: Hi, Just throwing a quick writeup into the ring to kickstart the design discussion ;) typedef struct qemu_pvtablet_message { uint32_t size; /* whole message size */ uint32_t type; /* qemu_pvtablet_type */

[Qemu-devel] [PATCH 16/19] migration: introduce migrate_ft_trans_{put, get}_ready(), and modify migrate_fd_put_ready() when ft_mode is on.

2011-01-13 Thread Yoshiaki Tamura
Introduce migrate_ft_trans_put_ready() which kicks the FT transaction cycle. When ft_mode is on, migrate_fd_put_ready() would open ft_trans_file and turn on event_tap. To end or cancel FT transaction, ft_mode and event_tap is turned off. migrate_ft_trans_get_ready() is called to receive ack

[Qemu-devel] [PATCH 09/19] Introduce event-tap.

2011-01-13 Thread Yoshiaki Tamura
event-tap controls when to start FT transaction, and provides proxy functions to called from net/block devices. While FT transaction, it queues up net/block requests, and flush them when the transaction gets completed. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Signed-off-by:

[Qemu-devel] [PATCH 04/19] qemu-char: export socket_set_nodelay().

2011-01-13 Thread Yoshiaki Tamura
Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- qemu-char.c |2 +- qemu_socket.h |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index edc9ad6..737d347 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2116,7 +2116,7 @@ static

[Qemu-devel] [PATCH 14/19] block: insert event-tap to bdrv_aio_writev() and bdrv_aio_flush().

2011-01-13 Thread Yoshiaki Tamura
event-tap function is called only when it is on, and requests sent from device emulators. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- block.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index ff2795b..85bd8b8 100644

[Qemu-devel] [PATCH 08/19] savevm: introduce util functions to control ft_trans_file from savevm layer.

2011-01-13 Thread Yoshiaki Tamura
To utilize ft_trans_file function, savevm needs interfaces to be exported. Signed-off-by: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp --- hw/hw.h |5 ++ savevm.c | 148 ++ 2 files changed, 153 insertions(+), 0 deletions(-) diff

[Qemu-devel] Re: [PATCH 6/8] x86_64 config: fix compile for CONFIG_VGA_ISA=n

2011-01-13 Thread David Ahern
On 01/13/11 10:02, Paolo Bonzini wrote: On 01/13/2011 07:34 AM, David Ahern wrote: Signed-off-by: David Aherndaah...@cisco.com --- hw/pc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index e7514fd..11b570f 100644 --- a/hw/pc.c +++

  1   2   >